-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code to make MTM as recommended install by default instead of JS code #22420
Draft
AltamashShaikh
wants to merge
7
commits into
5.x-dev
Choose a base branch
from
PG-3568-make-mtm-default-on-no-data-screen
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add code to make MTM as recommended install by default instead of JS code #22420
AltamashShaikh
wants to merge
7
commits into
5.x-dev
from
PG-3568-make-mtm-default-on-no-data-screen
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AltamashShaikh the UI failure is related to the no-data screen somehow, can you check? Thanks |
@michalkleiner new screenshot was missing added that, was waiting for tests to finish |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Aug 8, 2024
AltamashShaikh
added
the
Do not close
PRs with this label won't be marked as stale by the Close Stale Issues action
label
Aug 8, 2024
github-actions
bot
removed
the
Stale
The label used by the Close Stale Issues action
label
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add code to make MTM as recommended install by default instead of JS code
Fixes: #PG-3586
Review