Skip to content

fixed the read me to include the non git version#429

Open
killertofus wants to merge 4 commits intomatinlotfali:masterfrom
killertofus:aurpackage
Open

fixed the read me to include the non git version#429
killertofus wants to merge 4 commits intomatinlotfali:masterfrom
killertofus:aurpackage

Conversation

@killertofus
Copy link

side note: since aur helpers are not supported by arch, https://wiki.archlinux.org/title/AUR_helpers using pamac is discouraged

@matinlotfali
Copy link
Owner

AUR is maintained by the community (@xiota); it is not officially maintained by the Arch distribution team. So you discourage it.
Similarly, Copr is maintained by the community; it is not officially maintained by the Fedora distribution team. Maybe you discourage Copr too?

Lastly, this effect and repository are developed and maintained by the community, it is not officially maintained by KDE Plasma developers.
So maybe you should discourage the whole effect as well?

I mean whoever comes here is already trusting the non-official code and would probably not care about the trustworthiness of AUR or Copr.

@xiota
Copy link
Contributor

xiota commented Oct 14, 2025

The readme mentions use of two different AUR helpers. Would be good to remove both. For the AUR section, would be suitable to just link the ArchWiki article Arch User Repository, so anyone not already familiar with it can learn more.

It's not right to replace the -git package with the stable one in the readme, and it's premature to even add it. I did not create a stable package myself for a couple reasons. (1) They need to be manually bumped. The most recent stable version, 0.8.5, was released two weeks ago, but the stable package was not bumped until yesterday. (2) They have to be build tested and patched. The current stable package fails to build because the maintainer did not test and backport fixes.

Mention of specific distros in the build from source section can be removed because it's mainly an exercise in using package managers. The following can be noted: (1) List of current dependencies. (2) Some distros have separate development packages that may need to be installed (-dev, -devel). (3) The configure step will notify of missing depends.

@matinlotfali If desired, I can open a separate PR with some or all of the above changes.

@matinlotfali
Copy link
Owner

matinlotfali commented Oct 14, 2025

The reason for having distro-specific dependency install sections in the README.md is to allow an easy copy and paste.

On one hand, I personally like it because when I try the effect on different distros on VMs, I need a fast way of getting on with the dependency installations. On the other hand, I assume the majority of people who visit the repo are desktop ricing fans who may also like distro hopping. So we may have the opportunity to give our audience more knowledge by providing them with more reading materials.

Having said that, I want the README.md to be suitable for both lazy and thirsty groups of audience.

@matinlotfali matinlotfali requested a review from xiota October 14, 2025 19:59
@matinlotfali
Copy link
Owner

@xiota may I ask you to review again?

@xiota
Copy link
Contributor

xiota commented Nov 29, 2025

The problem is the state of the stable packages on AUR.

For instance, you had notified me when the wayland and x11 versions were changed to use shared resources. The -git packages manage it by making the -x11 package depend on the main package for resources. The stable -x11 package still lists the wayland version as an optdep.

Update: Stable packages in this regard are okay for now. Change was in e513990. I'd prefer to wait until it's included in a release to ensure stable packages are updated. This doc change gives priority to the stable packages, so would not be good if they have problems later.

@matinlotfali
Copy link
Owner

I can prepare a release today.

@killertofus killertofus marked this pull request as draft December 7, 2025 22:26
@matinlotfali matinlotfali marked this pull request as ready for review January 9, 2026 16:36
@matinlotfali
Copy link
Owner

@xiota can you review again?

@xiota
Copy link
Contributor

xiota commented Jan 9, 2026

I saw that the aur stable packages were updated shortly after release, but they kept the optional dep relationship without rectifying the conflicting files.

However, I'm thinking about revising the -git packages. Wayland use seems to far outweigh X11 now. Here are Chaotic AUR metrics:

  • kwin-effect-rounded-corners-x11-git # 90
  • kwin-effect-rounded-corners-git # 23668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants