Remove SSO_PAGE_HEADERS from login POST and MFA verify#218
Remove SSO_PAGE_HEADERS from login POST and MFA verify#218
Conversation
PR #215 re-introduced browser headers on the login POST and MFA verify endpoints. These are mobile API endpoints that expect the default GCM-iOS user agent — browser headers cause 401/429 from Garmin. Same regression as 0.7.7, fixed in 0.7.8, re-introduced in 0.7.10. Browser headers should ONLY be on page requests (sign-in, embed). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughRemoved Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 68 68
Lines 3569 3569
=======================================
Hits 3566 3566
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
PR #215 re-introduced browser headers (
SSO_PAGE_HEADERS) on the login POST and MFA verify. This is the same regression as 0.7.7 (fixed in 0.7.8). These are mobile API endpoints that expect the defaultGCM-iOSuser agent — browser headers cause 401/429.Confirmed via logfire session
3da2a002cbad48ea— login POST sending browser UA and getting 429.Header rules:
SSO_PAGE_HEADERS)GCM-iOS-5.22.1.4)com.garmin.android.apps.connectmobile)Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores