Skip to content

Use dynamic MFA method from login response #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matin merged 1 commit into from
Mar 19, 2026
Merged

Use dynamic MFA method from login response #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/garth/sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,17 @@ def login(
return _complete_login(ticket, client)

if resp_type == SSO_MFA_REQUIRED:
mfa_info = resp_json.get("customerMfaInfo") or {}
mfa_method = mfa_info.get("mfaLastMethodUsed") or "email"
if return_on_mfa or prompt_mfa is None:
return "needs_mfa", {
"login_params": login_params,
"client": client,
"mfa_method": mfa_method,
}
ticket = handle_mfa(client, login_params, prompt_mfa)
ticket = handle_mfa(
client, login_params, prompt_mfa, mfa_method=mfa_method
)
return _complete_login(ticket, client)

_parse_sso_response(resp_json, SSO_SUCCESSFUL)
Expand Down Expand Up @@ -198,7 +203,11 @@ def exchange(


def handle_mfa(
client: http.Client, login_params: dict, prompt_mfa: Callable
client: http.Client,
login_params: dict,
prompt_mfa: Callable,
*,
mfa_method: str = "email",
) -> str:
if inspect.iscoroutinefunction(prompt_mfa):
mfa_code = asyncio.run(prompt_mfa())
Expand All @@ -209,7 +218,7 @@ def handle_mfa(
"/mobile/api/mfa/verifyCode",
params=login_params,
json={
"mfaMethod": "email",
"mfaMethod": mfa_method,
"mfaVerificationCode": mfa_code,
"rememberMyBrowser": False,
"reconsentList": [],
Expand All @@ -233,7 +242,10 @@ def resume_login(
) -> tuple[OAuth1Token, OAuth2Token]:
client = client_state["client"]
login_params = client_state["login_params"]
ticket = handle_mfa(client, login_params, lambda: mfa_code)
mfa_method = client_state.get("mfa_method", "email")
ticket = handle_mfa(
client, login_params, lambda: mfa_code, mfa_method=mfa_method
)
return _complete_login(ticket, client)


Expand Down
2 changes: 1 addition & 1 deletion src/garth/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.7.9"
__version__ = "0.7.10"
Loading