Skip to content

Allow removing slide event listeners #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow removing slide event listeners #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfacad5
Allow removing `slide` event listeners
pjhenning Feb 25, 2021
852a3b2
Add curly braces
pjhenning Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,25 +214,37 @@ export function slide($el: ElementView, fns: SlideEventOptions) {
$el.on('pointerdown', start);
if (fns.justInside) $el.on('mouseleave', end);

if (fns.accessible) {
$el.setAttr('tabindex', '0');
document.addEventListener('keydown', (e: KeyboardEvent) => {
if (![37, 38, 39, 40].includes(e.keyCode)) return;
if ($el !== Browser.getActiveInput()) return;
function accessibilityHandler(e: KeyboardEvent) {
if (![37, 38, 39, 40].includes(e.keyCode)) return;
if ($el !== Browser.getActiveInput()) return;

const center = $el.boxCenter;
const start = posn({clientX: center.x, clientY: center.y});
const center = $el.boxCenter;
const start = posn({clientX: center.x, clientY: center.y});

const dx = (e.keyCode === 37) ? -25 : (e.keyCode === 39) ? 25 : 0;
const dy = (e.keyCode === 38) ? -25 : (e.keyCode === 40) ? 25 : 0;
const end = start.shift(dx, dy);
const dx = (e.keyCode === 37) ? -25 : (e.keyCode === 39) ? 25 : 0;
const dy = (e.keyCode === 38) ? -25 : (e.keyCode === 40) ? 25 : 0;
const end = start.shift(dx, dy);

if (fns.down) fns.down(start);
if (fns.start) fns.start(start);
if (fns.move) fns.move(end, start, start);
if (fns.end) fns.end(end, start);
});
if (fns.down) fns.down(start);
if (fns.start) fns.start(start);
if (fns.move) fns.move(end, start, start);
if (fns.end) fns.end(end, start);
}

if (fns.accessible) {
$el.setAttr('tabindex', '0');
document.addEventListener('keydown', accessibilityHandler);
}

function remove() {
$el.off('pointerdown', start);
if (fns.justInside) $el.off('mouseleave', end);
if (fns.accessible) {
document.removeEventListener('keydown', accessibilityHandler);
}
}

return remove;
}


Expand Down