Fix #79 Drop Narwhal (deprecated) support#80
Fix #79 Drop Narwhal (deprecated) support#80hsandt wants to merge 2 commits intomathiasbynens:masterfrom
Conversation
Remove all references to Narwhal and OpenJDK 6 This should also fix Travis builds
|
hey hsandt, could you merge and release all your fixes in your fork? It seems these PRs aren't getting reviewed.. |
|
Hm where to where exactly? master, or another branch you're using? I haven't merged fix-travis in particular as I never managed to fully fix Travis on my project, as I kept encountering incompatibilities. CI is apparently using particular flavours of JS interpreters, we could probably drop a few. Since the "enclosed function" test failure prevented me from testing CI properly, I branched from before the commit that introduced it (see #62), and made a feature/cleanup-deps branch. There, I found an issue with phantomjs only on my custom code using new ECMAScript method String.prototype.startsWith (for convenience, substring works just as well), as it was too old (1.9). Since it's not updated anymore, I just removed it. But then I still had an issue with Ringo: https://travis-ci.org/github/hsandt/luamin/jobs/730000374 I don't know the other environments enough to tell which ones are still worth supporting (rhino, ringo) but I may just remove everything but node if it's for my own fork and I feel a bit more free. Is this what you're aiming for? Without going before #64 you may not even have noticed these incompatibility issues though, so maybe you were rather speaking about non-Travis fixes? |
Used version of phantomjs was 1.9 which didn't have new functions like String.prototype.startsWith and may cause issue with code using new ECMAScript features, so we should either upgrade it or remove it. This commit does the latter.
OK, 2 years later, I finally made it:
The issues I mentioned are still there. I just merged the fixes into stable and the fixes + features in develop. I also just added one more fix on both (Lua 5.4 operator precedence). |
Remove all references to Narwhal and OpenJDK 6
This should also fix Travis builds