Initial commit#592
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is a great submission with a well-organized structure and functional API endpoints. However, changes are needed because a core requirement from the task description was missed.
The application needs to create the database tables from the SQLAlchemy models when it starts up. This logic is currently missing from main.py. You can implement this by importing Base from models and engine from database, and then calling Base.metadata.create_all(bind=engine) before the app runs.
Additionally, here are a couple of minor suggestions for improvement:
- In
crud.py, the type hint forauthor_idinget_all_booksshould beint | Noneto accurately reflect that it can beNone. - There's a small typo in
schemas.py:AutorNestedSchemashould beAuthorNestedSchema.
Once you've added the table creation logic, this will be ready for approval. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| db: Session, | ||
| to_skip: int, | ||
| to_limit: int, | ||
| author_id: int |
There was a problem hiding this comment.
The type hint for author_id is int, but it can receive None from the endpoint in main.py. To make the type hint accurate, you should indicate that it can also be None. You can use Optional[int] from the typing module or int | None (for Python 3.10+).
| ) | ||
| from database import get_db | ||
|
|
||
| app = FastAPI() |
There was a problem hiding this comment.
The requirements state that you should create the database tables from the SQLAlchemy models within the main.py file. This is typically done at application startup. You're missing the call to Base.metadata.create_all(bind=engine) here. You would need to import Base from models and engine from database to do this.
| from pydantic import BaseModel, Field, ConfigDict | ||
|
|
||
|
|
||
| class AutorNestedSchema(BaseModel): |
There was a problem hiding this comment.
There's a small typo in the class name. It seems it should be AuthorNestedSchema to be consistent with the other class names like AuthorReadSchema and AuthorCreateSchema.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution. You've successfully addressed all the previous feedback, especially the critical fix to create the database tables on startup. Your implementation of FastAPI, SQLAlchemy, and Pydantic is solid, and the overall application structure is clean and correct. All requirements have been met. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.