Develop

[n-korobko]

No description provided.

[mateacademy-ai-mentor]

Review Summary

Great job setting up the foundational structure of the API, including the models, schemas, and database connection. However, changes are needed because several core features are not yet functional.

Here are the critical issues to address:

1. Pagination is not implemented: The /authors/ and /books/ endpoints in main.py correctly accept skip and limit parameters, but the corresponding get_authors and get_books functions in crud.py don't accept them. You'll need to update the function signatures and modify the database queries to use .offset(skip).limit(limit).

2. Book filtering is broken: The endpoint to get books by author (/authors/{author_id}/books/) calls a function crud.get_books_by_author that doesn't exist in crud.py. You need to implement this function to query the database and return books for a given author_id.

Once these functions are implemented correctly, the API should meet all the requirements. Keep up the great work!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Review Summary

Excellent work on this project! I am approving your submission as you've successfully addressed all the feedback from the previous review, and the API is now fully functional. The implementation of pagination in crud.py and the creation of the get_books_by_author function have resolved the previous issues perfectly. The project now meets all requirements and demonstrates a solid understanding of building APIs with FastAPI and SQLAlchemy. Keep up the great work!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩