Remove unnecessary textColor
props from PicklistItem
#500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just removed
textColor='currentColor'
prop from general icons inPicklistItem
.This is because it would be too much to apply it, as far as confirming references below.
References
Though this example is regarding
Menus
, general icons don't have.slds-current-color
.In the spec of
Picklist
, there is no example that has general icons.In this
Picklist
example, though check mark icons are used, general icons aren't.At least, the check mark icons have
.slds-current-color
.