* Result block value for SevenZipReader.open & .open_file#26
Open
PikachuEXE wants to merge 1 commit intomasamitsu-murase:masterfrom
Open
* Result block value for SevenZipReader.open & .open_file#26PikachuEXE wants to merge 1 commit intomasamitsu-murase:masterfrom
PikachuEXE wants to merge 1 commit intomasamitsu-murase:masterfrom
Conversation
They were always returning `nil` (from SevenZipReader#close_file) Also changed &block + block.call to block_given? + yield
PikachuEXE
force-pushed
the
feature/return-block-value
branch
from
7532c11 to
ffc6edc
Compare
Author
|
This solves #24 |
Author
|
@masamitsu-murase |
Author
|
Hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were always returning
nil(from SevenZipReader#close_file)Also changed &block + block.call to block_given? + yield