Repository navigation
Conversation
Kusama/Polkadot use U128CurrencyToVote which scales stake based on total issuance: vote = stake / max(issuance/u64::MAX, 1). If total issuance exceeds u64::MAX, scaling factor > 1. Previously the tool used stake.active directly, causing stake weight discrepancies on Kusama compared to on-chain snapshots.
Contributor
Author
|
an attempt to fix the issue, @martinmsb @filippoweb3 |
Contributor
|
@sigurpol thank you for the suggestion. It seems these changes do not change the simulations, i.e. built snapshot shows the tiny differences in stake compared to the fetched one, and predictions using the fetched snapshot are still inaccurate |
Contributor
Author
|
Yeah I got it wrong, double checked and
Dropping this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kusama/Polkadot use U128CurrencyToVote which scales stake based on total issuance: vote = stake / max(issuance/u64::MAX, 1). If total issuance exceeds u64::MAX, scaling factor > 1.
Previously the tool used stake.active directly, causing stake weight discrepancies on Kusama compared to on-chain snapshots.