Skip to content

Detect ambiguous MCP resource URIs#195

Merged
martian56 merged 1 commit into
mainfrom
fix-mcp-resource-uri-ambiguity
Jul 7, 2026
Merged

Detect ambiguous MCP resource URIs#195
martian56 merged 1 commit into
mainfrom
fix-mcp-resource-uri-ambiguity

Conversation

@martian56

Copy link
Copy Markdown
Owner

Fixes #179.

Summary:

  • Route MCP resource reads through an explicit resource lookup result.
  • Return an ambiguity error when multiple servers expose the same URI and server is omitted.
  • Validate explicit server reads against the advertised resource list.
  • Add tests for unique, missing, duplicate, and explicit-server resource routes.

Checks:

  • rvpm test
  • rvpm build
  • rvpm fmt --check

@martian56 martian56 added bug Something isn't working mcp MCP client tools Agent tools labels Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@martian56, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 41b0046e-5343-4c87-83e0-4f9bc5c34737

📥 Commits

Reviewing files that changed from the base of the PR and between 3dbde2c and 7f0c021.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • rv.toml
  • src/mcp/manager.rv
  • src/mcp/manager_test.rv
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-mcp-resource-uri-ambiguity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martian56 martian56 merged commit e8aab6b into main Jul 7, 2026
4 checks passed
@martian56 martian56 deleted the fix-mcp-resource-uri-ambiguity branch July 7, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working mcp MCP client tools Agent tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect ambiguous MCP resource URIs

1 participant