Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar link and sync #54

Merged
merged 16 commits into from
May 14, 2024
Merged

Calendar link and sync #54

merged 16 commits into from
May 14, 2024

Conversation

markstory
Copy link
Owner

Add the ability for calendars to be synced with the provider. This allows for fewer API calls to google for calendar metadata which gives a snappier UI. Both the HTMX and flutter clients have been updated with a first pass that will be iterated on.

not all sources need to be synced and having unsynced ones can help
build better ui.
- Cleaned up test
- Added api controller tests
- did not change behavior of add yet. This method needs to be
  deprecated and calendar sources are synced from the provider only.
link instead of create. linking is done with then edit API endpoint
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 91.72%. Comparing base (fb58b54) to head (ca2e461).

Files Patch % Lines
src/Controller/Api/CalendarSourcesController.php 73.33% 8 Missing ⚠️
src/Controller/CalendarSourcesController.php 77.77% 4 Missing ⚠️
src/Service/CalendarService.php 92.50% 3 Missing ⚠️
flutterapp/lib/models/calendarsource.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
- Coverage     91.94%   91.72%   -0.23%     
- Complexity      706      715       +9     
============================================
  Files           152      152              
  Lines          7675     7742      +67     
============================================
+ Hits           7057     7101      +44     
- Misses          618      641      +23     
Flag Coverage Δ
flutter 90.56% <95.65%> (-0.29%) ⬇️
phpunit 92.94% <86.48%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markstory markstory merged commit 8351cf8 into master May 14, 2024
7 of 9 checks passed
@markstory markstory deleted the calendar-synced branch May 14, 2024 04:56
Copy link

sentry-io bot commented May 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Cake\Http\Exception\BadRequestException: Could not fetch calendars. /opt/docket-1715662622/src/Service/CalendarServ... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant