Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag var hoisting #2534

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Tag var hoisting #2534

wants to merge 6 commits into from

Conversation

rturnq
Copy link
Contributor

@rturnq rturnq commented Feb 25, 2025

Description

  • Hoist native tag references
  • Hoist custom tag variables
  • Hoist dynamic tag variables

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: cc3cae2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/runtime-tags Patch
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 92.62295% with 54 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (c6a8379) to head (cc3cae2).

Files with missing lines Patch % Lines
packages/runtime-tags/src/html/serializer.ts 85.96% 16 Missing ⚠️
...ime-tags/src/translator/visitors/tag/native-tag.ts 80.00% 14 Missing ⚠️
...kages/runtime-tags/src/translator/util/sections.ts 78.78% 7 Missing ⚠️
packages/runtime-tags/src/dom/control-flow.ts 84.00% 3 Missing and 1 partial ⚠️
packages/runtime-tags/src/html/writer.ts 77.77% 4 Missing ⚠️
...ges/runtime-tags/src/translator/util/references.ts 96.36% 4 Missing ⚠️
...me-tags/src/translator/util/is-invoked-function.ts 86.95% 3 Missing ⚠️
packages/runtime-tags/src/dom/walker.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   86.95%   87.05%   +0.10%     
==========================================
  Files         351      353       +2     
  Lines       40331    40942     +611     
  Branches     2669     2756      +87     
==========================================
+ Hits        35069    35642     +573     
- Misses       5237     5275      +38     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rturnq rturnq force-pushed the tag-var-hoisting branch 3 times, most recently from 37df135 to ce4a89b Compare February 25, 2025 19:20
@rturnq rturnq force-pushed the tag-var-hoisting branch from ce4a89b to 89623a6 Compare March 1, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant