Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating fork with latest from master #1

Merged
merged 41 commits into from
Feb 20, 2014

Conversation

markmalek
Copy link
Owner

No description provided.

Rory Low and others added 30 commits September 11, 2013 16:33
Fix for newlines being outputted in the log even if the message being logged is below the current config.log_level
Fix long-polling backup support
…ler::Callbacks (`before_action`) working properly [fixes #150]
Convert controller's `action_name` to a string to get AbstractController::Callbacks (`before_action`) working properly [fixes #150]
1) Don't use fat arrows, if it's not needed. Please, try to avoid it (see discussions at google.com: "avoid fat arrows in coffescript").

2) Extract common methods and code from Websocket and HttpConnection to AbstractConnection adapter (much cleaner + DRY).

3) Move `.connection_id` from WebSocketRails dispatcher to WebSocketRails.AbstractConnection. `.connection_id` is still also bound to events and channels.

4) Add `.close()` method to AbstractConnection.

5) Add `.connect()`, `.disconnect()` and `.reconnect()` method to WebSocketRails.

6) Refactor some specs.
Refactor *.coffee files. Add reconnect() method.
Rescue Symbolizing of Channel Names
markmalek added a commit that referenced this pull request Feb 20, 2014
Updating fork with latest from master
@markmalek markmalek merged commit 64d6275 into markmalek:master Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants