Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 24, 2025

Functions: removeAll, patch, protect, wipe, advanceLsqt, and improved write as well.

Added "temporal-admin" to the rest-writer test user. Which should allow for the currently-skipped temporal tests to be enabled soon.

Copilot AI review requested due to automatic review settings November 24, 2025 18:47
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Copyright Validation Results
Total: 5 | Passed: 3 | Failed: 0 | Skipped: 2 | at: 2025-11-24 18:56:16 UTC | commit: 765e9be

⏭️ Skipped (Excluded) Files

  • .github/copilot-instructions.md
  • test-app/src/main/ml-config/security/users/rest-writer.json

✅ Valid Files

  • marklogic.d.ts
  • test-typescript/documents-runtime.test.ts
  • typescript-test-project/test.ts

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds TypeScript definitions and runtime tests for additional document functions: removeAll, patch, protect, wipe, and advanceLsqt. It also enhances the write function to support temporal collections and adds the "temporal-admin" role to the rest-writer test user to enable temporal testing.

  • Added TypeScript runtime tests for 5 new document functions with proper type validation
  • Updated rest-writer user configuration to include temporal-admin role
  • Added example temporal document operations to the test project

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
typescript-test-project/test.ts Demonstrates temporal document operations including write, protect, and wipe
test-typescript/documents-runtime.test.ts Adds comprehensive runtime tests for removeAll, patch, protect, wipe, and advanceLsqt functions
test-app/src/main/ml-config/security/users/rest-writer.json Adds temporal-admin role to rest-writer user to enable temporal operations
.github/copilot-instructions.md New file providing guidance for generating TypeScript definitions and runtime tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const writeResult = await client.documents.write({
documents: [
{
uri: temporalUri, content:temporalDoc, collections: ['other'],
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after colon in 'content:temporalDoc'. Should be 'content: temporalDoc' for consistency with the rest of the codebase.

Copilot uses AI. Check for mistakes.
*/

import should = require('should');
const should = require('should');
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed from 'import should = require' to 'const should = require'. This is inconsistent with the TypeScript import pattern used elsewhere in the file for importing types (line 19). Consider using 'import should = require' for consistency, or provide a rationale for this change if intentional.

Suggested change
const should = require('should');
import should = require('should');

Copilot uses AI. Check for mistakes.
Functions: removeAll, patch, protect, wipe, advanceLsqt, createWriteStream, and improved write as well.

Added "temporal-admin" to the rest-writer test user. Which should allow for the currently-skipped temporal tests to be enabled soon.
@rjrudin rjrudin force-pushed the feature/more-documents-ts branch from 3999897 to 765e9be Compare November 24, 2025 18:56
@rjrudin rjrudin merged commit a800b72 into develop Nov 24, 2025
6 checks passed
@rjrudin rjrudin deleted the feature/more-documents-ts branch November 24, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants