MLE-25554 TS for a handful of documents functions #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds TypeScript type checking and runtime validation tests for the MarkLogic documents API, covering probe, read, write, and remove operations.
Key Changes:
- Added comprehensive type checking tests for documents API methods (probe, read, write, remove)
- Added runtime validation tests to verify type definitions match actual behavior
- Updated test compilation script to handle multiple test files
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| typescript-test-project/test.ts | Added example usage of probe() and read() methods to demonstrate documents API |
| test-typescript/documents.test.ts | Added comprehensive type-only tests validating documents API method signatures and return types |
| test-typescript/documents-runtime.test.ts | Added runtime tests to verify type definitions match actual MarkLogic API behavior |
| package.json | Updated test scripts to compile all runtime test files and added test:typescript command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const uris = await resultProvider.result(); | ||
|
|
||
| console.log("THE URIS", uris); |
There was a problem hiding this comment.
Debug console.log statement should be removed before merging. This appears to be leftover debugging code that doesn't provide value in production tests.
Suggested change
| console.log("THE URIS", uris); |
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
rjrudin
force-pushed
the
feature/25554-documents-ts
branch
2 times, most recently
from
7c53fe2 to
bdb5ace
Compare
rjrudin
force-pushed
the
feature/25554-documents-ts
branch
from
bdb5ace to
ac43410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.