-
Notifications
You must be signed in to change notification settings - Fork 15
PDP-536: Adding copyright check #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
PDP-536: Adding copyright check #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds copyright header validation to the GitHub Actions workflow by integrating a reusable workflow from marklogic/pr-workflows and configuring file exclusions for the copyright check.
- Updates workflow name from "🏷️ JIRA ID Validator" to "PR Workflow"
- Adds copyright validation job that uses external workflow for checking copyright headers
- Creates configuration file to exclude build files, docs, and GitHub workflow files from copyright checks
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
.github/workflows/pr-workflow.yaml | Adds copyright validation job and updates workflow name |
.copyrightconfig | Defines copyright start year and file exclusions for validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pr-title: ${{ github.event.pull_request.title }} | ||
copyright-validation: | ||
name: © Validate Copyright Headers | ||
uses: marklogic/pr-workflows/.github/workflows/copyright-check.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using @main for the workflow reference is not recommended for production. Consider pinning to a specific version or commit SHA to ensure reproducibility and avoid potential breaking changes from upstream updates.
Copilot uses AI. Check for mistakes.
# - Dotfiles already skipped automatically | ||
# Enable by removing the leading '# ' from the next line and editing values. | ||
# filesexcluded: third_party/*, docs/generated/*.md, assets/*.png, scripts/temp_*.py, vendor/lib.js | ||
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The exclusion list is quite extensive and on a single line, making it difficult to read and maintain. Consider breaking this into multiple lines or adding comments explaining why each pattern is excluded.
filesexcluded: .github/*, README.md, Jenkinsfile, gradle/*, docker-compose.yml, *.gradle, gradle.properties, gradlew, gradlew.bat | |
filesexcluded: \ |
Copilot uses AI. Check for mistakes.
No description provided.