Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Sep 30, 2025

Trying to get as many okhttp3 imports into one package as possible, with the notable exception for now of OkHttpServices.

Trying to get as many okhttp3 imports into one package as possible, with the notable exception for now of OkHttpServices.
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 13:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors OkHttp-specific classes to consolidate them into a dedicated package. The PR moves authentication interceptor classes from the generic impl package to the more specific okhttp package to improve code organization and reduce scattered okhttp3 imports.

  • Moved HTTPKerberosAuthInterceptor and HTTPSamlAuthInterceptor to okhttp package
  • Updated imports in OkHttpUtil to reflect the package restructuring
  • Removed unused import in FailedRequest class

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
OkHttpUtil.java Removed imports for moved interceptor classes and unused Objects import
HTTPSamlAuthInterceptor.java Moved to okhttp package and added RESTServices import
HTTPKerberosAuthInterceptor.java Moved to okhttp package and added SSLUtil import
FailedRequest.java Removed unused MediaType import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjrudin rjrudin merged commit cc05b57 into develop Sep 30, 2025
1 of 2 checks passed
@rjrudin rjrudin deleted the feature/organize-okhttp-dependencies branch September 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant