Skip to content

Configatron::Proc#call returns @val only when val is nil #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-miyamoto-jp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Configatron::Proc#call returns @val only when val is nil #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/configatron/proc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def call
@val = val
end
end
return val || @val
return val.nil? ? @val : val
end

def finalize?
Expand Down
6 changes: 6 additions & 0 deletions test/unit/configatron/proc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,11 @@ class Critic::Unit::ProcTest < Critic::Unit::Test
@proc.stubs(:finalize?).returns(false)
refute_equal(@proc.call, @proc.call)
end

it 'sets and returns false in Dynamic' do
stubs(:rand).returns(false)
@proc.stubs(:finalize?).returns(false)
assert_equal(false, @proc.call)
end
end
end