Dependabot fixes #27
Merged
Dependabot fixes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* axios: used by @solana/spl-governance, the SDK is not updated for long time an there will be a new IDL based sdk that requires full refactoring, forcing a new version of the affected library * @babel/traverse: used by jest/globals that is not updated for around a year, not sure about other way then force pnpm version * crowss-spawn: eslint not possible to change because of gts issues of new linter (google/gts#830) * ws: is used everywhere so hard say, fixed to what dependabot says * braces, micromatch: those are used by jest (cannot update as not existing new version) * semver: not sure, many versions in dependency
ochaloup
force-pushed
the
dependabot-fixes
branch
from
1df3e59 to
dd90dbe
Compare
|
(fixed merge issues because of wrong base branch I took on my local computer) |
martinkrecek
approved these changes
Jan 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My task is to lower the number of security alerts on repositories I work with.
For many of these dependable issues is trouble that we (I) cannot update the dependency directly as
a) There is currently no new version - e.g., gts is stuck at version without the support of new eslint/prettier, jest test works for last ~2 years on a new version
30.xbut until released (with all backward incompatibilities) there is still two years old version 29.7.0 without updates.b) We cannot update the version due to the backward incompatibility (e.g. solana/web3.js 1.x vs 2.x)
My consideration is to fix it by forcing the (mostly) minor updates in the pnpm lock file - on those dependencies that dependabot requires.
I will be happy to hear opinion on this way of fixing the thingy.