Skip to content

fix!: retire arbitrary Native SQL execution - #18

Merged
marianfoo merged 5 commits into
masterfrom
codex/fix-base-sec-002
Aug 6, 2026
Merged

marianfoo merged 5 commits into
masterfrom
codex/fix-base-sec-002

Conversation

@marianfoo

@marianfoo marianfoo commented Aug 6, 2026 •

Copy link
Copy Markdown
Owner

Goal

Close BASE-SEC-002 by removing the externally controlled Native SQL execution boundary and unsupported C_DB_EXECUTE kernel call.

Changes

  • add a permanent repository contract forbidding the kernel sink
  • add red/green ABAP Unit coverage for default rejection and legacy-flag bypass
  • reject NATIVE unconditionally and remove its dispatcher/executor
  • preserve SELECT, INSERT, UPDATE, and DELETE behavior
  • update user, security, test, research, and finding documentation

Validation

  • npm ci: 0 vulnerabilities
  • npm test: green, 0 configured abaplint findings
  • diagnostic abaplint: 1,841 findings, down from 1,878
  • A4H syntax: 0 errors, 3 known POSIX warnings; unsupported-call warning removed
  • A4H ABAP Unit: 20/20 green
  • A4H ATC ABAP Cloud readiness: 759 findings, down from 768
  • A4H fresh transaction start: editor rendered, no SQL executed, no ST22 delta; missing STATUS010 remains BASE-BUG-007
  • NPL ADT-only: exact gate prerequisite-blocked because PROG/TABL ZTOAD are absent

Security and compatibility

This intentionally removes the legacy Native SQL capability. Replacing the unsupported call with ADBC would retain the arbitrary-statement injection boundary, so the command now fails closed. The source remains compatible with the SAP_BASIS 750 syntax floor.

Release impact

This must produce a major-version signal in Release Please because existing installations that enabled the NATIVE command lose that capability.

BREAKING CHANGE: The NATIVE command and its arbitrary Native SQL execution path are no longer supported.

@marianfoo
marianfoo marked this pull request as ready for review August 6, 2026 12:51
@marianfoo marianfoo changed the title fix: retire arbitrary Native SQL execution fix!: retire arbitrary Native SQL execution Aug 6, 2026
@marianfoo marianfoo mentioned this pull request Aug 6, 2026
13 tasks done
@marianfoo
marianfoo merged commit dc065dd into master Aug 6, 2026
3 checks passed
@marianfoo
marianfoo deleted the codex/fix-base-sec-002 branch August 6, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant