Repository navigation
fix: generate strict select clauses in valid order - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fix issue #6 by emitting strict ABAP SQL table targets after the data-source clauses while preserving the compatible legacy and scalar COUNT paths.
Content
Fixes #6
Verification
npm ciandnpm test: green; abaplint 2.120.18 reports 0 configured issuesnpm run lint:quality: diagnostic succeeds and reports 1,857 findings across 57 default rulesgit diff --check: greenS4HANA_READINESS_2023: incomplete because 7 prerequisite checks are unavailable; no clean pass claimedABAP_CLOUD_READINESS: 767 findings; 2 P2 FORM warnings are test-only calls into the legacy boundary, production delta 0Final review and process audit
The initial Quality run and both post-audit reruns passed the required ABAP 7.50 job and hosted abaplint check. The audit corrected branch/live-deployment guidance, ATC completeness reporting, fixture checks, Node CI documentation, plan/research placement, and final-review/repeated-CI requirements. No CI workflow was weakened or changed. The full 1,857-finding profile remains diagnostic until it reaches zero.
Release Please PR #10 was also audited: its approval-required repository Quality run was manually approved and passed, and GitHub now reports that PR as cleanly mergeable. Unattended Release Please CI remains an explicit GitHub App/fine-grained-token decision.
The implementation changes only the strict multi-row generation branch. Serializer XML, authorization behavior, parser behavior, scalar COUNT generation, and legacy generation are unchanged.