Skip to content

fix: generate strict select clauses in valid order - #15

Merged
marianfoo merged 4 commits into
masterfrom
codex/fix-base-bug-001
Aug 6, 2026
Merged

marianfoo merged 4 commits into
masterfrom
codex/fix-base-bug-001

Conversation

@marianfoo

@marianfoo marianfoo commented Aug 6, 2026 •

Copy link
Copy Markdown
Owner

Goal

Fix issue #6 by emitting strict ABAP SQL table targets after the data-source clauses while preserving the compatible legacy and scalar COUNT paths.

Content

  • add the failing aggregate generator regression and two compatibility tests
  • apply the smallest strict-versus-legacy clause-order correction
  • record the reviewed plan, red replay, live verification, and remaining gates
  • codify the reviewed TDD/PR/live-system workflow and completed-plan structure
  • add research on test packaging, ABAP 7.02/downport options, and the abaplint debt
  • add a reproducible non-blocking full abaplint inventory command

Fixes #6

Verification

  • npm ci and npm test: green; abaplint 2.120.18 reports 0 configured issues
  • npm run lint:quality: diagnostic succeeds and reports 1,857 findings across 57 default rules
  • strict full-quality mode: intentionally fails until the backlog reaches zero
  • git diff --check: green
  • A4H SAP_BASIS 758: active syntax 0 errors with 4 unchanged warnings
  • A4H ABAP Unit: 4 classes, 17 methods, all green
  • S4HANA_READINESS_2023: incomplete because 7 prerequisite checks are unavailable; no clean pass claimed
  • ABAP_CLOUD_READINESS: 767 findings; 2 P2 FORM warnings are test-only calls into the legacy boundary, production delta 0
  • browser acceptance: failed by BASE-RUN-001; direct transaction also awaits BASE-BUG-006
  • live SAP_BASIS 750: pending BASE-ENV-001

Final review and process audit

The initial Quality run and both post-audit reruns passed the required ABAP 7.50 job and hosted abaplint check. The audit corrected branch/live-deployment guidance, ATC completeness reporting, fixture checks, Node CI documentation, plan/research placement, and final-review/repeated-CI requirements. No CI workflow was weakened or changed. The full 1,857-finding profile remains diagnostic until it reaches zero.

Release Please PR #10 was also audited: its approval-required repository Quality run was manually approved and passed, and GitHub now reports that PR as cleanly mergeable. Unattended Release Please CI remains an explicit GitHub App/fine-grained-token decision.

The implementation changes only the strict multi-row generation branch. Serializer XML, authorization behavior, parser behavior, scalar COUNT generation, and legacy generation are unchanged.

@marianfoo
marianfoo merged commit 5ca4cc9 into master Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: "The INTO/APPENDING clause must be at the end of the SELECT..."

1 participant