Correctly get DROP_SHADOW spread value #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcomontalbano Any chance to merge and deploy this change? |
marcomontalbano
added
the
PR: Bug Fix 🐛
marcomontalbano
previously approved these changes
Feb 28, 2025
marcomontalbano
approved these changes
Feb 28, 2025
|
Hi @salmoro, I'm sorry for the delay, and thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was a discrepancy with drop-shadows from figma-export compared to how they're shown in Figma's dev mode.
The Figma types used in this project from
figma-jsseem to be outdated. Figma's API returns the "spread" value in the effect when it's of type "DROP_SHADOW".You can see it in the API reference when searching for the word "spread" on https://www.figma.com/developers/api.