Fix SSL certificate loading to gracefully fall back to HTTP#2
Open
railway-app[bot] wants to merge 1 commit into
Open
Fix SSL certificate loading to gracefully fall back to HTTP#2railway-app[bot] wants to merge 1 commit into
railway-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
SSL_CONF_PRIVKEYorSSL_CONF_FULLCHAINare empty strings, thehttpsgetter insrc/utils/server-up.tspasses them directly tofs.readFileSync(), which fails and causes the server to crash on startup with "Cannot read properties of undefined (reading 'listen')".Solution
Added a guard in the
httpsgetter that returnsnullif eitherFULLCHAINorPRIVKEYis falsy. The caller inmain.tsalready has aserver === nullcheck that logs a warning and falls back to HTTP, so no changes were needed there.Changes
src/utils/server-up.tsGenerated by Railway