Skip to content

Use 2*del_ph in layers 1 cm thick or thinner #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnlevy1981 merged 1 commit into from
Aug 7, 2025
Merged

Use 2*del_ph in layers 1 cm thick or thinner #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/marbl_interior_tendency_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,8 +1072,14 @@ subroutine compute_carbonate_chemistry(domain, temperature, press_bar, &

do k=1,dkm
if (ph_prev_col(k) /= c0) then
ph_lower_bound(k) = ph_prev_col(k) - del_ph
ph_upper_bound(k) = ph_prev_col(k) + del_ph
if (domain%delta_z(k) > 1._r8 * unit_system%cm2len) then
ph_lower_bound(k) = ph_prev_col(k) - del_ph
ph_upper_bound(k) = ph_prev_col(k) + del_ph
else
! Double initial bracket width for very thin layers
ph_lower_bound(k) = ph_prev_col(k) - 2._r8 * del_ph
ph_upper_bound(k) = ph_prev_col(k) + 2._r8 * del_ph
end if
else
ph_lower_bound(k) = phlo_3d_init
ph_upper_bound(k) = phhi_3d_init
Expand All @@ -1097,8 +1103,14 @@ subroutine compute_carbonate_chemistry(domain, temperature, press_bar, &
do k=1,dkm
ph_prev_col(k) = pH(k)
if (ph_prev_alt_co2_col(k) /= c0) then
ph_lower_bound(k) = ph_prev_alt_co2_col(k) - del_ph
ph_upper_bound(k) = ph_prev_alt_co2_col(k) + del_ph
if (domain%delta_z(k) > 1._r8 * unit_system%cm2len) then
ph_lower_bound(k) = ph_prev_col(k) - del_ph
ph_upper_bound(k) = ph_prev_col(k) + del_ph
else
! Double initial bracket width for very thin layers
ph_lower_bound(k) = ph_prev_col(k) - 2._r8 * del_ph
ph_upper_bound(k) = ph_prev_col(k) + 2._r8 * del_ph
end if
else
ph_lower_bound(k) = phlo_3d_init
ph_upper_bound(k) = phhi_3d_init
Expand Down