Add nonlinear loss to diags#479
Draft
mnlevy1981 wants to merge 5 commits into
Draft
Conversation
Added new diagnostics for linear and nonlinear terms in both 3D fields and 150m integrals.
zoo_loss_linear is now the linear contribution rather than the nonlinear (and zoo_loss_nonlinear is the nonlinear contribution instead of the linear)
Previous commits included integrals over the top 150m of zoo_loss_linear and _nonlinear; this commit adds integrals over the top 100m
Don't need parentheses in "a = (b+c)", and in "a = (b*c)*d" the impact is round-off level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpetrik has asked us to provide the nonlinear
zoo_lossterm integrated over the top 150m of the ocean to use as a forcing field in FEISTY, rather than trying to estimate it based on the integral of totalzoo_loss. In this PR, I break up thezoo_losscomputation intozoo_loss_linearandzoo_loss_nonlinear(which will introduce round-off level changes because each of those terms is multiplied byTfuncand thenzoo_lossis the sum of the two, whereas beforezoo_losswas the sum of the two withoutTfuncand then the sum itself was multipled), and also introduce four new per-zoo diagnostics:zoo_losszoo_lossover the top 150 meterszoo_losszoo_lossover the top 150 metersBy default, the 150m integral of the nonlinear term is in the
highfrequency output, but neither the integral of the linear term nor either of the 3D fields are written out.This branch is from a CESM 2.2.2 run, so it's pretty out of date. I'll merge in the latest
developmentand resolve conflicts, and I'll probably also add the 100m vertical integrals for completeness since we havezoo_loss_zint_100mdefined; it's omitted in the initial commits because we don't need them for the 0.1° run we are doing.