Skip to content

Fix: Preserve model device in model_summary method #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwood-97 merged 4 commits into from
Jan 5, 2026
Merged

Fix: Preserve model device in model_summary method #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03847df
Update classifier.py
GiuseTripodi Dec 17, 2025
09cfbe9
Modified CHANGELOG.md file by adding fixes #574
GiuseTripodi Dec 19, 2025
48902d9
Update CHANGELOG.md
GiuseTripodi Dec 23, 2025
74ee3cf
Update CHANGELOG.md
GiuseTripodi Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ The following table shows which versions of MapReader are compatible with which
## Pre-release
_Add new changes here_
Copy link
Collaborator

@rwood-97 rwood-97 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-add the _Add new changes here_ line so future contributors can still see where to add in the changelog

Copy link
Contributor Author

@GiuseTripodi GiuseTripodi Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done it.


### Fixed

- Fixes the `model_summary` method in the `ClassifierContainer` class ([#574](https://github.com/maps-as-data/MapReader/pull/574))

## [v1.8.2](https://github.com/Living-with-machines/MapReader/releases/tag/v1.8.2) (2025-12-19)

### Added
Expand Down
2 changes: 1 addition & 1 deletion mapreader/classify/classifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ def model_summary(
col_names = ["output_size", "output_size", "num_params"]

model_summary = summary(
self.model, input_size=input_size, col_names=col_names, **kwargs
self.model, input_size=input_size, col_names=col_names, device=self.device, **kwargs
)
print(model_summary)

Expand Down
Loading