Skip to content

Conversation

@rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Jul 18, 2025

Summary

Since we are currently using piffle from my dev branch, we can't add it as a dependency.
So instead, for now, I've added that we explicitly install it in our CI and now our tests should hopefully work.

I can then push a version update to pypi.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 79.30% <100.00%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/test_download/test_iiif_downloader.py 92.17% <100.00%> (ø)
tests/test_import.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rwood-97 rwood-97 merged commit fb42059 into main Jul 28, 2025
9 checks passed
@rwood-97 rwood-97 deleted the update_ci_cd branch July 28, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants