Skip to content

Conversation

@rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Nov 18, 2024

Summary

Updates the default for add_id argument in the plot methods in SheetDownloader.
This means if you don't have WFS ids in your metadata you won't get an error.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs
  • Update changelog

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 77.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/download/sheet_downloader.py 83.38% <ø> (ø)

@rwood-97 rwood-97 merged commit 05f7690 into main Nov 18, 2024
@rwood-97 rwood-97 deleted the fix_add_id_download branch November 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants