Conversation
This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.
|
Thanks @rays22 - My initial comments:
|
|
@matentzn would welcome your feedback too |
@jamesamcl , I will investigate this:
|
|
This commit intends to 1. update some of the mappings, and 2. add new MeSH Concept term mappings.
| license: https://creativecommons.org/publicdomain/zero/1.0/ | ||
| mapping_provider: https://www.ebi.ac.uk | ||
| mapping_set_group: obo_mesh_mappings | ||
| mapping_set_id: obo_mesh |
|
FYI we already did a lot of mesh to OBO mappings in Biomappings (https://github.com/biopragmatics/biomappings) - it would be a shame not to reuse those |
Agreed! Should we mirror them here as SSSOM? |
|
Why mirror them? They have a PURL (https://w3id.org/biopragmatics/biomappings/sssom/biomappings.sssom.tsv) for anyone who wants to use them. I think it's a bit misguided to use GitHub as a place for mirroring data (is that what's going on with all of the repos in this org? I disagree with this) |
| #subject_source: http://purl.obolibrary.org/obo/oba.owl | ||
| subject_id subject_label predicate_id object_id object_label mapping_justification subject_source object_source confidence mapping_date author_id object_uri | ||
| CL:0000017 spermatocyte skos:exactMatch M0020280 Spermatocytes semapv:ManualMappingCuration CL MeSH 1 2025-03-26 orcid:0000-0001-8314-2140 http://id.nlm.nih.gov/mesh/M0020280 | ||
| CL:0000018 spermatid skos:exactMatch M0020276 Spermatids semapv:ManualMappingCuration CL MeSH 1 2025-03-26 orcid:0000-0001-8314-2140 http://id.nlm.nih.gov/mesh/M0020276 |
There was a problem hiding this comment.
the mapping_date seems fake, these likely weren't all manually mapped on this date.
There was a problem hiding this comment.
Yes, my friend, these were all manually mapped on 2025-03-26.
There was a problem hiding this comment.
wow! I am more than impressed. do you have a time estimate on how long this took?
There was a problem hiding this comment.
@cthoyt ,
Thank you for your appreciation of my work.
Here is my curation process:
- I collected the textual definitions of the targeted list of MeSH Concepts, e.g. https://id.nlm.nih.gov/mesh/M0001044.html
- I created several draft iterations of the term mappings using OLS and the MeSH Concept labels together with their definitions.
- I double-checked and finalised the mappings for a set of 1,086 terms on 2025-03-26, believed to be correct at that time.
Step 2 took several days to weeks. Nevertheless, the final version of the manual mappings was created on 2025-03-26 (hence the value of mapping_date = 2025-03-26).
This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.