Skip to content

Add first version of first set of MeSH mappings#1

Open
rays22 wants to merge 5 commits intomainfrom
first
Open

Add first version of first set of MeSH mappings#1
rays22 wants to merge 5 commits intomainfrom
first

Conversation

@rays22
Copy link
Copy Markdown
Collaborator

@rays22 rays22 commented Mar 26, 2025

This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.

This PR intends to add the first set of OBO Ontology (CL, UBERON, GO, OBA) term mappings to a set of MeSH terms.
@rays22 rays22 self-assigned this Mar 26, 2025
@rays22 rays22 requested a review from jamesamcl March 26, 2025 17:41
@jamesamcl
Copy link
Copy Markdown
Member

jamesamcl commented Mar 27, 2025

Thanks @rays22 -

My initial comments:

  • We should be using skos:exactMatch as with other sssom mapping sets rather than owl:equivalentClass
  • Labels are missing from the tsv which makes this difficult to check
  • Yaml header is missing from the tsv
  • Other metadata also missing; e.g. were these all manual curation?
  • Related to above, where do the confidence scores come from?

@jamesamcl
Copy link
Copy Markdown
Member

@matentzn would welcome your feedback too

@rays22
Copy link
Copy Markdown
Collaborator Author

rays22 commented Mar 27, 2025

  • We should be using skos:exactMatch as with other sssom mapping sets rather than owl:equivalentClass
  • Labels are missing from the tsv which makes this difficult to check
  • Other metadata also missing; e.g. were these all manual curation?
  • Related to above, where do the confidence scores come from?

@jamesamcl ,
The mp_hp_example* files that use owl:equivalentClass had been automatically created by the mapping-commons github template when I created the repo. I will remove them.

I will investigate this:

  • Yaml header is missing from the tsv

@rays22
Copy link
Copy Markdown
Collaborator Author

rays22 commented Apr 2, 2025

rays22 added 3 commits April 7, 2025 15:59
This commit intends to
1. update some of the mappings, and
2. add new MeSH Concept term mappings.
license: https://creativecommons.org/publicdomain/zero/1.0/
mapping_provider: https://www.ebi.ac.uk
mapping_set_group: obo_mesh_mappings
mapping_set_id: obo_mesh
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2

@cthoyt
Copy link
Copy Markdown
Member

cthoyt commented Sep 9, 2025

FYI we already did a lot of mesh to OBO mappings in Biomappings (https://github.com/biopragmatics/biomappings) - it would be a shame not to reuse those

@jamesamcl
Copy link
Copy Markdown
Member

FYI we already did a lot of mesh to OBO mappings in Biomappings (https://github.com/biopragmatics/biomappings) - it would be a shame not to reuse those

Agreed! Should we mirror them here as SSSOM?

@cthoyt
Copy link
Copy Markdown
Member

cthoyt commented Sep 9, 2025

Why mirror them? They have a PURL (https://w3id.org/biopragmatics/biomappings/sssom/biomappings.sssom.tsv) for anyone who wants to use them. I think it's a bit misguided to use GitHub as a place for mirroring data (is that what's going on with all of the repos in this org? I disagree with this)

#subject_source: http://purl.obolibrary.org/obo/oba.owl
subject_id subject_label predicate_id object_id object_label mapping_justification subject_source object_source confidence mapping_date author_id object_uri
CL:0000017 spermatocyte skos:exactMatch M0020280 Spermatocytes semapv:ManualMappingCuration CL MeSH 1 2025-03-26 orcid:0000-0001-8314-2140 http://id.nlm.nih.gov/mesh/M0020280
CL:0000018 spermatid skos:exactMatch M0020276 Spermatids semapv:ManualMappingCuration CL MeSH 1 2025-03-26 orcid:0000-0001-8314-2140 http://id.nlm.nih.gov/mesh/M0020276
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mapping_date seems fake, these likely weren't all manually mapped on this date.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my friend, these were all manually mapped on 2025-03-26.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! I am more than impressed. do you have a time estimate on how long this took?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cthoyt ,

Thank you for your appreciation of my work.

Here is my curation process:

  1. I collected the textual definitions of the targeted list of MeSH Concepts, e.g. https://id.nlm.nih.gov/mesh/M0001044.html
  2. I created several draft iterations of the term mappings using OLS and the MeSH Concept labels together with their definitions.
  3. I double-checked and finalised the mappings for a set of 1,086 terms on 2025-03-26, believed to be correct at that time.

Step 2 took several days to weeks. Nevertheless, the final version of the manual mappings was created on 2025-03-26 (hence the value of mapping_date = 2025-03-26).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants