Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terrain fog on globe #4924

Closed

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Oct 29, 2024

Closes #4985

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (30ab703) to head (0c208b3).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4924      +/-   ##
==========================================
- Coverage   91.81%   90.85%   -0.96%     
==========================================
  Files         279      279              
  Lines       38340    38335       -5     
  Branches     6698     6697       -1     
==========================================
- Hits        35200    34830     -370     
- Misses       3007     3341     +334     
- Partials      133      164      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibesora ibesora force-pushed the ib/fix-terrain-fog-on-globe-final branch from 01d2941 to 0c208b3 Compare November 25, 2024 10:16
@ibesora
Copy link
Collaborator Author

ibesora commented Dec 10, 2024

Closing this. Will reopen when I get more work done on it

@ibesora ibesora closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Fog in Vertical Perspective with Terrain
3 participants