Skip to content

feat: Release V400 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xfarhaan merged 9 commits into from
Mar 20, 2025
Merged

feat: Release V400 #6

0xfarhaan merged 9 commits into from
Mar 20, 2025

Conversation

@0xfarhaan
Copy link
Member

@0xfarhaan 0xfarhaan commented Mar 20, 2025

No description provided.

0xfarhaan and others added 6 commits January 2, 2024 16:01
@0xfarhaan
refactor: Make view function (#294)
0207913
@JGcarv
feat: Open compiler version (SC-18174) PART I (#296)
b875e4e 
* feat: open compiler version

* chore: formatting and removing mockPoolManager
@JGcarv
chore: Rename storage and functions to strategy (SC-18174) PART II (#…
5cd5fea 
…297)

* chore: rename storage and functions to strategy

* fix: update comment

* fix: formatting on pool deployer
@JGcarv
feat: Switch from loan managers to strategies (SC-18174) PART III (#298)
a6cc55d 
* feat: switch from lms to strategies

* fix: formatting on test file

* fix: add via-ir to production profiel

* fix: stack too deep error

* fix: formatting and var name

* feat: change access control

* fix: update toml
@JGcarv @0xfarhaan
feat: Breakdown view functions on pool deployer (SC-18425) (#299)
fdad2d6 
* feat: breakdown view functions on pool deployer

* fix: formatting

* chore: formatting

* chore: formatting

---------

Co-authored-by: 0xfarhaan <[email protected]>
@JGcarv @0xfarhaan
feat: Require passing poolManager as the first argument for strateg…
5c31049 
…ie factories (SC-18438) (#300)

* feat: breakdown view functions on pool deployer

* fix: formatting

* feat: addStrategy requires first argument for factory to be the poolManager)

* chore: formatting

* chore: formatting

* chore: Add NOTE to natspec

* chore: Add NOTE to natspec

---------

Co-authored-by: 0xfarhaan <[email protected]>
@0xfarhaan 0xfarhaan self-assigned this Mar 20, 2025
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

LCOV of commit 3978d85 during Forge Tests (PR) #18

Summary coverage rate:
  lines......: 88.5% (402 of 454 lines)
  functions..: 79.8% (91 of 114 functions)
  branches...: no data found

Files changed coverage rate:
                                                 |Lines       |Functions  |Branches    
  Filename                                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================================
  contracts/MaplePool.sol                        |33.7%    101| 0.0%    27|    -      0
  contracts/MaplePoolDelegateCover.sol           |33.3%      6| 0.0%     2|    -      0
  contracts/MaplePoolDeployer.sol                |16.2%     68| 0.0%    11|    -      0
  contracts/MaplePoolManager.sol                 |30.5%    200| 0.0%    47|    -      0
  contracts/proxy/MaplePoolManagerFactory.sol    |33.3%      3| 0.0%     1|    -      0
  contracts/proxy/MaplePoolManagerInitializer.sol|22.2%     18| 0.0%     2|    -      0
  contracts/proxy/MaplePoolManagerMigrator.sol   |16.7%      6| 0.0%     1|    -      0

⛔ The code coverage is too low: 88.55. Expected at least 90.

@0xfarhaan 0xfarhaan merged commit 495c4a0 into main Mar 20, 2025
@0xfarhaan 0xfarhaan deleted the feat/release-v400 branch March 20, 2025 13:33
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

LCOV of commit e90d77f during Forge Tests (PR) #19

Summary coverage rate:
  lines......: 88.5% (402 of 454 lines)
  functions..: 79.8% (91 of 114 functions)
  branches...: no data found

Files changed coverage rate:
                                                 |Lines       |Functions  |Branches    
  Filename                                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================================
  contracts/MaplePool.sol                        |33.7%    101| 0.0%    27|    -      0
  contracts/MaplePoolDelegateCover.sol           |33.3%      6| 0.0%     2|    -      0
  contracts/MaplePoolDeployer.sol                |16.2%     68| 0.0%    11|    -      0
  contracts/MaplePoolManager.sol                 |30.5%    200| 0.0%    47|    -      0
  contracts/proxy/MaplePoolManagerFactory.sol    |33.3%      3| 0.0%     1|    -      0
  contracts/proxy/MaplePoolManagerInitializer.sol|22.2%     18| 0.0%     2|    -      0
  contracts/proxy/MaplePoolManagerMigrator.sol   |16.7%      6| 0.0%     1|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@0xfarhaan 0xfarhaan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xfarhaan @JGcarv