-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added composition mode to layer #4140
base: master
Are you sure you want to change the base?
Conversation
TODO: * Consider what should happen when set on group layers
Need to make sure the other modes are useful at all first.
c60fbae
to
a142386
Compare
Now the layer blend mode defaults to "Inherit", which means that when set on a group layer, the blend mode now applies to its children.
Draft of docs, to add to https://github.com/mapeditor/tiled/blob/master/docs/manual/layers.rst after the Tinting Layers section.
It would be nice to include a figure that demonstrates blending modes, perhaps a demo with 3 layers where all are Normal, compared to where the bottom layer is Normal and the other two are Screen and Multiply or something. I don't have any art handy for that, and stock art designed for blending modes is uncommon. I was a little tempted to include a paragraph with some usage examples, but figured the docs aren't the place. But just in case you do want it, here:
It would also be nice to specify exactly which elements are affected by this. I can guess how it works for Tile and Image Layers, but what about non-Tile Objects in Object Layers? |
It does not seem to add too much benefit at the moment and it might conflict with future changes to how blend modes set on group layers are handled (which could be expected to be composited from their child layers before being blended, as is the case for groups in SVG).
Layer blend mode no longer affects shape objects.
Thanks to @eishiya for their help with this!
Also renamed "Plus" to "Add" since it should be more recognizable.
84e484e
to
a084eef
Compare
* Corrected spelling in JS API docs * Updated TMX and JSON format docs * Small code cleanups
TODO:
Closes #3932