Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressed .png textures with https://compresspng.com/ #1267

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Compressed .png textures with https://compresspng.com/ #1267

merged 1 commit into from
Jan 29, 2019

Conversation

greglemonmapbox
Copy link
Contributor

Related issue

Example: Closes #832. Relates to #832.

Description of changes

Compressed relevant .png files with https://compresspng.com/

SDK package export size (no tests or devtools):

  • Uncompressed png's : 75.8mb
  • Compressed png's : 55mb

QA checklists

  • Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • Add tests for new/changed/updated classes and methods!!!
  • Check out conventions in CONTRIBUTING.md.
  • Check out conventions in CODING-STYLE.md
  • Update the changelog
  • Update documentation.

Reviewers

Tag your reviewer(s). Choose wisely.

brnkhy
brnkhy approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@brnkhy brnkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greglemonmapbox greglemonmapbox merged commit 44b2462 into release/v2.0.1 Jan 29, 2019
@greglemonmapbox greglemonmapbox deleted the texture-png-crush branch January 29, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brnkhy brnkhy brnkhy approved these changes

@abhishektrip abhishektrip Awaiting requested review from abhishektrip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greglemonmapbox @brnkhy