-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIgrate nav docs script over ios-sdk repo #2668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I think we should also name the script something more descriptive, like publish-documentation.sh.
The CircleCI build failures are due to Homebrew unreliability that #2667 will work around by downloading Carthage directly from GitHub. |
scripts/update-navigation.sh
Outdated
|
||
step "Moving new docs folder to ./$VERSION" | ||
rm -rf "./$VERSION" | ||
mkdir -p "./navigation/api/$VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct path? As I can see later in this script we attempt to add contents from ./$VERSION
, here on the other hand we create ./navigation/api/$VERSION
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, @MaximAlien. You are correct and I've updated this value.
Thank you @1ec5 and @MaximAlien for your comments. I've made some updates to address the issues you've pointed out. I tested locally and all seemed to work. I would appreciate another tester if anyone has some spare cycles. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Stale. |
Related: mapbox/mapbox-directions-swift#467
This PR will move the shell script for generating documentation from /ios-sdk into this repo. The script will generate the documentation, switch and commit the new version on the publisher-production branch.
To do:
cc @katydecorah and @1ec5
Ref mapbox/ios-sdk#980