-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Objective-C compatibility; adopt Swift language features #2230
Conversation
571ebde
to
596fe6f
Compare
Some lessons learned so far: There are a few unanticipated complications that may impact our refactoring objectives. Namely:
|
New errors have cropped up, but these are all moot because they stem from OBJ-C code, which will be removed. (the OBJ-C example code no longer recognizes anything from the SDK)
XCTAssertTrue(dependencies.navigationService.eventsManager.usesDefaultUserInterface, "MapboxCoreNavigationTests should have an implicit dependency on MapboxNavigation due to running inside the Example application target.") | ||
} | ||
// func testDefaultUserInterfaceUsage() { | ||
// XCTAssertTrue(dependencies.navigationService.eventsManager.usesDefaultUserInterface, "MapboxCoreNavigationTests should have an implicit dependency on MapboxNavigation due to running inside the Example application target.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be restored and fixed.
…ere are some issues with some other tests.
I got a crash arriving at the final destination:
The error is:
Please audit the storyboards for any Objective-C class names. |
Serious crashes due to stale references in storyboards.
Taking Minh's PR Suggestions Co-Authored-By: Minh Nguyễn <[email protected]>
Co-Authored-By: Minh Nguyễn <[email protected]>
# Conflicts: # CHANGELOG.md
Work in progress.
Running Checklist:
@objc
attributes andMB
class prefixesCMapboxDirections
target from SPM distribution ofMapboxDirections.swift
Replace magic default values with optionalsFixes #2231.