SGEO-2914: Sanitize HTML output for place_name #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ir-map
reviewed
Aug 27, 2025
| @@ -93,6 +93,16 @@ function MapboxGeocoder(options) { | |||
| this.geolocation = new Geolocation(); | |||
| } | |||
|
|
|||
| function escapeHtml(str) { | |||
| if (!str) return ''; | |||
| return String(str) | |||
There was a problem hiding this comment.
I don't think so. Without the preceding <, the slash is a harmless character.
underoot
approved these changes
Aug 28, 2025
Merged
|
Fix was published https://github.com/mapbox/mapbox-gl-geocoder/releases/tag/v5.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes XSS when rendering
place_name.https://mapbox.atlassian.net/browse/SGEO-2914
Note that bumping the version number for package and CHANGELOG are deferred to another PR, according to these deployment instructions.
npm run docsand commit changes to API.md (no changes)mainheading before merging