Feature/fix refs usage #7487
Open
Feature/fix refs usage #7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had to use state because of weird ref + nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #7406
In short, I changed most of hook relying on refs to use the ref callback instead.
this fixes issues described thoroughly at #7406 , such as hooks not working when the ref is changed.
Strictly speaking, this is a breaking change because it changes the return value of the hooks to RefCallback instead of RefObject.
Also this is my first time contributint to open source so I may have missed steps (?)
(I'm not sure if I'm suppposed to bump the version or not etc.)