Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in validation of PolarizerEfficiency algorithm #38492

Conversation

rbauststfc
Copy link
Contributor

@rbauststfc rbauststfc commented Dec 10, 2024

Description of work

Summary of work

Fixes a bug in the validation of algorithm PolarizerEfficiency that could result in a crash. See linked issue for further details.

Fixes #38483.

To test:

See instructions on linked issue.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

When the number of spin states does not match the number of workspaces
in the input group we must return early to avoid trying to look up a workspace that doesn't exist.
@rbauststfc rbauststfc added SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Dec 10, 2024
@rbauststfc rbauststfc added this to the Release 6.12 milestone Dec 10, 2024
@rbauststfc rbauststfc marked this pull request as ready for review December 10, 2024 16:31
@yusufjimoh yusufjimoh self-assigned this Dec 19, 2024
Copy link
Contributor

@yusufjimoh yusufjimoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the validation bug fix. I’ve tested the changes thoroughly on both the GUI and through scripting, and everything seems to be functioning as expected. The unit tests passed successfully, and a release note is added. I’m happy to approve the pull request.

@cailafinn cailafinn self-assigned this Dec 19, 2024
@cailafinn cailafinn merged commit 2dbc3f5 into mantidproject:main Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PolarizerEfficiency algorithm validation crash
3 participants