-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some HeliumAnalyserEfficiency algorithm parameters #38334
Rename some HeliumAnalyserEfficiency algorithm parameters #38334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this so far. Great spot on the release note that needed moving from a previous PR. I had a few comments, but this is coming along well.
Framework/Algorithms/src/PolarizationCorrections/HeliumAnalyserEfficiency.cpp
Outdated
Show resolved
Hide resolved
Framework/Algorithms/src/PolarizationCorrections/HeliumAnalyserEfficiency.cpp
Outdated
Show resolved
Hide resolved
docs/source/release/v6.12.0/Framework/Algorithms/Bugfixes/38290.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for all of the updates. I'm afraid that there are a couple more constants that needed to be updated for consistency with our naming conventions, so I've added comments for those below. Other than that, everything else is looking good now.
Framework/Algorithms/src/PolarizationCorrections/HeliumAnalyserEfficiency.cpp
Outdated
Show resolved
Hide resolved
Framework/Algorithms/src/PolarizationCorrections/HeliumAnalyserEfficiency.cpp
Outdated
Show resolved
Hide resolved
1a9ff59
to
9d89290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this, all of the code changes are looking good now.
I just did a final search for all instances of the old parameter names and it looks like the algorithm documentation needs to be updated. If you look in the description (https://docs.mantidproject.org/nightly/algorithms/HeliumAnalyserEfficiency-v1.html#description) then there are a couple of references to GasPressureTimesCellLength
and GasPressureTimesCellLengthError
that need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are all looking good and the algorithm documentation has also been updated to use the new constant names. This PR also moves the release notes from a previous PR that incorrectly went into the 6.11 folder into the 6.12 folder, so it's great to have that sorted out here too.
Description of work
Rename some HeliumAnalyserEfficiency algorithm parameters for consistency
Summary of work
Fixes #38290
To test: