-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash after script repository install location is deleted / moved #38173
Conversation
be5f60f
to
5fe2465
Compare
👋 Hi, @jhaigh0, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
If the script repo json files are deleted / moved, the ScriptRepository object will be set as invalid and the user will be prompted to reinstall upon reloading.
5fe2465
to
fb78b66
Compare
d22187f
to
622054c
Compare
7507739
to
f3f44d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Tested removing/renaming/moving and no crash occurs. Just a quick question about a deprecated method.
/// @deprecated Should avoid this, it is not in the design file. | ||
std::string localRepository() const { return local_repository; } | ||
std::string localRepository() override { return local_repository; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to be exposing this further through the parent if it is already tagged as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes I think I only did this because initially I was making changes to the repo model class and tests. I then needed to add this method to the MockSriptRepository
so it needed to be inherited. But I don't need that any more so it can be removed.
740d1b6
to
221dca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to go to me now. Nice work
This is a squashed version of mantidproject#38173 add file watcher to script repo model If the script repo json files are deleted / moved, the ScriptRepository object will be set as invalid and the user will be prompted to reinstall upon reloading. added release note add repo model test ccpCheck fixes change test to remove dir check for file existence on isValid rather than using watcher [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci cppcheck changes move ui setup to avoid crash when installing for the first time move repo_ptr setup back inside try to fix python test remove now unneeded changes fix cppcheck return by const ref
This is a squashed version of mantidproject#38173 add file watcher to script repo model If the script repo json files are deleted / moved, the ScriptRepository object will be set as invalid and the user will be prompted to reinstall upon reloading. added release note add repo model test ccpCheck fixes change test to remove dir check for file existence on isValid rather than using watcher [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci cppcheck changes move ui setup to avoid crash when installing for the first time move repo_ptr setup back inside try to fix python test remove now unneeded changes fix cppcheck return by const ref
This is a squashed version of mantidproject#38173 add file watcher to script repo model If the script repo json files are deleted / moved, the ScriptRepository object will be set as invalid and the user will be prompted to reinstall upon reloading. added release note add repo model test ccpCheck fixes change test to remove dir check for file existence on isValid rather than using watcher [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci cppcheck changes move ui setup to avoid crash when installing for the first time move repo_ptr setup back inside try to fix python test remove now unneeded changes fix cppcheck return by const ref
commit a8f64cccc781eac9892433e956bab7104ebf1213 Merge: dee818e0edc d9e270e4d39 Author: Jose Borreguero <[email protected]> Date: Mon Feb 24 14:30:49 2025 -0500 Merge pull request #38956 from mantidproject/revert_crosshair Revert added crosshair option in mantid commit d9e270e4d39fcc4c087c1a5d8f2396ecb01d3463 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:20:40 2025 -0500 typo fix in release note commit 73466fb3dfb41fd259f3fae612b42df6245df88e Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:19:38 2025 -0500 remove crosshair in release note commit b6bd2da2e74e421eb93f2fd5c4cdbe376bfc8dfa Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:43:55 2025 -0500 Revert "added tests and release documentation" This reverts commit 1b9820c0daf8ec786a60229f9c626b9104d7fcea. commit fbf1403fbed617c9cffc80934490de2797558571 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:41:57 2025 -0500 Revert "added crosshair option similar to matplotlib" This reverts commit f7d9c30f1729aead046d2000580706b04c3d16b1. commit dee818e0edc37d153b32d3535a38fef1e5f2e708 Merge: 1d016f6c14e 36b5c9e8f46 Author: thomashampson <[email protected]> Date: Fri Feb 21 16:37:23 2025 +0000 Merge pull request #38904 from mantidproject/fix_conda_install Only set XKB_CONFIG_ROOT for standalone installs & set GSETTINGS_SCHEMA_DEFINITIONS properly on conda installs commit 1d016f6c14e4d04689cd4fe00e6248042e049dba Author: thomashampson <[email protected]> Date: Fri Feb 21 16:12:52 2025 +0000 Finalise v6.12.0 release notes. (#38946) * Add missing workbench release note. * Update manage user directories screenshot The new screen shot is up to date with v6.12.0. The release note describing the Move to Top button links to this image, so it needed updating to avoid confusion. * Remove all used release notes. * Index page for v6.12.0 release notes. * reword algorithm profiler release note * codespell found typos in v6.12.0 release notes * small tweaks to 6.12 release notes after review commit 36b5c9e8f4656f677232706cd2e383a7df6ddbb8 Author: Jonathan Haigh <[email protected]> Date: Fri Feb 21 10:35:50 2025 +0000 set GSETTINGS_SCHEMA_DEFINITIONS using CONDA_PREFIX on conda install commit 56f61efdf9ca71ef6b64c17c4b9bee8748b462db Merge: a067d8aa008 f66f41310e0 Author: thomashampson <[email protected]> Date: Thu Feb 20 18:15:08 2025 +0000 Merge pull request #38910 from mantidproject/update_SANS_release_notes Update SANS release note commit f66f41310e0cf54239e0691d8ae7e06ee96bcf8c Author: MialLewis <[email protected]> Date: Thu Feb 20 16:20:55 2025 +0000 update sans release note commit 37a3a810a9d83118a18cf99524a0c9b90fc70c5c Author: Jonathan Haigh <[email protected]> Date: Thu Feb 20 13:39:00 2025 +0000 Only set XKB_CONFIG_ROOT for standalone installs Co-authored-by: thomashampson <[email protected]> commit a067d8aa008c3e2acf3afcf4b6dc9e30cabe4a48 Merge: f91402014e8 a73ea0aa19c Author: Silke Schomann <[email protected]> Date: Wed Feb 19 18:14:17 2025 +0000 Merge pull request #38891 from mantidproject/release-notes-6-12-workbench Release notes v6.12.0 - workbench commit a73ea0aa19c6213742105f4cc5c72c90c60e7a77 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 17:01:08 2025 +0000 Second edit of v6.12 workbench release notes after review. commit f91402014e82463d29aacd596641dfd2924fb0dc Merge: 4654d0aa8e1 45a851f5592 Author: Silke Schomann <[email protected]> Date: Wed Feb 19 13:49:45 2025 +0000 Merge pull request #38851 from mantidproject/release-notes-6-12-framework Release notes v6.12.0 - Framework commit 4654d0aa8e115d7e93ea243a9de2012d19ed2a6d Merge: 18fa2f03c3a 967d1313c60 Author: Pete Peterson <[email protected]> Date: Wed Feb 19 08:19:59 2025 -0500 Merge pull request #38845 from mantidproject/38826_extend_load_muon_nexus_for_hdf5 Add a new revision to LoadMuonNexus to reenable alg selection commit 45a851f5592444dcd00009a9d82a28551d385452 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 12:00:55 2025 +0000 Fix link inside bold text rst formatting for numpy link commit ea2778be8cb0421df31a8a8288e8336a7c34b623 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 17:07:48 2025 +0000 Edit v6.12.0 release notes. commit b33542870aea9a59fd145dca497f99a72feaa80d Author: thomashampson <[email protected]> Date: Wed Feb 19 09:31:41 2025 +0000 Second edit of v6.12.0 release notes after code review Co-authored-by: Jonathan Haigh <[email protected]> commit 967d1313c608afd676c926e5505ce79db089a6e6 Author: MialLewis <[email protected]> Date: Tue Feb 18 23:18:36 2025 +0000 fix non-windows compiler warnings commit f71a3ee71b1392df2a4a1a8507b4c000ae0bf546 Author: MialLewis <[email protected]> Date: Tue Feb 18 17:21:28 2025 +0000 add guard if alg not registered commit d2a21d2a423674682547a680041badf48e044dda Author: MialLewis <[email protected]> Date: Tue Feb 18 17:01:26 2025 +0000 remove unneeded imports and code commit b2c60d0dd79aa35c93151b6422cf225d1339fcd6 Author: MialLewis <[email protected]> Date: Tue Feb 18 16:46:26 2025 +0000 remove datahandling dependency from muon package commit 18fa2f03c3a88fa76a244e9fa65762f23a77d733 Merge: 383a45cdc54 4f2da3c5922 Author: Caila Finn <[email protected]> Date: Tue Feb 18 11:11:14 2025 +0000 Merge pull request #38876 from mantidproject/pin_libopenblas_0_3_27 Pin `libopenblas` to known working version commit bc5dd0bad800f8ef61aae05ef8bbb8df50d6094a Author: Tom Hampson <[email protected]> Date: Fri Feb 7 14:18:51 2025 +0000 Amalgamate v6.12.0 release notes for workbench commit 4f2da3c592229d8b392943557941cda03baee508 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 09:06:26 2025 +0000 Pin libopenblas to known working version Otherwise unit tests fail. commit 383a45cdc548b3b2a7531fff6958ea8d7fb45aaf Merge: 47d86fef15c 66d67ce7454 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 19:41:52 2025 +0000 Merge pull request #38868 from mantidproject/update_mslice_version_number Update MSlice version number from 2.10.1 to 2.11.0 commit 47d86fef15c00aae9132b220fdf84a98fed1462d Merge: 6271c251822 22ba6a63ec7 Author: Andrei Savici <[email protected]> Date: Mon Feb 17 13:56:31 2025 -0500 Merge pull request #38867 from mantidproject/bugfixSmoothNeighbours Fix performance issue with SmoothNeighbours commit 66d67ce745416fbae694e39c986b749b195733f2 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 15:55:54 2025 +0000 Update MSlice version number from 2.10.1 to 2.11.0 commit 22ba6a63ec74c5bdb9291d627f5da22518c8e88c Author: Carson Sears <[email protected]> Date: Mon Feb 17 08:37:05 2025 -0600 Fix performance issue with SmoothNeighbours commit 9370aed4e1560b53e2340fb5f7cc19d9911bc512 Author: MialLewis <[email protected]> Date: Mon Feb 17 09:51:34 2025 +0000 change Load to LoadMuonNexus in examples commit 6271c251822d22a5f3e569a44def0ccfa43881be Merge: 645714fad40 769f601a639 Author: James Clarke <[email protected]> Date: Fri Feb 14 16:48:17 2025 +0000 Merge pull request #38853 from mantidproject/fix_mac_standalone_packaging Fix macOS standalone packaging commit 769f601a639cdd2a35ed0438d390b68ef4756968 Author: Tom Hampson <[email protected]> Date: Fri Feb 14 16:37:01 2025 +0000 Check for directory before moving to avoid macOS error commit 69ed9f8cdceff9bae041652e0df95d45ec767e26 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 17:18:29 2025 +0000 Edit framework v6.12.0 release notes commit 645714fad4041c2d10d5e1cdc1e56df48a4a9ab5 Merge: b47d26b293c bd43e3a7b36 Author: James Clarke <[email protected]> Date: Fri Feb 14 15:08:16 2025 +0000 Merge pull request #38836 from mantidproject/release-notes-6-12-indirect-and-inelastic Release notes v6.12.0 - indirect and inelastic commit bd43e3a7b3631ee8420063862302c2457bcd6148 Author: thomashampson <[email protected]> Date: Fri Feb 14 14:06:58 2025 +0000 Use correct syntax for italic in release note Co-authored-by: James Clarke <[email protected]> commit c515c81f63e41e972c8bec532ef1219a9b10c126 Author: MialLewis <[email protected]> Date: Fri Feb 14 12:38:55 2025 +0000 ammend release note commit d6f6677d560b327672e1dd587b83bd83b4ecff3a Author: MialLewis <[email protected]> Date: Fri Feb 14 12:32:38 2025 +0000 change variable order commit a2cdd96c545b36036020be6c3be2d29ebdd2e3c1 Author: MialLewis <[email protected]> Date: Fri Feb 14 10:58:30 2025 +0000 fix compiler warnings and add doc commit b37e32ae412f9b616125a6c258f5713238e3530b Author: MialLewis <[email protected]> Date: Fri Feb 14 09:40:58 2025 +0000 remove redundant const return commit cbc967df8aedd676486f070fcda89d966f994076 Author: MialLewis <[email protected]> Date: Fri Feb 14 09:38:40 2025 +0000 small code improvements commit e4e283cdc7ea064c00d1cb320cd6edac403b11f7 Author: MialLewis <[email protected]> Date: Thu Feb 13 21:56:53 2025 +0000 resolve spurious cppcheck warning commit 817205d20fcbf5f21b94eefda1d084dc3c8acaed Author: MialLewis <[email protected]> Date: Thu Feb 13 19:38:29 2025 +0000 add unit tests for LoadMuonNexus3 wrapper commit 9cb6800a89c1298a702cb27b88a95c3fbec4b753 Author: MialLewis <[email protected]> Date: Thu Feb 13 17:07:09 2025 +0000 add LoadMuonNexus3 commit b47d26b293c2296d004e2aa99f786fe5e7d1499b Merge: 29e25ba3591 116508b5a62 Author: James Clarke <[email protected]> Date: Fri Feb 14 12:26:23 2025 +0000 Merge pull request #38831 from mantidproject/release-notes-6-12-relf_and_sans Release notes v6.12.0 - Reflectometry and SANS commit dd026d9fb4cdbc2b102759f94df7a1ddd49dce68 Author: thomashampson <[email protected]> Date: Fri Feb 14 11:51:51 2025 +0000 Fix grammar, spellin and doc link from code review Co-authored-by: Silke Schomann <[email protected]> commit 29e25ba3591a6bbc994698ecf3aca1964b157eec Merge: 5fc503f1c1c 19f2640e947 Author: James Clarke <[email protected]> Date: Fri Feb 14 11:32:44 2025 +0000 Merge pull request #38835 from mantidproject/release-notes-6-12-direct-geometry Release notes v6.12.0 - direct geometry commit 116508b5a627dbbaf9f9816bc51ec6b57c9387af Author: Tom Hampson <[email protected]> Date: Fri Feb 14 10:32:42 2025 +0000 Reference correct refl algorithm in release notes commit 5fc503f1c1cfc43733be950aae97b52514a92430 Merge: 92e3db4930e b0d94025d59 Author: James Clarke <[email protected]> Date: Thu Feb 13 15:43:06 2025 +0000 Merge pull request #38819 from mantidproject/38797_linux_standalone_fix Fix Linux standalone package for Ubuntu commit 632caa8618586637819ef919e9faed0d9f616029 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:28:14 2025 +0000 Edit v6.12.0 indirect gemoetry release notes. commit cdaa1230055a4b3a93e1bfefa6af2537761efa2e Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:27:35 2025 +0000 Edit v6.12.0 inelastic release notes. commit d318d516859e1ad1b3225574cc49f7f295a9597f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:55:23 2025 +0000 Amalgamate v6.12.0 release notes for indirect and inelastic commit 7c8ba60e08ef4c1dab7ff4287568ab45b16d7486 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:27:30 2025 +0000 Amalgamate framework release notes for 6.12.0 commit 19f2640e9473ec5abd9a4088b39d819dcba2c1c4 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 10:23:11 2025 +0000 Edit direct_geometry v6.12.0 release notes. commit 92e3db4930ead6be5a4913342bbb49862b0dc73f Merge: aab27b7bd4f 696363b2e6c Author: James Clarke <[email protected]> Date: Thu Feb 13 09:59:46 2025 +0000 Merge pull request #38829 from mantidproject/release-notes-6-12-muon Release notes v6.12.0 - Muon commit 2d6108cde6abee94a7367abe01f30b37b981b377 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 16:41:20 2025 +0000 Amalgamate 6.12.0 direct geometry release notes commit b0d94025d598399eeec2fd8703c0750c39e1a68f Author: Tom Hampson <[email protected]> Date: Wed Feb 12 09:19:59 2025 +0000 Remove unrequired workbench script from Linux standalone tarball. commit 1ae0d363a67188fd9af78b161551f88791c9d219 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:04:52 2025 +0000 Added release notes commit 032820d38351589cfaa65d3a894bce33c00851c6 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:01:00 2025 +0000 Rename linux tarball launcher script to mantidworkbench. This maintains the behaviour so that it's consistent with previous releases. commit 861bbdbe417dac2b5e21de93f493d09ba4698507 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 14:55:18 2025 +0000 Set XKB_CONFIG_ROOT variable when launching Linux standalone commit aab27b7bd4f7d483e703295d006e0bd0f5bbdc42 Merge: 0a8c358c9d5 e9054932998 Author: Andrei Savici <[email protected]> Date: Wed Feb 12 16:37:47 2025 -0500 Merge pull request #38801 from mantidproject/EWM8982-throw-exception Matrix Workspace throw exception for invalid plot argument commit 80680b53a6e0dda9a31eb9f7fffe3316ce232bf0 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 17:34:42 2025 +0000 Edit SANS and refl v6.12.0 release notes. commit 811f4456c998dad6ef3e446b7eeb0ad133305b0f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:11:35 2025 +0000 Amalgamate v6.12.0 release notes for reflectometry and SANS commit 696363b2e6c226b7bb430125ae2a5f7bb2c142f2 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 12:01:05 2025 +0000 Edit muon v6.12.0 release notes commit aa76004a46da8ee2f400c1e2452615eb0a40d85e Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:09:07 2025 +0000 Amalgamate muon release notes for v6.12.0 commit e905493299869eab2fd1174c2c3e21b62ade5a61 Author: Carson Sears <[email protected]> Date: Tue Feb 11 09:35:54 2025 -0600 check exception with regex commit 0a8c358c9d5caae59d2066f75b84ef6d67f2398f Merge: d1e96c3f656 f90257cd0ec Author: RichardWaiteSTFC <[email protected]> Date: Tue Feb 11 10:03:34 2025 +0000 Merge pull request #38804 from mantidproject/release-notes-6-12-diffraction Release notes v6.12.0 - Diffraction commit f90257cd0eca04620a91ac610ba5c72a72f4c8e5 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Feb 11 08:48:22 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit ab89e1b8cd4b44a082c0d32ddc458aa89d142ce1 Author: thomashampson <[email protected]> Date: Tue Feb 11 08:45:43 2025 +0000 Final release note edit for diffraction v6.12.0 Co-authored-by: Silke Schomann <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 478414de6a9be41eb66e4a15ac53c95b6a5ec7e2 Author: Carson Sears <[email protected]> Date: Mon Feb 10 15:48:35 2025 -0600 add statement about existing workspaces commit 0b10c28284bc57fe6f09fa7abf3b74855cd32422 Author: Carson Sears <[email protected]> Date: Fri Feb 7 16:34:19 2025 -0600 Update documentation commit 8cc61626acd4993404b73ae4db982752c231ed45 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 17:38:30 2025 +0000 Add and edit missing diffraction release note. commit 404b5b5f57dd9472854fd27e94fc217d35900cee Author: Tom Hampson <[email protected]> Date: Wed Feb 5 17:21:23 2025 +0000 Edit diffraction v6.12.0 release notes commit 72dd346b1e32e34da39946769e949646148e783b Author: Carson Sears <[email protected]> Date: Fri Feb 7 08:16:52 2025 -0600 Matrix Workspace throw exception for invalid plot argument commit add6c28e1aa19678913a12ce15c94f817e24c193 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 15:57:54 2025 +0000 Amalgamate 6.12.0 diffraction release notes commit d1e96c3f6567e1b4b4dd64c89c1e0ff480a4ef94 Merge: 5e605dabdf3 2cd25b9c894 Author: thomashampson <[email protected]> Date: Tue Feb 4 12:49:40 2025 +0000 Merge pull request #38341 from mantidproject/Create_Monte_Carlo_Ws Create Monte Carlo Workspace Algorithm commit 2cd25b9c8942de03ea65b4725076565aebb23cf1 Author: thomashampson <[email protected]> Date: Tue Feb 4 11:24:58 2025 +0000 rename variable commit bad0f7df8573279acf7468982bd631a740148dd4 Author: Despiix <[email protected]> Date: Thu Jan 16 14:28:35 2025 +0000 Adjust Algorithm and tests based on review Update Style of code and image change copyright year to 2025 Rename Variables Update progress bar Update Typo Remove repetitive description Co-authored-by: thomashampson <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 93cd87634522558cd6e8d2a15d97a01477d73c96 Author: Despiix <[email protected]> Date: Thu Nov 28 10:21:08 2024 +0000 Update Scaling Function Does not work if MC events are much less than data points in original workspace Updated Tests Remove redundant code [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6714fa0b1b8a0970335cdd1f6838e4897ed03c9b Author: Despiix <[email protected]> Date: Mon Nov 25 14:47:31 2024 +0000 Add Input for MC events and ScaleInputToMatchMCEvents and the errors are calculated as the sqrt of the counts. commit 5e605dabdf30e80564f155158877aede95a1cd99 Merge: a70663d5a27 d37cefc8d46 Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:50:40 2025 +0000 Merge pull request #38772 from cailafinn/38768_live_data_doctest Fix segfaulting doctest commit a70663d5a27b4066175a796aa8c5c2d27c890f11 Merge: 3d4b9dcde1a a180fc6484f Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:46:47 2025 +0000 Merge pull request #38764 from mantidproject/symmetrise-crash Fix crash on inelastic symmetrise interface commit a180fc6484fe284f7919024d742a44f419e0c3bc Author: GuiMacielPereira <[email protected]> Date: Mon Feb 3 11:18:13 2025 +0000 Fix conditional statements with return early style commit 3d4b9dcde1a75e404e1f190ccd83aeb0a6b99db1 Merge: 73d3467d9a3 09e851a0cb3 Author: Reece Boston <[email protected]> Date: Fri Jan 31 19:05:35 2025 -0500 Merge pull request #38777 from peterfpeterson/bugfix_sumspectra Fix a performance issue in SumSpectra with EventWorkspace commit 09e851a0cb39939d9e7baea39d34e2453289f1e2 Author: Pete Peterson <[email protected]> Date: Fri Jan 31 13:38:00 2025 -0500 Fix a performance issue in SumSpectra with EventWorkspace Since it was using EventList::operator+= the memory was reserved as each additional EventList was added in. This calculates the full number of events to be added and reserves that. Then the individual reserve() inside of EventList are effectively no-op. commit 73d3467d9a3f61e9d14129a8c8f9c585777fdbca Merge: 09e34d18196 92b97b60c29 Author: thomashampson <[email protected]> Date: Fri Jan 31 17:30:45 2025 +0000 Merge pull request #38770 from mantidproject/38650_project_recovery_plots_fix Reimplement #38486 to avoid project recovery error commit d37cefc8d46f83881b7885e3c03dcba973c3e3c0 Author: Caila Finn <[email protected]> Date: Fri Jan 31 14:12:03 2025 +0000 Fix segfaulting doctest Including the thread starts in the try block shouldn't make much difference, but I *think* it's stopping a hang that turns into a segfault when the test times out. RE #38768 commit 09e34d1819679afe6b323b64ae3b76e631975f9d Merge: cba714b1d14 cc2aeee31a0 Author: Silke Schomann <[email protected]> Date: Fri Jan 31 14:02:46 2025 +0000 Merge pull request #38769 from mantidproject/Fit_Parameter_cppcheck_bug_v2 Fix bug in Fit_Parameter getConstraint commit 92b97b60c295abf74dae49533533da32d31605bb Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 12:02:24 2025 +0000 update release note commit a82f43d9cd88745a2226ad987c5c9e176b61c782 Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:56:38 2025 +0000 remove argType enum and use .get to avoid the bug commit 51b081da852767dc0e4781eb68656dcb010fd21f Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:54:30 2025 +0000 add test for rename workspace for ws plot with line commit cc2aeee31a05413db89bad64a37f8654990c39bf Author: sf1919 <[email protected]> Date: Fri Jan 31 10:56:32 2025 +0000 Update release note commit 7aa28ac091a89291ea33f334bd6fa19ab0a16be8 Author: sf1919 <[email protected]> Date: Fri Jan 31 10:54:13 2025 +0000 Fix bug in Fit_Parameter getConstraint - As part of fixing cppcheck suppressions a bug was found in getConstraint where the loop was always true for the first if so never reached the other parts. - Tests added to check this behaviour is correct in future - cppcheck suppressions updated commit 30cd7c50356b5bfb51a54cf5952a3843784fd8e8 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 30 16:52:53 2025 +0000 Add Error message when workspace name is empty The problem was that when no workspace was added in the interface, the workspace name is a default empty string. The validating function checkWorkspaceExists() was not adding an error message on this case, which meant that when other functions evaluated if any error had happened (by doing errorString.empty()), the result was assumed valid because the error string was empty. What I did was simply add an error message when the workspace name is empty. This fixes other cases where the same crash was happening for the same reason. commit f8ff56dd4c70591c28c182ec7512a4667c19348a Author: Despiix <[email protected]> Date: Thu Nov 21 15:38:06 2024 +0000 Update Tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Update CreateMonteCarloWorkspace-v1.rst Co-authored-by: Jonathan Haigh <[email protected]> commit 821a49ced12885b5c6ef151cee00062e36442827 Author: Despiix <[email protected]> Date: Thu Nov 21 13:59:10 2024 +0000 Fix Progress Bar, Edit Release Note commit b05a99c526d8b231ddf5445542d0152decb4c7a6 Author: Despiix <[email protected]> Date: Tue Nov 12 16:38:56 2024 +0000 Add Algorithm Documentation Release Notes Add Description and remove redundant 0s [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit b65d0c21af78ccde5f100d289e9c1607c457a160 Author: Despiix <[email protected]> Date: Mon Nov 11 14:35:12 2024 +0000 Add progress bar commit 7b14fc219129d9a5754f90b7c6f694cca766e672 Author: Despiix <[email protected]> Date: Wed Nov 6 15:40:27 2024 +0000 Add 3 Unit tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Added 2 Unit tests to reproducability and out of bounds handling [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit d81ae1dea2e0331822bbc1d9cebd1213dc72dfd6 Author: Despiix <[email protected]> Date: Thu Oct 24 15:32:40 2024 +0100 Version 1 using Cumulative Distribution Function Clean up the codebase and break code into smaller functions. Remove auto and outputY from function Headers commit 44a9b19c5ae490bc25072629bde8672347ca2e59 Author: Despiix <[email protected]> Date: Tue Oct 22 13:13:36 2024 +0100 Added the Probability Density Function + Changed outputWS values Refactor: Clean up code and improve readability commit 878deade325fbccad9d75611afb1c3f7f3073711 Author: Despiix <[email protected]> Date: Tue Oct 22 10:53:05 2024 +0100 Functions to calculate the variance and the mean of the vector containing the random numbers generated. commit 3f28a59c5e4ebc4cf698f76c0180dddff14cb088 Author: Despiix <[email protected]> Date: Fri Oct 11 15:53:04 2024 +0100 Created Files and draft comments commit cba714b1d14a27548526a9951d032b50609d5776 Merge: 7cfebde659c 2da9fbc70f9 Author: Pete Peterson <[email protected]> Date: Thu Jan 30 10:16:18 2025 -0500 Merge pull request #38738 from rosswhitfield/fix_LoadErrorEventsNexus_zero_events Fix LoadErrorEventsNexus/PulseIndexer when there are zero events commit 2da9fbc70f9b671736c7cc6682e7d935558192e5 Author: Ross Whitfield <[email protected]> Date: Thu Jan 30 08:13:14 2025 +1100 Set bin edges for 0 event case commit bbfb41785527463109b971a34e701a5e227d2991 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 12:48:47 2025 +1100 Add release note commit 03ca40508ec99963024fc17d592bbf13bf7cf89e Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:10:22 2025 +1100 Fix BinEdges in LoadErrorEventsNexus commit 5391000735c2cbdb7d7bdef5385bdf53c52af28c Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:08:00 2025 +1100 Add test for LoadErrorEventsNexus with zero events commit 3c37a403db2474a10c82d77134162ecdbb9cc6c7 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:57:19 2025 +1100 Fix PulseIndexer commit 5e6300d09ba474f2161c748294ab787cb16cf2b2 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:56:58 2025 +1100 Add failing test for PulseIndexer when zero events commit 7cfebde659c329220386416ef2f9cccba3f222ec Merge: 15d8d2e5f43 0b75b791fcf Author: Pete Peterson <[email protected]> Date: Tue Jan 28 11:55:33 2025 -0500 Merge pull request #38698 from mantidproject/setMarkerStyle Fix setMarkerStyle commit 0b75b791fcf83afbcd061c8c3a10da75efd1be97 Author: Carson Sears <[email protected]> Date: Mon Jan 27 15:18:17 2025 -0600 remove boost function commit 15d8d2e5f4374610d09a57200efb5ff3e7c5880f Merge: 847424031ea c98c59798a3 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:35:26 2025 +0000 Merge pull request #38674 from mantidproject/38628_fix_mslice_nightly_version_bug Enable nightly standalone packages to install mslice nightly versions commit 847424031ea7303455b57747467987ea887731eb Author: Despi <[email protected]> Date: Mon Jan 27 10:23:57 2025 +0000 Surface Plotting from Multiple Single-Spectrum Workspaces (#38599) * Enable Plot All and Okay button * If any workspace contains only 1 spectra then set default value to 1. and minor file reformat * Fix plotting * Add release note * Adjust buttons to correct enable and disable + Adjust Test * Adjust function based on review * Remove Hardcoded "1" Set the default value as the first valid spectrum number * Fix plotting multiple wireframe workspaces * Clean up * Release Note Update * Enable `Plot_All` for Contour plots * Handle Error * Handle Error * If there is already a valid selection (wksp_indices or spectra), just ski * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Changes based on suggestions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete duplicate code * Delete duplicate code --------- Co-authored-by: James Clarke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> commit 727a603e421b4a00cfb8d6384b5e975028f91a8f Merge: ccfa649b1c6 ef97d87e12d Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:17:08 2025 +0000 Merge pull request #38683 from mantidproject/fix-argus-loading-crash Fix crash from loading into Muon Analysis interface commit ccfa649b1c60cd52a047fb8487e52ead4be868b8 Merge: c18ab182114 22b4ede51b6 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 07:45:07 2025 +0000 Merge pull request #38663 from mantidproject/38464_improve_zero_calibration_validation Add warning for zero-valued calibration spectra commit 67d26ca28db985b003c46db3f2d4111d84c73909 Author: Carson Sears <[email protected]> Date: Fri Jan 24 16:13:36 2025 -0600 fix setMarkerStyle commit c98c59798a372411fd39a5c3ce3a4f6779226f9c Author: Tom Hampson <[email protected]> Date: Wed Jan 22 17:57:04 2025 +0000 Enable nightly standalone packages to install mslice nightly versions commit 22b4ede51b68863717986dc8816c25411d044a4b Author: James Clarke <[email protected]> Date: Fri Jan 24 10:18:21 2025 +0000 Add link to release note commit ef97d87e12d95daee62597fffdcde2c0dfe7d079 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 23 17:36:28 2025 +0000 Check workspace is retrivable from ADS This simple change forces the ADS to check whether the workspace name i.e. load_result["DeadTimeTable"] actually exists. If it doesn't, it gives an error which is caught by the widget, instead of closing the widget and crashing mantid. Not an ideal solution, but a quick and simple one. commit c18ab18211482ca6329ae58ab0c231abd6871bc2 Merge: b78002e00aa 22837a332e7 Author: MialLewis <[email protected]> Date: Thu Jan 23 16:22:13 2025 +0000 Merge pull request #38669 from mantidproject/38654_launch_script_in_editor Skip first argument when calling main in launch script commit 22837a332e764371a326c42a276f35a9cd6c1eb1 Author: James Clarke <[email protected]> Date: Wed Jan 22 15:21:11 2025 +0000 Skip first argument when calling main The first argument of sys.argv is the launch script, so we don't need that. commit b7afa94cea34def4ab49b3530e0bee6799b9a24b Author: James Clarke <[email protected]> Date: Wed Jan 22 12:09:00 2025 +0000 Add test for calibration workspace with zeroes If the calibration workspace has zeroes, then we should get a warning with the correct workspace indices. commit 494b9d2479bd2b69b339f5c2642df46944986219 Author: James Clarke <[email protected]> Date: Wed Jan 22 11:37:05 2025 +0000 Detect zeroes in calibration workspace If the calibration workspace has zero-valued entries, then give the user a warning with the bad workspace indices. commit b78002e00aabc5f819c47e1950fa4f243d086052 Merge: 48117b6b26f 1d4a4e3fe6f Author: Silke Schomann <[email protected]> Date: Mon Jan 20 15:32:47 2025 +0000 Merge pull request #38605 from mantidproject/fix_save_ins Remove symmetry elements for SaveINS commit 1d4a4e3fe6f27a89c01b757c2770fd0d287d45e5 Author: Zachary Morgan (zgf) <[email protected]> Date: Mon Jan 20 08:20:51 2025 -0500 Using less ambiguous names commit 48117b6b26fd63a2cc119395aae966f61c3c9d8d Merge: 1541ebc0496 c155bd1b52a Author: James Clarke <[email protected]> Date: Mon Jan 20 09:49:09 2025 +0000 Merge pull request #38619 from mantidproject/fix_conjoin_workspaces_bug Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit 1541ebc0496f231c20c6ce73afc53bb14de14fbe Merge: f26fb41a3be e47801e3d4d Author: thomashampson <[email protected]> Date: Fri Jan 17 17:20:08 2025 +0000 Merge pull request #38611 from peterfpeterson/windows_suppress_warnings Change windows macro for warnings into compiler flags commit f26fb41a3be4dccf310a0781e4af8280e26e73af Merge: 61bccffbc5b d394998e401 Author: James Clarke <[email protected]> Date: Fri Jan 17 11:58:42 2025 +0000 Merge pull request #38616 from mantidproject/move_incorrectly_place_6_12_release_notes Relocate wrongly positioned v6.12.0 release notes commit c155bd1b52af32a3ebcf695fbcbffc2d54c85ff5 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:50:11 2025 +0000 Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit e63d5c8e507d63bef65d27b6f76623fc57aa5269 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:45:05 2025 +0000 Grammatical fix for warning messages commit b555a4f4b4033ff2cf611c5b3ab064accf667b6d Author: Tom Hampson <[email protected]> Date: Fri Jan 10 17:19:47 2025 +0000 Add ConjoinWorkspaces test to ensure it works for matching bins. commit 12516dfef44e242717a681f5f07c022fd22673d4 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:41:17 2025 -0500 Fix typo in comment commit af956a0209ae2721e4c6c47048afeb9da664e8b6 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:37:08 2025 -0500 Re-organize and comment commit aa64c8d5332d6db9301ca1a138e47daf035ee186 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:33:06 2025 -0500 Re-organize and comment commit a227a36c8aa67bc98525f3ecb9d63f744bf91ee9 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:25:32 2025 -0500 Re-organize and comment commit d394998e401273eb1ed50f69ba42f961f9f476b1 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 09:12:06 2025 +0000 Relocate wrongly positioned v6.12.0 release notes commit 61bccffbc5b428396fc86ce0aa19f5976dc3bf3d Merge: 703edc576c6 23abc08cb01 Author: Silke Schomann <[email protected]> Date: Thu Jan 16 18:20:37 2025 +0000 Merge pull request #38574 from mantidproject/36863-FindGlobalBMatrix-warnings 36863 find global b matrix warnings commit 80dd7f9c558834ae1b974ff858bedcc1b62fe8f7 Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 12:21:23 2025 -0500 Add new tests for SaveINS commit 9a1ddec8b27a54b5e22d59e6afba2e55584e085f Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 11:57:32 2025 -0500 Bias towards identity and origin commit 23abc08cb011d03e935a620a9c3043b3c7e500dd Author: Andy Bridger <[email protected]> Date: Thu Jan 16 16:31:15 2025 +0000 amend clarity of warnings when too few peaks commit 703edc576c6267755dd1b073da9a79f4bae25f9c Merge: 5ac51730b1a d916b2feeac Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:11:01 2025 +0000 Merge pull request #38459 from mantidproject/cppcheck_2_16 Update cppcheck to 2.16.0 commit 5ac51730b1ac2db044fa0d4adc2ab4ed5ea69d82 Merge: fc0059ccd0e a5937328c06 Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:04:32 2025 +0000 Merge pull request #38601 from jclarkeSTFC/38597_include_alg_profiler_all_os Include AlgoTimeRegister on all operating systems commit d916b2feeacaee79aa815ac4555a5da398ead71c Author: Tom Hampson <[email protected]> Date: Thu Jan 16 14:25:57 2025 +0000 Update cppcheck suppressions for v2.16.0 commit a5937328c06e538684a90d1485b69bf4b670775d Author: James Clarke <[email protected]> Date: Thu Jan 16 14:16:38 2025 +0000 Delete unused cpp file This file is no longer included in the build so should be deleted. commit fe6b26a7860e4ce91fd1cf07a56a7ce6ac138bf0 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 13:27:57 2025 +0000 Group internal cppcheck errors to extract them from the bounty list commit efe7ee752b1db7418f7197e9edc163c61a4ef249 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 11:11:03 2025 +0000 Sort cppcheck supressions by file name and line number commit 19678022dd9ee573b0441e16d20788a26d0cfef6 Author: Tom Hampson <[email protected]> Date: Tue Jan 7 14:44:00 2025 +0000 Restrict cppcheck to unix only. There is no 2.16.0 for Windows. We can re-add it for Windows in the future if it is reinstated. For the time being, since nobody is running it locally, we don't really need it to be installed on Windows. commit aa6475eef539100487046c38e93cee297f6ababd Author: Tom Hampson <[email protected]> Date: Thu Dec 5 10:46:20 2024 +0000 Suppress class_X_Y cppcheck warnings. commit 68568aed3397b834ed5dbd43897d2d19c682e176 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:40:06 2024 +0000 Update cppcheck to 2.16.0 commit 4a19b4f98c6350be94c435a9a5b5b2fec8f4e423 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:37:14 2024 +0000 Remove cppcheck suppressions temporarily for cppcheck update commit 41b6a779abb5ff7fa528198692caea172d569392 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:33:06 2024 +0000 fix typo to trigger cppcheck run commit fc0059ccd0ea26cef605008b8fb0c721bcb1701c Merge: 9e35ea46c48 45eeeac224a Author: thomashampson <[email protected]> Date: Thu Jan 16 14:06:38 2025 +0000 Merge pull request #38564 from mantidproject/38558_LoadNGEM_not_respecting_min_max_events Fix bug in LoadNGEM where Min/MaxEventsPerFrame were not respected commit 9e35ea46c48e0ec254491b48658ccd2e97f3f985 Merge: 99b307af65a 221dca92398 Author: thomashampson <[email protected]> Date: Thu Jan 16 12:54:18 2025 +0000 Merge pull request #38173 from mantidproject/35579_move_script_repo_install_location Fix crash after script repository install location is deleted / moved commit ceda6fc8d90eb60714697ec6b194124c01dc4ac0 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 12:33:11 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 413294e5c010af940867f2d3cb0d15c26e9fcebb Author: Andy Bridger <[email protected]> Date: Thu Jan 16 12:30:02 2025 +0000 replace in-place popping with new list appending commit 99b307af65a312aef290cd538059af1e530d508a Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 11:01:15 2025 +0000 [pre-commit.ci] pre-commit autoupdate (#38594) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.1](https://github.com/astral-sh/ruff-pre-commit/compare/v0.8.6...v0.9.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix whitespace that was already wrong * Remove additional whitespace found in local run of pre-commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pete Peterson <[email protected]> Co-authored-by: sf1919 <[email protected]> commit 45eeeac224a2318cacae3263f6384f521cb4e456 Author: Richard Waite <[email protected]> Date: Tue Jan 14 13:57:35 2025 +0000 Fix cpp check supression commit 6be0546cc8624c6da5bd3969575f6e2f8a7eaed0 Merge: 6c62fe37069 e744dffab96 Author: Andrei Savici <[email protected]> Date: Wed Jan 15 13:37:26 2025 -0500 Merge pull request #38591 from mantidproject/pychop_sns_update Update pychop definitions for SNS instruments commit 6c62fe37069e13d17255d8dedad3db3cb96ca7c4 Merge: 911eca1f711 4f567e74a33 Author: mantid-builder <[email protected]> Date: Wed Jan 15 18:32:20 2025 +0000 Merge ornl-next into main commit 911eca1f711b8ad84077ccd29c674dbca3549cc8 Merge: 4e656006570 e8ed4da6065 Author: Chen Zhang <[email protected]> Date: Wed Jan 15 11:13:43 2025 -0500 Merge pull request #38603 from rosswhitfield/disable_deprecated_qt_api Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 5f4ec8c8d4c3984e97ff49e28b7c9258e9db1bc9 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:59:05 2025 +0000 added check and test for make_ub_consistent commit 09bf7e3c8db8fe68b6e6c76c70f308f8ecb36a8b Author: James Clarke <[email protected]> Date: Wed Jan 15 15:55:50 2025 +0000 Handle base 16 thread ID numbers On macOS, the thread ID is given in hexadecimal, so when converting to an int we need to specify base 16. In other cases we use the default of base 10. commit 4e65600657018125751c6bf293557ba6e096c2aa Author: yusufjimoh <[email protected]> Date: Wed Jan 15 15:31:25 2025 +0000 Refactor WildesTest to reduce Code Duplication (#38529) * created helper functions to reduce code duplications in PolarizationCorrectionWildestest * refactor methods with spinstates, added more helper methods to reduce code duplication * removed helper methods from namespace to class as private methods in PolarizationCorrectionWildesTest * - refactor and improve tests based on suggestions from code review * improve tests based on suggestions from code review * change global constants case to Uppercase --------- Co-authored-by: Oluwaseun Jimoh <[email protected]> commit f499feaf9a1014d72bae69f4eacc8c4ec1f097ad Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 10:24:38 2025 -0500 Bias toward right-handed systems commit 7a9e55c9da998f406689297e20361a6119e85063 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:17:37 2025 +0000 added check and test for num_ws indexed by ref_ub commit 9884255ac99ee04ef4bde3463674d26657e7a3d3 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 14:57:12 2025 +0000 Rework Abins docs: input data formats info split out to another page (#38588) * Rework Abins docs: input data formats info split out to another page * Update changelog * Remove spurious "Title" from table RST * Fix AbinsDataFormats table header; drop spaces from label Even without spaces in the label, I am having trouble getting the new file to appear in the concepts index. * Add concepts category to new docs file; add local contents This category seems to be required for the new page to show up in concepts index. Also add a little contents section to the top of the file. commit 30baff0e4fd42d085261195245079ddb48dfbd68 Author: Michael Walsh <[email protected]> Date: Wed Jan 15 09:29:09 2025 -0500 added and propagated FullBinsOnly flag (#38550) * added and propagated FullBinsOnly flag * added a release note * added tests for ragged and non ragged workspace paths in rebin ragged for fullbinsonly * add missing - for release note * added doc reference to rebinragged page for a better explanation of FullBinsOnly * added an additional code sample explaining the new param * spellcheck commit b9697cf9a6db16d0658bb76eb95c2e62970b9fa3 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:03:21 2025 -0500 Add indentity back commit 72ffabb4b956c892c7c05de978b2b9df5bc0a5ca Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:00:40 2025 -0500 Move release note commit eb814b06cfe2ceaaa72b0cbd15ce563b8f895133 Merge: 864d61e6642 7dafe330062 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 13:59:26 2025 +0000 Merge pull request #38606 from ajjackson/abins-cache-error Detect unwriteable Abins cache, raise better error commit 0dc1b9be73febf0cc615c0a9c0a5a9e530b287fb Author: James Clarke <[email protected]> Date: Wed Jan 15 12:16:44 2025 +0000 Fixes for AlgoTimeRegister on Windows A long on Windows x64 is 4 bytes, but on Linux it is 8 bytes. To hold nanoseconds we need 8 bytes. By using size_t we'll get an 8 bytes integer. File system handling is different on Windows. So in the test, make the file in the class set up, close it, then open it to write when required. commit 3f6b975218f2522c0be4831427d2d32d9dc58718 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:13:41 2025 -0500 A/B/C-centering commit 127ad8a562b1d6a342d3a96cf3276e2faf2a6ded Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:10:07 2025 -0500 C-centering commit 1b50fe7425c53c43ece4dbc0ec1d2ad9596f50ac Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:53:04 2025 -0500 Fix typo commit 88b7bc246b91023a1378797abde3a6f0a89dbb73 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:48:47 2025 -0500 Adding release doc commit 076e038c7d70c1c2f1730456231a5bc337058363 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:43:33 2025 -0500 Comment code commit 80a7c636be4b258f49ebe18bba029f7a7d603e19 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:42:15 2025 +0000 improved readability of find_initial_indexing commit 703a22c9bd70ec422cc08518d0d9cb9a0af4a939 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:36:46 2025 -0500 Forgot primitive commit a5168730d0896c2c6b58f5b066dc95e9951b04c4 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:32:52 2025 +0000 collapse removal warning into one message commit c98ff406e5c64c03df431f57da4cbad3a357b326 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:30:52 2025 +0000 made final treatment of refUB into one loop commit 7dafe3300628314fef70e339c7dadca5d28ec9b5 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 11:14:24 2025 +0000 Correct type annotation Sadly the code here is not using Pathlib yet. Hopefully that will change soon! commit c790f5753015722929335434430ea2fa94726601 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:08:55 2025 +0000 moved SetUB call to exec_child_alg commit e5a7d5aaa24f6507972340812876f4bb91d515ae Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:05:19 2025 +0000 removed redundant IndexPeaks call commit 76d314b405042b0d59c2896face02c6fdfb1be56 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:03:23 2025 +0000 reduced num repeated loops and calcs commit 7b21c2b693c977d4000ed028b8c27af81138395b Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:40:40 2025 +0000 Add release note commit 864d61e6642f7ac8b3c1556b4b2eb9a94268376d Author: andy-bridger <[email protected]> Date: Wed Jan 15 10:35:50 2025 +0000 37795 change polaris pdf norm (#38535) * Updated vanadium norm dict as per issue #37795 Some extra changes will be needed as this norm_dict doesn't seem to be called properly * Removed hard-coded vanadium normalisation method * Added test support for pdf_norm options #37795 Updated the enum to recognise the option and updated the tests so "Relative" is no longer hard coded - added an extra test some corresponding files * Updated Test files for pdf_norm inclusion #37795 * moved repeated validation code to helper * improved run_focus_absorption readability * Add release notes * Updated the Polaris Docs commit 30035cc43ee870ee42ac4f9b3571feb21fceced8 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:19:23 2025 +0000 Detect unwriteable Abins cache, raise better error commit 820aecc4300a286e4b67df35845f0696d9b90efe Author: Andy Bridger <[email protected]> Date: Wed Jan 15 09:35:52 2025 +0000 updated validateInputs and its tests commit d4750d9749499253238372702ffa3ab0cf394d9b Merge: e4575ed635f f281969b387 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 08:31:32 2025 +0000 Merge pull request #38515 from mantidproject/38439_use_MD_fitting_IntegratePeaks1DProfile Use MultiDomainFunction in IntegratePeaks1DProfile commit d217e7a78af4e1332e2af1544689855f0d564210 Author: Zachary Morgan (zgf) <[email protected]> Date: Tue Jan 14 22:32:23 2025 -0500 Remove symmetry elements commit e744dffab96530ce3c8b5c099d6a6a4998b769f7 Author: Duc Le <[email protected]> Date: Tue Jan 14 23:15:26 2025 +0000 PyChop-SNS: Fix bug wrong freq for aperture width commit e8ed4da6065dce8a9da37b245babe7f3bc33343e Author: Ross Whitfield <[email protected]> Date: Wed Jan 15 11:14:39 2025 +1100 Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 03ac026aa3159375611e098388131da2cbd718df Author: Duc Le <[email protected]> Date: Tue Jan 14 17:41:36 2025 +0000 PyChop-SNS: correct Ikeda-Carpenter eqn in yaml commit 9670e52487e6e7cd0d6d940ef6582cf603f91e16 Author: Duc Le <[email protected]> Date: Tue Jan 14 17:35:55 2025 +0000 PyChop-SNS: Add flux units to GUI and yaml commit a54e44633730187dae6ae80aa17fbb816d59c31f Author: James Clarke <[email protected]> Date: Tue Jan 14 15:38:02 2025 +0000 Include AlgoTimeRegister on all operating systems By only including it on Linux, we need to either edit the docs to only have examples that only work on Linux, or selectively include the doc page for that class. It doesn't do any harm to use AlgoTimeRegister on other operating systems, then the tests can be run on all OS's, and things are a bit neater. commit e4575ed635f1d0ecbb5b228719d8372ffe7569fc Author: Silke Schomann <[email protected]> Date: Tue Jan 14 14:16:14 2025 +0000 Added release notes for MSlice (#38596) commit 221dca923988aab04ba6fba17a9863655c9414a4 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 14 13:59:55 2025 +0000 fix cppcheck return by const ref commit bdd6f43b0fcf4937d4bbff80938a390c9b6b74e6 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 7 13:36:26 2025 +0000 remove now unneeded changes commit 51586ce2ff7bfaff024abac18ce7418ce46233cf Author: Duc Le <[email protected]> Date: Tue Jan 14 01:32:04 2025 +0000 PyChop-SNS: Add docs. Got agreement with rez.mcvine.ornl.gov commit a9fe5cd18be2a40c60e27eec2f9f41fbadb27f19 Merge: 658472146df b66e3b3e135 Author: mantid-builder <[email protected]> Date: Tue Jan 14 00:20:43 2025 +0000 Merge ornl-next into main commit 658472146dfaf92e9a546e31da800f32241d3203 Merge: c7f74ccbf28 462310bf6ef Author: Pete Peterson <[email protected]> Date: Mon Jan 13 11:58:19 2025 -0500 Merge pull request #38580 from mantidproject/restore-lost-legend Restore lost legend when dragged out of figure commit c7f74ccbf2830cb9ac42a41cb9a5cc1e1d829329 Merge: 61bf054b0c8 423a2454f0b Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:53:58 2025 +0000 Merge pull request #38567 from mantidproject/38560_instance_true_for_create_autospec Add instance=True to mock.create_autospec for speed improvement commit 61bf054b0c8d9315d627cf454f3f732796197bcd Merge: 6ee0b15d7d5 f5cc1c8afbb Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:32:45 2025 +0000 Merge pull request #38582 from mantidproject/refactor_Save_NXcanSAS Refactor SaveNXcanSAS algorithm to support different variants commit 423a2454f0b667fa6bb90835c61a162e1f9b6f79 Author: Jonathan Haigh <[email protected]> Date: Mon Jan 13 15:25:12 2025 +0000 fix typo Co-authored-by: James Clarke <[email protected]> commit 794f130bf20ab7ba98d67ae2799b7c87cdaff920 Author: Duc Le <[email protected]> Date: Mon Jan 13 14:03:41 2025 +0000 Update pychop definitions for SNS instruments commit 6ee0b15d7d58be39fc02daf7c8d01a9f384471de Merge: e9176f323bd 3bc0c167126 Author: mantid-builder <[email protected]> Date: Mon Jan 13 13:52:34 2025 +0000 Merge ornl-next into main commit e9176f323bd7303e1b9b16e4d1d70922b02d0f04 Merge: a411fec9bb7 ac355057671 Author: Silke Schomann <[email protected]> Date: Mon Jan 13 07:26:03 2025 +0000 Merge pull request #38587 from rosswhitfield/sliceviewer_allow_custom_colormaps Allow users to register custom matplotlib colormaps commit a411fec9bb779acef8e7d27a4f7295d1405bb3e5 Merge: f579a71c7af 9c6d1b1a057 Author: Andrei Savici <[email protected]> Date: Fri Jan 10 14:50:41 2025 -0500 Merge pull request #38584 from peterfpeterson/38332_nexus_sorted_includes Remove clang-format suppressions commit f579a71c7afdeb67761dde29db2a9a0f2e6e6a14 Merge: be2990a7429 2a4279ce2fd Author: mantid-builder <[email protected]> Date: Fri Jan 10 15:21:48 2025 +0000 Merge ornl-next into main commit 7e1b17f89e491c1c0a9d7934cff1be4e159ef51a Author: Tom Hampson <[email protected]> Date: Fri Jan 10 14:41:31 2025 +0000 Update misleading function documentation. The function does not compare sizes of workspaces, so the comment was wrong. commit be2990a7429ab61fa821a248d0dfcf28bc70dd25 Merge: f81538d597c 6fb8ac3731d Author: Silke Schomann <[email protected]> Date: Fri Jan 10 14:10:20 2025 +0000 Merge pull request #38581 from rbauststfc/add_exception_to_SANS_move_test Add exception to SANS move test helper method commit 517eecff220802fc649b5aa9387216e14210a56c Author: Tom Hampson <[email protected]> Date: Fri Jan 10 12:18:42 2025 +0000 Remove old commend It doesn't make any sense and just confused me commit 462310bf6ef95f568ae8661450f035074e5fb8f8 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 10 12:16:12 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 5e961cb44831746d9b612553b118bde3f49d52ae Author: Despi <[email protected]> Date: Fri Jan 10 12:13:53 2025 +0000 Update qt/applications/workbench/workbench/plotting/figureinteraction.py Co-authored-by: Jonathan Haigh <[email protected]> commit f81538d597c2dbc8e2e87a74b918235596262835 Merge: 8c287822338 b767628baf4 Author: thomashampson <[email protected]> Date: Fri Jan 10 11:54:51 2025 +0000 Merge pull request #38513 from mantidproject/update_mslice_manual_test_docs Added section for testing ADS interactions to MSlice manual testing doc commit 16790c7fc1965700c18ed7ea0a755a96c799423c Author: Despiix <[email protected]> Date: Fri Jan 10 11:54:18 2025 +0000 Changes based on review commends commit b767628baf440e22bc12eff1304e3f7089a2e889 Author: thomashampson <[email protected]> Date: Fri Jan 10 10:44:42 2025 +0000 fix grammatical error in docs commit 8c28782233867eea94a225ceb1711899e737a787 Merge: 52d7654ed8a b22c536545f Author: thomashampson <[email protected]> Date: Fri Jan 10 10:41:16 2025 +0000 Merge pull request #38583 from mantidproject/napi5_systemtest_bug Ensure variable is initialised in Nexus code commit f5cc1c8afbba68e923f8be5f4ee64e73395f2fe9 Author: adriazalvarez <[email protected]> Date: Fri Jan 10 09:59:52 2025 +0000 Update header date on new file commit f9618ec588879e933e51103b37cf08968080cb19 Author: Despiix <[email protected]> Date: Fri Jan 10 09:21:06 2025 +0000 Fix failing text commit 52d7654ed8a67a2e7afa7b25dbee764c58d82e21 Merge: 65ebaa6ff4c 0610193cb85 Author: Silke Schomann <[email protected]> Date: Fri Jan 10 07:51:30 2025 +0000 Merge pull request #38538 from peterfpeterson/cc_gdo_docs CrossCorrelate and GetDetectorOffset algorithm user docs commit 65ebaa6ff4c5dc387654632f9f8fe316f3553618 Merge: df70d89339a 0453e5e0c01 Author: mantid-builder <[email protected]> Date: Fri Jan 10 01:03:57 2025 +0000 Merge ornl-next into main commit df70d89339a6c7d83d02f7537a6611800dff47a1 Merge: 3163798c8ad 0ac1c789a2f Author: mantid-builder <[email protected]> Date: Thu Jan 9 21:07:57 2025 +0000 Merge ornl-next into main commit 5b5fca5f0914c78ac9e2b0a90a6a9bc993dd2577 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 19:17:17 2025 +0000 Fix doxygen documentation warnings: 1. There were doxygen lines in add2DData function that needed to be escaped with \. to avoid a warning, this was not detected before as doxygen does not look in anonymous namespaces for mantid. 2. There was a doxygen comment missing input parameters to the function addInstrument. commit 3163798c8ad38aeeadedbe2be1f17fe2c31cfda3 Merge: 0681ab27e44 f7982b0abf7 Author: Chen Zhang <[email protected]> Date: Thu Jan 9 13:26:05 2025 -0500 Merge pull request #38565 from peterfpeterson/gtest_pin Clarify that gtest is pinned to v1.15.2 commit 0681ab27e4467c580b795fe7f33d5ad5b0bd3e78 Merge: 17ee6bbae9e 2e7242e878f Author: Pete Peterson <[email protected]> Date: Thu Jan 9 13:22:48 2025 -0500 Merge pull request #38486 from mantidproject/mantidaxes_lines_and_renameworkspace_exception account for lines sharing graphs with workspaces in mantidaxes commit b22c536545f3ecb35434d1c4bad219ed6e1cc13c Author: Andy Bridger <[email protected]> Date: Thu Jan 9 17:48:41 2025 +0000 initialise herr_t iRet to 0 commit 38fef13bbb34923f50b77e8b8aa82b99e6c079dd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:31:43 2025 +0000 Fix cppcheck style warning: commit e98b1be5a4dd1df439566fc8594a99fdc4552dbd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:20:15 2025 +0000 Fix typo in include path on cmakelist commit 17ee6bbae9e31d7e22ee835eeb7b0ad91bc00d2c Merge: 27b1a2c3403 bc7e058e29e Author: mantid-builder <[email protected]> Date: Thu Jan 9 15:11:07 2025 +0000 Merge ornl-next into main commit 6fb8ac3731d8c97205f3c3b59d8b7f00ec528fb1 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 14:50:05 2025 +0000 Add exception for unsupported instrument name commit 1d260bf0ebc31e8baa0d503d0b03ab3692188d85 Author: Despiix <[email protected]> Date: Thu Jan 9 14:57:21 2025 +0000 Add release note commit 27b1a2c340372b263256ee5cdb06c0f71d273722 Merge: 77d31880c71 9631fe5c07f Author: Silke Schomann <[email protected]> Date: Thu Jan 9 14:34:47 2025 +0000 Merge pull request #38577 from rbauststfc/fix_SANS_ZOOM_move_test Fix SANS move test failure commit 2d9634ea417de56d166807fbdf17ad6cb98c4aff Author: Despiix <[email protected]> Date: Thu Jan 9 14:24:35 2025 +0000 Add Function that solves issue It compares the size of the figure with the coordinates of the legend to see if it's out of range and if it is it snaps it back to its default position. commit 52b5e3ac712fe25760a20e2a841047a8d4861acc Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:18:25 2025 +0000 Organize code, add some descriptions and refactor some individual lines commit c8898d09d9b2eb517b9692d75f777f26756cbd83 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:17:36 2025 +0000 Referene to helper file in tests commit 868a9f434079ec21770d3ed5f52d555a73041764 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:16:51 2025 +0000 Add file for NXcanSAS helper functions commit ea9bb892835eeac840e706955ad8968dcd882eee Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:03:37 2025 +0000 Add parent SaveNXcanSasBase class with helper functionsin anonymous namespace commit d39fdf9d9dd439d95a6629a2d7aea2b0a2105f9f Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:02:18 2025 +0000 Remove helper and main exec structure out of inherited saveNXCanSass, inherit from saveNXcanSASBase commit 9631fe5c07fed8404cfb058cd39567dcd46d6d87 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 10:44:53 2025 +0000 Specify version of IDF to use in SANS move tests commit 77d31880c71e715424c8679bd47a196b51eb61b2 Merge: e6d3e6f33f8 94614aa94dd Author: Silke Schomann <[email protected]> Date: Thu Jan 9 10:16:10 2025 +0000 Merge pull request #38573 from peterfpeterson/38457_generate_export_header Remove includes of MantidKernel/System.h commit e6d3e6f33f8da9bc6a95035df1e7386a04dde479 Merge: beadc9d8abf 9cbc06067b0 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:49:11 2025 +0000 Merge pull request #38197 from mantidproject/38102_view_not_to_call_presenter_methods_directly Remove direct calls to presenter from cut viewer view commit beadc9d8abfab95aedc7acd498714126597d3eda Merge: 8eab7f131fe 8981bece2c2 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:33:13 2025 +0000 Merge pull request #38514 from mantidproject/38030_remove_pop_up Remove off-putting error prompt that appears when canceling a MaxEnt calculation in the Muon FDA interface commit 8eab7f131fe76f1e3e3f951b530811df8561784c Author: Waruna Priyankara J A Wickramasingha <[email protected]> Date: Thu Jan 9 09:16:24 2025 +0000 38254 add PeakShapeDetectorbin to integration algorithms (#38452) * Unit tests added for equal opeartor in python and c++ * early return added and cppcheck fix * reverted exposing opearator== into python for consistency * PeakShapeDetectorBin added to IntegratePeaksSkew * PeakShapeDetectorBin added to IntegratePeaksShoeboxTOF * PeakShapeDetectorBin added to IntegratePeaksSkew * null check added for ipos data * updated for review comments. Q plottting yet to do * Unit tests added * integratepeaksshoebox xlimits and det ids updated * release note updated * updated note commit 24dcde322389df921a863df4a403ea9f99de6fd9 Author: Mohammed Almakki <[email protected]> Date: Thu Jan 9 09:15:20 2025 +0000 Add table view for group peak workspace (#37166) * Add group peak workspaces model * Add show data to group peak workspaces * Add group presenter and table model * Add support for sorting, deleting, plotting, stats, and batch loading * Add group model unit tests * Add group table model unit tests * Add group presenter unit tests * Add release note commit 67ac3fe1e9538f7ccaa67ebd93a391116de5ad6b Merge: 5a0bafe803e 73c368c4920 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 07:54:51 2025 +0000 Merge pull request #38556 from rosswhitfield/fix_sliceviewer_data_exception Fix invalid data when MDHistoworkspace replaced and has original workspace commit 2e7242e878fe6435d1b805bd9b45649fb64dd994 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 15:17:57 2024 -0500 fix failing test file commit 159b14c40e8338f52d54b1e116b732914c4fa40c Author: Michael Walsh <[email protected]> Date: Fri Dec 6 14:18:48 2024 -0500 added release note commit 61f78e2bb22c0703f3477376714a4d1aee2e3a18 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 13:18:48 2024 -0500 account for lines sharing graphs with workspaces in mantidaxes commit 5a0bafe803e9ef7816d59f957d33ff0457f48a54 Merge: 754148a9b75 ff47bef4556 Author: mantid-builder <[email protected]> Date: Wed Jan 8 20:19:19 2025 +0000 Merge ornl-next into main commit 754148a9b752f31d24401d2d3525e4892d377c4e Merge: 17a7a926a45 00d26587feb Author: mantid-builder <man…
commit a8f64cccc781eac9892433e956bab7104ebf1213 Merge: dee818e0edc d9e270e4d39 Author: Jose Borreguero <[email protected]> Date: Mon Feb 24 14:30:49 2025 -0500 Merge pull request #38956 from mantidproject/revert_crosshair Revert added crosshair option in mantid commit d9e270e4d39fcc4c087c1a5d8f2396ecb01d3463 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:20:40 2025 -0500 typo fix in release note commit 73466fb3dfb41fd259f3fae612b42df6245df88e Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:19:38 2025 -0500 remove crosshair in release note commit b6bd2da2e74e421eb93f2fd5c4cdbe376bfc8dfa Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:43:55 2025 -0500 Revert "added tests and release documentation" This reverts commit 1b9820c0daf8ec786a60229f9c626b9104d7fcea. commit fbf1403fbed617c9cffc80934490de2797558571 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:41:57 2025 -0500 Revert "added crosshair option similar to matplotlib" This reverts commit f7d9c30f1729aead046d2000580706b04c3d16b1. commit dee818e0edc37d153b32d3535a38fef1e5f2e708 Merge: 1d016f6c14e 36b5c9e8f46 Author: thomashampson <[email protected]> Date: Fri Feb 21 16:37:23 2025 +0000 Merge pull request #38904 from mantidproject/fix_conda_install Only set XKB_CONFIG_ROOT for standalone installs & set GSETTINGS_SCHEMA_DEFINITIONS properly on conda installs commit 1d016f6c14e4d04689cd4fe00e6248042e049dba Author: thomashampson <[email protected]> Date: Fri Feb 21 16:12:52 2025 +0000 Finalise v6.12.0 release notes. (#38946) * Add missing workbench release note. * Update manage user directories screenshot The new screen shot is up to date with v6.12.0. The release note describing the Move to Top button links to this image, so it needed updating to avoid confusion. * Remove all used release notes. * Index page for v6.12.0 release notes. * reword algorithm profiler release note * codespell found typos in v6.12.0 release notes * small tweaks to 6.12 release notes after review commit 36b5c9e8f4656f677232706cd2e383a7df6ddbb8 Author: Jonathan Haigh <[email protected]> Date: Fri Feb 21 10:35:50 2025 +0000 set GSETTINGS_SCHEMA_DEFINITIONS using CONDA_PREFIX on conda install commit 56f61efdf9ca71ef6b64c17c4b9bee8748b462db Merge: a067d8aa008 f66f41310e0 Author: thomashampson <[email protected]> Date: Thu Feb 20 18:15:08 2025 +0000 Merge pull request #38910 from mantidproject/update_SANS_release_notes Update SANS release note commit f66f41310e0cf54239e0691d8ae7e06ee96bcf8c Author: MialLewis <[email protected]> Date: Thu Feb 20 16:20:55 2025 +0000 update sans release note commit 37a3a810a9d83118a18cf99524a0c9b90fc70c5c Author: Jonathan Haigh <[email protected]> Date: Thu Feb 20 13:39:00 2025 +0000 Only set XKB_CONFIG_ROOT for standalone installs Co-authored-by: thomashampson <[email protected]> commit a067d8aa008c3e2acf3afcf4b6dc9e30cabe4a48 Merge: f91402014e8 a73ea0aa19c Author: Silke Schomann <[email protected]> Date: Wed Feb 19 18:14:17 2025 +0000 Merge pull request #38891 from mantidproject/release-notes-6-12-workbench Release notes v6.12.0 - workbench commit a73ea0aa19c6213742105f4cc5c72c90c60e7a77 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 17:01:08 2025 +0000 Second edit of v6.12 workbench release notes after review. commit f91402014e82463d29aacd596641dfd2924fb0dc Merge: 4654d0aa8e1 45a851f5592 Author: Silke Schomann <[email protected]> Date: Wed Feb 19 13:49:45 2025 +0000 Merge pull request #38851 from mantidproject/release-notes-6-12-framework Release notes v6.12.0 - Framework commit 4654d0aa8e115d7e93ea243a9de2012d19ed2a6d Merge: 18fa2f03c3a 967d1313c60 Author: Pete Peterson <[email protected]> Date: Wed Feb 19 08:19:59 2025 -0500 Merge pull request #38845 from mantidproject/38826_extend_load_muon_nexus_for_hdf5 Add a new revision to LoadMuonNexus to reenable alg selection commit 45a851f5592444dcd00009a9d82a28551d385452 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 12:00:55 2025 +0000 Fix link inside bold text rst formatting for numpy link commit ea2778be8cb0421df31a8a8288e8336a7c34b623 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 17:07:48 2025 +0000 Edit v6.12.0 release notes. commit b33542870aea9a59fd145dca497f99a72feaa80d Author: thomashampson <[email protected]> Date: Wed Feb 19 09:31:41 2025 +0000 Second edit of v6.12.0 release notes after code review Co-authored-by: Jonathan Haigh <[email protected]> commit 967d1313c608afd676c926e5505ce79db089a6e6 Author: MialLewis <[email protected]> Date: Tue Feb 18 23:18:36 2025 +0000 fix non-windows compiler warnings commit f71a3ee71b1392df2a4a1a8507b4c000ae0bf546 Author: MialLewis <[email protected]> Date: Tue Feb 18 17:21:28 2025 +0000 add guard if alg not registered commit d2a21d2a423674682547a680041badf48e044dda Author: MialLewis <[email protected]> Date: Tue Feb 18 17:01:26 2025 +0000 remove unneeded imports and code commit b2c60d0dd79aa35c93151b6422cf225d1339fcd6 Author: MialLewis <[email protected]> Date: Tue Feb 18 16:46:26 2025 +0000 remove datahandling dependency from muon package commit 18fa2f03c3a88fa76a244e9fa65762f23a77d733 Merge: 383a45cdc54 4f2da3c5922 Author: Caila Finn <[email protected]> Date: Tue Feb 18 11:11:14 2025 +0000 Merge pull request #38876 from mantidproject/pin_libopenblas_0_3_27 Pin `libopenblas` to known working version commit bc5dd0bad800f8ef61aae05ef8bbb8df50d6094a Author: Tom Hampson <[email protected]> Date: Fri Feb 7 14:18:51 2025 +0000 Amalgamate v6.12.0 release notes for workbench commit 4f2da3c592229d8b392943557941cda03baee508 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 09:06:26 2025 +0000 Pin libopenblas to known working version Otherwise unit tests fail. commit 383a45cdc548b3b2a7531fff6958ea8d7fb45aaf Merge: 47d86fef15c 66d67ce7454 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 19:41:52 2025 +0000 Merge pull request #38868 from mantidproject/update_mslice_version_number Update MSlice version number from 2.10.1 to 2.11.0 commit 47d86fef15c00aae9132b220fdf84a98fed1462d Merge: 6271c251822 22ba6a63ec7 Author: Andrei Savici <[email protected]> Date: Mon Feb 17 13:56:31 2025 -0500 Merge pull request #38867 from mantidproject/bugfixSmoothNeighbours Fix performance issue with SmoothNeighbours commit 66d67ce745416fbae694e39c986b749b195733f2 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 15:55:54 2025 +0000 Update MSlice version number from 2.10.1 to 2.11.0 commit 22ba6a63ec74c5bdb9291d627f5da22518c8e88c Author: Carson Sears <[email protected]> Date: Mon Feb 17 08:37:05 2025 -0600 Fix performance issue with SmoothNeighbours commit 9370aed4e1560b53e2340fb5f7cc19d9911bc512 Author: MialLewis <[email protected]> Date: Mon Feb 17 09:51:34 2025 +0000 change Load to LoadMuonNexus in examples commit 6271c251822d22a5f3e569a44def0ccfa43881be Merge: 645714fad40 769f601a639 Author: James Clarke <[email protected]> Date: Fri Feb 14 16:48:17 2025 +0000 Merge pull request #38853 from mantidproject/fix_mac_standalone_packaging Fix macOS standalone packaging commit 769f601a639cdd2a35ed0438d390b68ef4756968 Author: Tom Hampson <[email protected]> Date: Fri Feb 14 16:37:01 2025 +0000 Check for directory before moving to avoid macOS error commit 69ed9f8cdceff9bae041652e0df95d45ec767e26 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 17:18:29 2025 +0000 Edit framework v6.12.0 release notes commit 645714fad4041c2d10d5e1cdc1e56df48a4a9ab5 Merge: b47d26b293c bd43e3a7b36 Author: James Clarke <[email protected]> Date: Fri Feb 14 15:08:16 2025 +0000 Merge pull request #38836 from mantidproject/release-notes-6-12-indirect-and-inelastic Release notes v6.12.0 - indirect and inelastic commit bd43e3a7b3631ee8420063862302c2457bcd6148 Author: thomashampson <[email protected]> Date: Fri Feb 14 14:06:58 2025 +0000 Use correct syntax for italic in release note Co-authored-by: James Clarke <[email protected]> commit c515c81f63e41e972c8bec532ef1219a9b10c126 Author: MialLewis <[email protected]> Date: Fri Feb 14 12:38:55 2025 +0000 ammend release note commit d6f6677d560b327672e1dd587b83bd83b4ecff3a Author: MialLewis <[email protected]> Date: Fri Feb 14 12:32:38 2025 +0000 change variable order commit a2cdd96c545b36036020be6c3be2d29ebdd2e3c1 Author: MialLewis <[email protected]> Date: Fri Feb 14 10:58:30 2025 +0000 fix compiler warnings and add doc commit b37e32ae412f9b616125a6c258f5713238e3530b Author: MialLewis <[email protected]> Date: Fri Feb 14 09:40:58 2025 +0000 remove redundant const return commit cbc967df8aedd676486f070fcda89d966f994076 Author: MialLewis <[email protected]> Date: Fri Feb 14 09:38:40 2025 +0000 small code improvements commit e4e283cdc7ea064c00d1cb320cd6edac403b11f7 Author: MialLewis <[email protected]> Date: Thu Feb 13 21:56:53 2025 +0000 resolve spurious cppcheck warning commit 817205d20fcbf5f21b94eefda1d084dc3c8acaed Author: MialLewis <[email protected]> Date: Thu Feb 13 19:38:29 2025 +0000 add unit tests for LoadMuonNexus3 wrapper commit 9cb6800a89c1298a702cb27b88a95c3fbec4b753 Author: MialLewis <[email protected]> Date: Thu Feb 13 17:07:09 2025 +0000 add LoadMuonNexus3 commit b47d26b293c2296d004e2aa99f786fe5e7d1499b Merge: 29e25ba3591 116508b5a62 Author: James Clarke <[email protected]> Date: Fri Feb 14 12:26:23 2025 +0000 Merge pull request #38831 from mantidproject/release-notes-6-12-relf_and_sans Release notes v6.12.0 - Reflectometry and SANS commit dd026d9fb4cdbc2b102759f94df7a1ddd49dce68 Author: thomashampson <[email protected]> Date: Fri Feb 14 11:51:51 2025 +0000 Fix grammar, spellin and doc link from code review Co-authored-by: Silke Schomann <[email protected]> commit 29e25ba3591a6bbc994698ecf3aca1964b157eec Merge: 5fc503f1c1c 19f2640e947 Author: James Clarke <[email protected]> Date: Fri Feb 14 11:32:44 2025 +0000 Merge pull request #38835 from mantidproject/release-notes-6-12-direct-geometry Release notes v6.12.0 - direct geometry commit 116508b5a627dbbaf9f9816bc51ec6b57c9387af Author: Tom Hampson <[email protected]> Date: Fri Feb 14 10:32:42 2025 +0000 Reference correct refl algorithm in release notes commit 5fc503f1c1cfc43733be950aae97b52514a92430 Merge: 92e3db4930e b0d94025d59 Author: James Clarke <[email protected]> Date: Thu Feb 13 15:43:06 2025 +0000 Merge pull request #38819 from mantidproject/38797_linux_standalone_fix Fix Linux standalone package for Ubuntu commit 632caa8618586637819ef919e9faed0d9f616029 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:28:14 2025 +0000 Edit v6.12.0 indirect gemoetry release notes. commit cdaa1230055a4b3a93e1bfefa6af2537761efa2e Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:27:35 2025 +0000 Edit v6.12.0 inelastic release notes. commit d318d516859e1ad1b3225574cc49f7f295a9597f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:55:23 2025 +0000 Amalgamate v6.12.0 release notes for indirect and inelastic commit 7c8ba60e08ef4c1dab7ff4287568ab45b16d7486 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:27:30 2025 +0000 Amalgamate framework release notes for 6.12.0 commit 19f2640e9473ec5abd9a4088b39d819dcba2c1c4 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 10:23:11 2025 +0000 Edit direct_geometry v6.12.0 release notes. commit 92e3db4930ead6be5a4913342bbb49862b0dc73f Merge: aab27b7bd4f 696363b2e6c Author: James Clarke <[email protected]> Date: Thu Feb 13 09:59:46 2025 +0000 Merge pull request #38829 from mantidproject/release-notes-6-12-muon Release notes v6.12.0 - Muon commit 2d6108cde6abee94a7367abe01f30b37b981b377 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 16:41:20 2025 +0000 Amalgamate 6.12.0 direct geometry release notes commit b0d94025d598399eeec2fd8703c0750c39e1a68f Author: Tom Hampson <[email protected]> Date: Wed Feb 12 09:19:59 2025 +0000 Remove unrequired workbench script from Linux standalone tarball. commit 1ae0d363a67188fd9af78b161551f88791c9d219 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:04:52 2025 +0000 Added release notes commit 032820d38351589cfaa65d3a894bce33c00851c6 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:01:00 2025 +0000 Rename linux tarball launcher script to mantidworkbench. This maintains the behaviour so that it's consistent with previous releases. commit 861bbdbe417dac2b5e21de93f493d09ba4698507 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 14:55:18 2025 +0000 Set XKB_CONFIG_ROOT variable when launching Linux standalone commit aab27b7bd4f7d483e703295d006e0bd0f5bbdc42 Merge: 0a8c358c9d5 e9054932998 Author: Andrei Savici <[email protected]> Date: Wed Feb 12 16:37:47 2025 -0500 Merge pull request #38801 from mantidproject/EWM8982-throw-exception Matrix Workspace throw exception for invalid plot argument commit 80680b53a6e0dda9a31eb9f7fffe3316ce232bf0 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 17:34:42 2025 +0000 Edit SANS and refl v6.12.0 release notes. commit 811f4456c998dad6ef3e446b7eeb0ad133305b0f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:11:35 2025 +0000 Amalgamate v6.12.0 release notes for reflectometry and SANS commit 696363b2e6c226b7bb430125ae2a5f7bb2c142f2 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 12:01:05 2025 +0000 Edit muon v6.12.0 release notes commit aa76004a46da8ee2f400c1e2452615eb0a40d85e Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:09:07 2025 +0000 Amalgamate muon release notes for v6.12.0 commit e905493299869eab2fd1174c2c3e21b62ade5a61 Author: Carson Sears <[email protected]> Date: Tue Feb 11 09:35:54 2025 -0600 check exception with regex commit 0a8c358c9d5caae59d2066f75b84ef6d67f2398f Merge: d1e96c3f656 f90257cd0ec Author: RichardWaiteSTFC <[email protected]> Date: Tue Feb 11 10:03:34 2025 +0000 Merge pull request #38804 from mantidproject/release-notes-6-12-diffraction Release notes v6.12.0 - Diffraction commit f90257cd0eca04620a91ac610ba5c72a72f4c8e5 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Feb 11 08:48:22 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit ab89e1b8cd4b44a082c0d32ddc458aa89d142ce1 Author: thomashampson <[email protected]> Date: Tue Feb 11 08:45:43 2025 +0000 Final release note edit for diffraction v6.12.0 Co-authored-by: Silke Schomann <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 478414de6a9be41eb66e4a15ac53c95b6a5ec7e2 Author: Carson Sears <[email protected]> Date: Mon Feb 10 15:48:35 2025 -0600 add statement about existing workspaces commit 0b10c28284bc57fe6f09fa7abf3b74855cd32422 Author: Carson Sears <[email protected]> Date: Fri Feb 7 16:34:19 2025 -0600 Update documentation commit 8cc61626acd4993404b73ae4db982752c231ed45 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 17:38:30 2025 +0000 Add and edit missing diffraction release note. commit 404b5b5f57dd9472854fd27e94fc217d35900cee Author: Tom Hampson <[email protected]> Date: Wed Feb 5 17:21:23 2025 +0000 Edit diffraction v6.12.0 release notes commit 72dd346b1e32e34da39946769e949646148e783b Author: Carson Sears <[email protected]> Date: Fri Feb 7 08:16:52 2025 -0600 Matrix Workspace throw exception for invalid plot argument commit add6c28e1aa19678913a12ce15c94f817e24c193 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 15:57:54 2025 +0000 Amalgamate 6.12.0 diffraction release notes commit d1e96c3f6567e1b4b4dd64c89c1e0ff480a4ef94 Merge: 5e605dabdf3 2cd25b9c894 Author: thomashampson <[email protected]> Date: Tue Feb 4 12:49:40 2025 +0000 Merge pull request #38341 from mantidproject/Create_Monte_Carlo_Ws Create Monte Carlo Workspace Algorithm commit 2cd25b9c8942de03ea65b4725076565aebb23cf1 Author: thomashampson <[email protected]> Date: Tue Feb 4 11:24:58 2025 +0000 rename variable commit bad0f7df8573279acf7468982bd631a740148dd4 Author: Despiix <[email protected]> Date: Thu Jan 16 14:28:35 2025 +0000 Adjust Algorithm and tests based on review Update Style of code and image change copyright year to 2025 Rename Variables Update progress bar Update Typo Remove repetitive description Co-authored-by: thomashampson <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 93cd87634522558cd6e8d2a15d97a01477d73c96 Author: Despiix <[email protected]> Date: Thu Nov 28 10:21:08 2024 +0000 Update Scaling Function Does not work if MC events are much less than data points in original workspace Updated Tests Remove redundant code [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6714fa0b1b8a0970335cdd1f6838e4897ed03c9b Author: Despiix <[email protected]> Date: Mon Nov 25 14:47:31 2024 +0000 Add Input for MC events and ScaleInputToMatchMCEvents and the errors are calculated as the sqrt of the counts. commit 5e605dabdf30e80564f155158877aede95a1cd99 Merge: a70663d5a27 d37cefc8d46 Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:50:40 2025 +0000 Merge pull request #38772 from cailafinn/38768_live_data_doctest Fix segfaulting doctest commit a70663d5a27b4066175a796aa8c5c2d27c890f11 Merge: 3d4b9dcde1a a180fc6484f Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:46:47 2025 +0000 Merge pull request #38764 from mantidproject/symmetrise-crash Fix crash on inelastic symmetrise interface commit a180fc6484fe284f7919024d742a44f419e0c3bc Author: GuiMacielPereira <[email protected]> Date: Mon Feb 3 11:18:13 2025 +0000 Fix conditional statements with return early style commit 3d4b9dcde1a75e404e1f190ccd83aeb0a6b99db1 Merge: 73d3467d9a3 09e851a0cb3 Author: Reece Boston <[email protected]> Date: Fri Jan 31 19:05:35 2025 -0500 Merge pull request #38777 from peterfpeterson/bugfix_sumspectra Fix a performance issue in SumSpectra with EventWorkspace commit 09e851a0cb39939d9e7baea39d34e2453289f1e2 Author: Pete Peterson <[email protected]> Date: Fri Jan 31 13:38:00 2025 -0500 Fix a performance issue in SumSpectra with EventWorkspace Since it was using EventList::operator+= the memory was reserved as each additional EventList was added in. This calculates the full number of events to be added and reserves that. Then the individual reserve() inside of EventList are effectively no-op. commit 73d3467d9a3f61e9d14129a8c8f9c585777fdbca Merge: 09e34d18196 92b97b60c29 Author: thomashampson <[email protected]> Date: Fri Jan 31 17:30:45 2025 +0000 Merge pull request #38770 from mantidproject/38650_project_recovery_plots_fix Reimplement #38486 to avoid project recovery error commit d37cefc8d46f83881b7885e3c03dcba973c3e3c0 Author: Caila Finn <[email protected]> Date: Fri Jan 31 14:12:03 2025 +0000 Fix segfaulting doctest Including the thread starts in the try block shouldn't make much difference, but I *think* it's stopping a hang that turns into a segfault when the test times out. RE #38768 commit 09e34d1819679afe6b323b64ae3b76e631975f9d Merge: cba714b1d14 cc2aeee31a0 Author: Silke Schomann <[email protected]> Date: Fri Jan 31 14:02:46 2025 +0000 Merge pull request #38769 from mantidproject/Fit_Parameter_cppcheck_bug_v2 Fix bug in Fit_Parameter getConstraint commit 92b97b60c295abf74dae49533533da32d31605bb Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 12:02:24 2025 +0000 update release note commit a82f43d9cd88745a2226ad987c5c9e176b61c782 Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:56:38 2025 +0000 remove argType enum and use .get to avoid the bug commit 51b081da852767dc0e4781eb68656dcb010fd21f Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:54:30 2025 +0000 add test for rename workspace for ws plot with line commit cc2aeee31a05413db89bad64a37f8654990c39bf Author: sf1919 <[email protected]> Date: Fri Jan 31 10:56:32 2025 +0000 Update release note commit 7aa28ac091a89291ea33f334bd6fa19ab0a16be8 Author: sf1919 <[email protected]> Date: Fri Jan 31 10:54:13 2025 +0000 Fix bug in Fit_Parameter getConstraint - As part of fixing cppcheck suppressions a bug was found in getConstraint where the loop was always true for the first if so never reached the other parts. - Tests added to check this behaviour is correct in future - cppcheck suppressions updated commit 30cd7c50356b5bfb51a54cf5952a3843784fd8e8 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 30 16:52:53 2025 +0000 Add Error message when workspace name is empty The problem was that when no workspace was added in the interface, the workspace name is a default empty string. The validating function checkWorkspaceExists() was not adding an error message on this case, which meant that when other functions evaluated if any error had happened (by doing errorString.empty()), the result was assumed valid because the error string was empty. What I did was simply add an error message when the workspace name is empty. This fixes other cases where the same crash was happening for the same reason. commit f8ff56dd4c70591c28c182ec7512a4667c19348a Author: Despiix <[email protected]> Date: Thu Nov 21 15:38:06 2024 +0000 Update Tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Update CreateMonteCarloWorkspace-v1.rst Co-authored-by: Jonathan Haigh <[email protected]> commit 821a49ced12885b5c6ef151cee00062e36442827 Author: Despiix <[email protected]> Date: Thu Nov 21 13:59:10 2024 +0000 Fix Progress Bar, Edit Release Note commit b05a99c526d8b231ddf5445542d0152decb4c7a6 Author: Despiix <[email protected]> Date: Tue Nov 12 16:38:56 2024 +0000 Add Algorithm Documentation Release Notes Add Description and remove redundant 0s [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit b65d0c21af78ccde5f100d289e9c1607c457a160 Author: Despiix <[email protected]> Date: Mon Nov 11 14:35:12 2024 +0000 Add progress bar commit 7b14fc219129d9a5754f90b7c6f694cca766e672 Author: Despiix <[email protected]> Date: Wed Nov 6 15:40:27 2024 +0000 Add 3 Unit tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Added 2 Unit tests to reproducability and out of bounds handling [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit d81ae1dea2e0331822bbc1d9cebd1213dc72dfd6 Author: Despiix <[email protected]> Date: Thu Oct 24 15:32:40 2024 +0100 Version 1 using Cumulative Distribution Function Clean up the codebase and break code into smaller functions. Remove auto and outputY from function Headers commit 44a9b19c5ae490bc25072629bde8672347ca2e59 Author: Despiix <[email protected]> Date: Tue Oct 22 13:13:36 2024 +0100 Added the Probability Density Function + Changed outputWS values Refactor: Clean up code and improve readability commit 878deade325fbccad9d75611afb1c3f7f3073711 Author: Despiix <[email protected]> Date: Tue Oct 22 10:53:05 2024 +0100 Functions to calculate the variance and the mean of the vector containing the random numbers generated. commit 3f28a59c5e4ebc4cf698f76c0180dddff14cb088 Author: Despiix <[email protected]> Date: Fri Oct 11 15:53:04 2024 +0100 Created Files and draft comments commit cba714b1d14a27548526a9951d032b50609d5776 Merge: 7cfebde659c 2da9fbc70f9 Author: Pete Peterson <[email protected]> Date: Thu Jan 30 10:16:18 2025 -0500 Merge pull request #38738 from rosswhitfield/fix_LoadErrorEventsNexus_zero_events Fix LoadErrorEventsNexus/PulseIndexer when there are zero events commit 2da9fbc70f9b671736c7cc6682e7d935558192e5 Author: Ross Whitfield <[email protected]> Date: Thu Jan 30 08:13:14 2025 +1100 Set bin edges for 0 event case commit bbfb41785527463109b971a34e701a5e227d2991 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 12:48:47 2025 +1100 Add release note commit 03ca40508ec99963024fc17d592bbf13bf7cf89e Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:10:22 2025 +1100 Fix BinEdges in LoadErrorEventsNexus commit 5391000735c2cbdb7d7bdef5385bdf53c52af28c Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:08:00 2025 +1100 Add test for LoadErrorEventsNexus with zero events commit 3c37a403db2474a10c82d77134162ecdbb9cc6c7 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:57:19 2025 +1100 Fix PulseIndexer commit 5e6300d09ba474f2161c748294ab787cb16cf2b2 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:56:58 2025 +1100 Add failing test for PulseIndexer when zero events commit 7cfebde659c329220386416ef2f9cccba3f222ec Merge: 15d8d2e5f43 0b75b791fcf Author: Pete Peterson <[email protected]> Date: Tue Jan 28 11:55:33 2025 -0500 Merge pull request #38698 from mantidproject/setMarkerStyle Fix setMarkerStyle commit 0b75b791fcf83afbcd061c8c3a10da75efd1be97 Author: Carson Sears <[email protected]> Date: Mon Jan 27 15:18:17 2025 -0600 remove boost function commit 15d8d2e5f4374610d09a57200efb5ff3e7c5880f Merge: 847424031ea c98c59798a3 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:35:26 2025 +0000 Merge pull request #38674 from mantidproject/38628_fix_mslice_nightly_version_bug Enable nightly standalone packages to install mslice nightly versions commit 847424031ea7303455b57747467987ea887731eb Author: Despi <[email protected]> Date: Mon Jan 27 10:23:57 2025 +0000 Surface Plotting from Multiple Single-Spectrum Workspaces (#38599) * Enable Plot All and Okay button * If any workspace contains only 1 spectra then set default value to 1. and minor file reformat * Fix plotting * Add release note * Adjust buttons to correct enable and disable + Adjust Test * Adjust function based on review * Remove Hardcoded "1" Set the default value as the first valid spectrum number * Fix plotting multiple wireframe workspaces * Clean up * Release Note Update * Enable `Plot_All` for Contour plots * Handle Error * Handle Error * If there is already a valid selection (wksp_indices or spectra), just ski * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Changes based on suggestions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete duplicate code * Delete duplicate code --------- Co-authored-by: James Clarke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> commit 727a603e421b4a00cfb8d6384b5e975028f91a8f Merge: ccfa649b1c6 ef97d87e12d Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:17:08 2025 +0000 Merge pull request #38683 from mantidproject/fix-argus-loading-crash Fix crash from loading into Muon Analysis interface commit ccfa649b1c60cd52a047fb8487e52ead4be868b8 Merge: c18ab182114 22b4ede51b6 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 07:45:07 2025 +0000 Merge pull request #38663 from mantidproject/38464_improve_zero_calibration_validation Add warning for zero-valued calibration spectra commit 67d26ca28db985b003c46db3f2d4111d84c73909 Author: Carson Sears <[email protected]> Date: Fri Jan 24 16:13:36 2025 -0600 fix setMarkerStyle commit c98c59798a372411fd39a5c3ce3a4f6779226f9c Author: Tom Hampson <[email protected]> Date: Wed Jan 22 17:57:04 2025 +0000 Enable nightly standalone packages to install mslice nightly versions commit 22b4ede51b68863717986dc8816c25411d044a4b Author: James Clarke <[email protected]> Date: Fri Jan 24 10:18:21 2025 +0000 Add link to release note commit ef97d87e12d95daee62597fffdcde2c0dfe7d079 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 23 17:36:28 2025 +0000 Check workspace is retrivable from ADS This simple change forces the ADS to check whether the workspace name i.e. load_result["DeadTimeTable"] actually exists. If it doesn't, it gives an error which is caught by the widget, instead of closing the widget and crashing mantid. Not an ideal solution, but a quick and simple one. commit c18ab18211482ca6329ae58ab0c231abd6871bc2 Merge: b78002e00aa 22837a332e7 Author: MialLewis <[email protected]> Date: Thu Jan 23 16:22:13 2025 +0000 Merge pull request #38669 from mantidproject/38654_launch_script_in_editor Skip first argument when calling main in launch script commit 22837a332e764371a326c42a276f35a9cd6c1eb1 Author: James Clarke <[email protected]> Date: Wed Jan 22 15:21:11 2025 +0000 Skip first argument when calling main The first argument of sys.argv is the launch script, so we don't need that. commit b7afa94cea34def4ab49b3530e0bee6799b9a24b Author: James Clarke <[email protected]> Date: Wed Jan 22 12:09:00 2025 +0000 Add test for calibration workspace with zeroes If the calibration workspace has zeroes, then we should get a warning with the correct workspace indices. commit 494b9d2479bd2b69b339f5c2642df46944986219 Author: James Clarke <[email protected]> Date: Wed Jan 22 11:37:05 2025 +0000 Detect zeroes in calibration workspace If the calibration workspace has zero-valued entries, then give the user a warning with the bad workspace indices. commit b78002e00aabc5f819c47e1950fa4f243d086052 Merge: 48117b6b26f 1d4a4e3fe6f Author: Silke Schomann <[email protected]> Date: Mon Jan 20 15:32:47 2025 +0000 Merge pull request #38605 from mantidproject/fix_save_ins Remove symmetry elements for SaveINS commit 1d4a4e3fe6f27a89c01b757c2770fd0d287d45e5 Author: Zachary Morgan (zgf) <[email protected]> Date: Mon Jan 20 08:20:51 2025 -0500 Using less ambiguous names commit 48117b6b26fd63a2cc119395aae966f61c3c9d8d Merge: 1541ebc0496 c155bd1b52a Author: James Clarke <[email protected]> Date: Mon Jan 20 09:49:09 2025 +0000 Merge pull request #38619 from mantidproject/fix_conjoin_workspaces_bug Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit 1541ebc0496f231c20c6ce73afc53bb14de14fbe Merge: f26fb41a3be e47801e3d4d Author: thomashampson <[email protected]> Date: Fri Jan 17 17:20:08 2025 +0000 Merge pull request #38611 from peterfpeterson/windows_suppress_warnings Change windows macro for warnings into compiler flags commit f26fb41a3be4dccf310a0781e4af8280e26e73af Merge: 61bccffbc5b d394998e401 Author: James Clarke <[email protected]> Date: Fri Jan 17 11:58:42 2025 +0000 Merge pull request #38616 from mantidproject/move_incorrectly_place_6_12_release_notes Relocate wrongly positioned v6.12.0 release notes commit c155bd1b52af32a3ebcf695fbcbffc2d54c85ff5 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:50:11 2025 +0000 Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit e63d5c8e507d63bef65d27b6f76623fc57aa5269 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:45:05 2025 +0000 Grammatical fix for warning messages commit b555a4f4b4033ff2cf611c5b3ab064accf667b6d Author: Tom Hampson <[email protected]> Date: Fri Jan 10 17:19:47 2025 +0000 Add ConjoinWorkspaces test to ensure it works for matching bins. commit 12516dfef44e242717a681f5f07c022fd22673d4 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:41:17 2025 -0500 Fix typo in comment commit af956a0209ae2721e4c6c47048afeb9da664e8b6 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:37:08 2025 -0500 Re-organize and comment commit aa64c8d5332d6db9301ca1a138e47daf035ee186 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:33:06 2025 -0500 Re-organize and comment commit a227a36c8aa67bc98525f3ecb9d63f744bf91ee9 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:25:32 2025 -0500 Re-organize and comment commit d394998e401273eb1ed50f69ba42f961f9f476b1 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 09:12:06 2025 +0000 Relocate wrongly positioned v6.12.0 release notes commit 61bccffbc5b428396fc86ce0aa19f5976dc3bf3d Merge: 703edc576c6 23abc08cb01 Author: Silke Schomann <[email protected]> Date: Thu Jan 16 18:20:37 2025 +0000 Merge pull request #38574 from mantidproject/36863-FindGlobalBMatrix-warnings 36863 find global b matrix warnings commit 80dd7f9c558834ae1b974ff858bedcc1b62fe8f7 Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 12:21:23 2025 -0500 Add new tests for SaveINS commit 9a1ddec8b27a54b5e22d59e6afba2e55584e085f Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 11:57:32 2025 -0500 Bias towards identity and origin commit 23abc08cb011d03e935a620a9c3043b3c7e500dd Author: Andy Bridger <[email protected]> Date: Thu Jan 16 16:31:15 2025 +0000 amend clarity of warnings when too few peaks commit 703edc576c6267755dd1b073da9a79f4bae25f9c Merge: 5ac51730b1a d916b2feeac Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:11:01 2025 +0000 Merge pull request #38459 from mantidproject/cppcheck_2_16 Update cppcheck to 2.16.0 commit 5ac51730b1ac2db044fa0d4adc2ab4ed5ea69d82 Merge: fc0059ccd0e a5937328c06 Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:04:32 2025 +0000 Merge pull request #38601 from jclarkeSTFC/38597_include_alg_profiler_all_os Include AlgoTimeRegister on all operating systems commit d916b2feeacaee79aa815ac4555a5da398ead71c Author: Tom Hampson <[email protected]> Date: Thu Jan 16 14:25:57 2025 +0000 Update cppcheck suppressions for v2.16.0 commit a5937328c06e538684a90d1485b69bf4b670775d Author: James Clarke <[email protected]> Date: Thu Jan 16 14:16:38 2025 +0000 Delete unused cpp file This file is no longer included in the build so should be deleted. commit fe6b26a7860e4ce91fd1cf07a56a7ce6ac138bf0 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 13:27:57 2025 +0000 Group internal cppcheck errors to extract them from the bounty list commit efe7ee752b1db7418f7197e9edc163c61a4ef249 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 11:11:03 2025 +0000 Sort cppcheck supressions by file name and line number commit 19678022dd9ee573b0441e16d20788a26d0cfef6 Author: Tom Hampson <[email protected]> Date: Tue Jan 7 14:44:00 2025 +0000 Restrict cppcheck to unix only. There is no 2.16.0 for Windows. We can re-add it for Windows in the future if it is reinstated. For the time being, since nobody is running it locally, we don't really need it to be installed on Windows. commit aa6475eef539100487046c38e93cee297f6ababd Author: Tom Hampson <[email protected]> Date: Thu Dec 5 10:46:20 2024 +0000 Suppress class_X_Y cppcheck warnings. commit 68568aed3397b834ed5dbd43897d2d19c682e176 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:40:06 2024 +0000 Update cppcheck to 2.16.0 commit 4a19b4f98c6350be94c435a9a5b5b2fec8f4e423 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:37:14 2024 +0000 Remove cppcheck suppressions temporarily for cppcheck update commit 41b6a779abb5ff7fa528198692caea172d569392 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:33:06 2024 +0000 fix typo to trigger cppcheck run commit fc0059ccd0ea26cef605008b8fb0c721bcb1701c Merge: 9e35ea46c48 45eeeac224a Author: thomashampson <[email protected]> Date: Thu Jan 16 14:06:38 2025 +0000 Merge pull request #38564 from mantidproject/38558_LoadNGEM_not_respecting_min_max_events Fix bug in LoadNGEM where Min/MaxEventsPerFrame were not respected commit 9e35ea46c48e0ec254491b48658ccd2e97f3f985 Merge: 99b307af65a 221dca92398 Author: thomashampson <[email protected]> Date: Thu Jan 16 12:54:18 2025 +0000 Merge pull request #38173 from mantidproject/35579_move_script_repo_install_location Fix crash after script repository install location is deleted / moved commit ceda6fc8d90eb60714697ec6b194124c01dc4ac0 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 12:33:11 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 413294e5c010af940867f2d3cb0d15c26e9fcebb Author: Andy Bridger <[email protected]> Date: Thu Jan 16 12:30:02 2025 +0000 replace in-place popping with new list appending commit 99b307af65a312aef290cd538059af1e530d508a Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 11:01:15 2025 +0000 [pre-commit.ci] pre-commit autoupdate (#38594) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.1](https://github.com/astral-sh/ruff-pre-commit/compare/v0.8.6...v0.9.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix whitespace that was already wrong * Remove additional whitespace found in local run of pre-commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pete Peterson <[email protected]> Co-authored-by: sf1919 <[email protected]> commit 45eeeac224a2318cacae3263f6384f521cb4e456 Author: Richard Waite <[email protected]> Date: Tue Jan 14 13:57:35 2025 +0000 Fix cpp check supression commit 6be0546cc8624c6da5bd3969575f6e2f8a7eaed0 Merge: 6c62fe37069 e744dffab96 Author: Andrei Savici <[email protected]> Date: Wed Jan 15 13:37:26 2025 -0500 Merge pull request #38591 from mantidproject/pychop_sns_update Update pychop definitions for SNS instruments commit 6c62fe37069e13d17255d8dedad3db3cb96ca7c4 Merge: 911eca1f711 4f567e74a33 Author: mantid-builder <[email protected]> Date: Wed Jan 15 18:32:20 2025 +0000 Merge ornl-next into main commit 911eca1f711b8ad84077ccd29c674dbca3549cc8 Merge: 4e656006570 e8ed4da6065 Author: Chen Zhang <[email protected]> Date: Wed Jan 15 11:13:43 2025 -0500 Merge pull request #38603 from rosswhitfield/disable_deprecated_qt_api Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 5f4ec8c8d4c3984e97ff49e28b7c9258e9db1bc9 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:59:05 2025 +0000 added check and test for make_ub_consistent commit 09bf7e3c8db8fe68b6e6c76c70f308f8ecb36a8b Author: James Clarke <[email protected]> Date: Wed Jan 15 15:55:50 2025 +0000 Handle base 16 thread ID numbers On macOS, the thread ID is given in hexadecimal, so when converting to an int we need to specify base 16. In other cases we use the default of base 10. commit 4e65600657018125751c6bf293557ba6e096c2aa Author: yusufjimoh <[email protected]> Date: Wed Jan 15 15:31:25 2025 +0000 Refactor WildesTest to reduce Code Duplication (#38529) * created helper functions to reduce code duplications in PolarizationCorrectionWildestest * refactor methods with spinstates, added more helper methods to reduce code duplication * removed helper methods from namespace to class as private methods in PolarizationCorrectionWildesTest * - refactor and improve tests based on suggestions from code review * improve tests based on suggestions from code review * change global constants case to Uppercase --------- Co-authored-by: Oluwaseun Jimoh <[email protected]> commit f499feaf9a1014d72bae69f4eacc8c4ec1f097ad Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 10:24:38 2025 -0500 Bias toward right-handed systems commit 7a9e55c9da998f406689297e20361a6119e85063 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:17:37 2025 +0000 added check and test for num_ws indexed by ref_ub commit 9884255ac99ee04ef4bde3463674d26657e7a3d3 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 14:57:12 2025 +0000 Rework Abins docs: input data formats info split out to another page (#38588) * Rework Abins docs: input data formats info split out to another page * Update changelog * Remove spurious "Title" from table RST * Fix AbinsDataFormats table header; drop spaces from label Even without spaces in the label, I am having trouble getting the new file to appear in the concepts index. * Add concepts category to new docs file; add local contents This category seems to be required for the new page to show up in concepts index. Also add a little contents section to the top of the file. commit 30baff0e4fd42d085261195245079ddb48dfbd68 Author: Michael Walsh <[email protected]> Date: Wed Jan 15 09:29:09 2025 -0500 added and propagated FullBinsOnly flag (#38550) * added and propagated FullBinsOnly flag * added a release note * added tests for ragged and non ragged workspace paths in rebin ragged for fullbinsonly * add missing - for release note * added doc reference to rebinragged page for a better explanation of FullBinsOnly * added an additional code sample explaining the new param * spellcheck commit b9697cf9a6db16d0658bb76eb95c2e62970b9fa3 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:03:21 2025 -0500 Add indentity back commit 72ffabb4b956c892c7c05de978b2b9df5bc0a5ca Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:00:40 2025 -0500 Move release note commit eb814b06cfe2ceaaa72b0cbd15ce563b8f895133 Merge: 864d61e6642 7dafe330062 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 13:59:26 2025 +0000 Merge pull request #38606 from ajjackson/abins-cache-error Detect unwriteable Abins cache, raise better error commit 0dc1b9be73febf0cc615c0a9c0a5a9e530b287fb Author: James Clarke <[email protected]> Date: Wed Jan 15 12:16:44 2025 +0000 Fixes for AlgoTimeRegister on Windows A long on Windows x64 is 4 bytes, but on Linux it is 8 bytes. To hold nanoseconds we need 8 bytes. By using size_t we'll get an 8 bytes integer. File system handling is different on Windows. So in the test, make the file in the class set up, close it, then open it to write when required. commit 3f6b975218f2522c0be4831427d2d32d9dc58718 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:13:41 2025 -0500 A/B/C-centering commit 127ad8a562b1d6a342d3a96cf3276e2faf2a6ded Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:10:07 2025 -0500 C-centering commit 1b50fe7425c53c43ece4dbc0ec1d2ad9596f50ac Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:53:04 2025 -0500 Fix typo commit 88b7bc246b91023a1378797abde3a6f0a89dbb73 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:48:47 2025 -0500 Adding release doc commit 076e038c7d70c1c2f1730456231a5bc337058363 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:43:33 2025 -0500 Comment code commit 80a7c636be4b258f49ebe18bba029f7a7d603e19 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:42:15 2025 +0000 improved readability of find_initial_indexing commit 703a22c9bd70ec422cc08518d0d9cb9a0af4a939 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:36:46 2025 -0500 Forgot primitive commit a5168730d0896c2c6b58f5b066dc95e9951b04c4 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:32:52 2025 +0000 collapse removal warning into one message commit c98ff406e5c64c03df431f57da4cbad3a357b326 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:30:52 2025 +0000 made final treatment of refUB into one loop commit 7dafe3300628314fef70e339c7dadca5d28ec9b5 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 11:14:24 2025 +0000 Correct type annotation Sadly the code here is not using Pathlib yet. Hopefully that will change soon! commit c790f5753015722929335434430ea2fa94726601 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:08:55 2025 +0000 moved SetUB call to exec_child_alg commit e5a7d5aaa24f6507972340812876f4bb91d515ae Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:05:19 2025 +0000 removed redundant IndexPeaks call commit 76d314b405042b0d59c2896face02c6fdfb1be56 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:03:23 2025 +0000 reduced num repeated loops and calcs commit 7b21c2b693c977d4000ed028b8c27af81138395b Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:40:40 2025 +0000 Add release note commit 864d61e6642f7ac8b3c1556b4b2eb9a94268376d Author: andy-bridger <[email protected]> Date: Wed Jan 15 10:35:50 2025 +0000 37795 change polaris pdf norm (#38535) * Updated vanadium norm dict as per issue #37795 Some extra changes will be needed as this norm_dict doesn't seem to be called properly * Removed hard-coded vanadium normalisation method * Added test support for pdf_norm options #37795 Updated the enum to recognise the option and updated the tests so "Relative" is no longer hard coded - added an extra test some corresponding files * Updated Test files for pdf_norm inclusion #37795 * moved repeated validation code to helper * improved run_focus_absorption readability * Add release notes * Updated the Polaris Docs commit 30035cc43ee870ee42ac4f9b3571feb21fceced8 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:19:23 2025 +0000 Detect unwriteable Abins cache, raise better error commit 820aecc4300a286e4b67df35845f0696d9b90efe Author: Andy Bridger <[email protected]> Date: Wed Jan 15 09:35:52 2025 +0000 updated validateInputs and its tests commit d4750d9749499253238372702ffa3ab0cf394d9b Merge: e4575ed635f f281969b387 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 08:31:32 2025 +0000 Merge pull request #38515 from mantidproject/38439_use_MD_fitting_IntegratePeaks1DProfile Use MultiDomainFunction in IntegratePeaks1DProfile commit d217e7a78af4e1332e2af1544689855f0d564210 Author: Zachary Morgan (zgf) <[email protected]> Date: Tue Jan 14 22:32:23 2025 -0500 Remove symmetry elements commit e744dffab96530ce3c8b5c099d6a6a4998b769f7 Author: Duc Le <[email protected]> Date: Tue Jan 14 23:15:26 2025 +0000 PyChop-SNS: Fix bug wrong freq for aperture width commit e8ed4da6065dce8a9da37b245babe7f3bc33343e Author: Ross Whitfield <[email protected]> Date: Wed Jan 15 11:14:39 2025 +1100 Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 03ac026aa3159375611e098388131da2cbd718df Author: Duc Le <[email protected]> Date: Tue Jan 14 17:41:36 2025 +0000 PyChop-SNS: correct Ikeda-Carpenter eqn in yaml commit 9670e52487e6e7cd0d6d940ef6582cf603f91e16 Author: Duc Le <[email protected]> Date: Tue Jan 14 17:35:55 2025 +0000 PyChop-SNS: Add flux units to GUI and yaml commit a54e44633730187dae6ae80aa17fbb816d59c31f Author: James Clarke <[email protected]> Date: Tue Jan 14 15:38:02 2025 +0000 Include AlgoTimeRegister on all operating systems By only including it on Linux, we need to either edit the docs to only have examples that only work on Linux, or selectively include the doc page for that class. It doesn't do any harm to use AlgoTimeRegister on other operating systems, then the tests can be run on all OS's, and things are a bit neater. commit e4575ed635f1d0ecbb5b228719d8372ffe7569fc Author: Silke Schomann <[email protected]> Date: Tue Jan 14 14:16:14 2025 +0000 Added release notes for MSlice (#38596) commit 221dca923988aab04ba6fba17a9863655c9414a4 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 14 13:59:55 2025 +0000 fix cppcheck return by const ref commit bdd6f43b0fcf4937d4bbff80938a390c9b6b74e6 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 7 13:36:26 2025 +0000 remove now unneeded changes commit 51586ce2ff7bfaff024abac18ce7418ce46233cf Author: Duc Le <[email protected]> Date: Tue Jan 14 01:32:04 2025 +0000 PyChop-SNS: Add docs. Got agreement with rez.mcvine.ornl.gov commit a9fe5cd18be2a40c60e27eec2f9f41fbadb27f19 Merge: 658472146df b66e3b3e135 Author: mantid-builder <[email protected]> Date: Tue Jan 14 00:20:43 2025 +0000 Merge ornl-next into main commit 658472146dfaf92e9a546e31da800f32241d3203 Merge: c7f74ccbf28 462310bf6ef Author: Pete Peterson <[email protected]> Date: Mon Jan 13 11:58:19 2025 -0500 Merge pull request #38580 from mantidproject/restore-lost-legend Restore lost legend when dragged out of figure commit c7f74ccbf2830cb9ac42a41cb9a5cc1e1d829329 Merge: 61bf054b0c8 423a2454f0b Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:53:58 2025 +0000 Merge pull request #38567 from mantidproject/38560_instance_true_for_create_autospec Add instance=True to mock.create_autospec for speed improvement commit 61bf054b0c8d9315d627cf454f3f732796197bcd Merge: 6ee0b15d7d5 f5cc1c8afbb Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:32:45 2025 +0000 Merge pull request #38582 from mantidproject/refactor_Save_NXcanSAS Refactor SaveNXcanSAS algorithm to support different variants commit 423a2454f0b667fa6bb90835c61a162e1f9b6f79 Author: Jonathan Haigh <[email protected]> Date: Mon Jan 13 15:25:12 2025 +0000 fix typo Co-authored-by: James Clarke <[email protected]> commit 794f130bf20ab7ba98d67ae2799b7c87cdaff920 Author: Duc Le <[email protected]> Date: Mon Jan 13 14:03:41 2025 +0000 Update pychop definitions for SNS instruments commit 6ee0b15d7d58be39fc02daf7c8d01a9f384471de Merge: e9176f323bd 3bc0c167126 Author: mantid-builder <[email protected]> Date: Mon Jan 13 13:52:34 2025 +0000 Merge ornl-next into main commit e9176f323bd7303e1b9b16e4d1d70922b02d0f04 Merge: a411fec9bb7 ac355057671 Author: Silke Schomann <[email protected]> Date: Mon Jan 13 07:26:03 2025 +0000 Merge pull request #38587 from rosswhitfield/sliceviewer_allow_custom_colormaps Allow users to register custom matplotlib colormaps commit a411fec9bb779acef8e7d27a4f7295d1405bb3e5 Merge: f579a71c7af 9c6d1b1a057 Author: Andrei Savici <[email protected]> Date: Fri Jan 10 14:50:41 2025 -0500 Merge pull request #38584 from peterfpeterson/38332_nexus_sorted_includes Remove clang-format suppressions commit f579a71c7afdeb67761dde29db2a9a0f2e6e6a14 Merge: be2990a7429 2a4279ce2fd Author: mantid-builder <[email protected]> Date: Fri Jan 10 15:21:48 2025 +0000 Merge ornl-next into main commit 7e1b17f89e491c1c0a9d7934cff1be4e159ef51a Author: Tom Hampson <[email protected]> Date: Fri Jan 10 14:41:31 2025 +0000 Update misleading function documentation. The function does not compare sizes of workspaces, so the comment was wrong. commit be2990a7429ab61fa821a248d0dfcf28bc70dd25 Merge: f81538d597c 6fb8ac3731d Author: Silke Schomann <[email protected]> Date: Fri Jan 10 14:10:20 2025 +0000 Merge pull request #38581 from rbauststfc/add_exception_to_SANS_move_test Add exception to SANS move test helper method commit 517eecff220802fc649b5aa9387216e14210a56c Author: Tom Hampson <[email protected]> Date: Fri Jan 10 12:18:42 2025 +0000 Remove old commend It doesn't make any sense and just confused me commit 462310bf6ef95f568ae8661450f035074e5fb8f8 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 10 12:16:12 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 5e961cb44831746d9b612553b118bde3f49d52ae Author: Despi <[email protected]> Date: Fri Jan 10 12:13:53 2025 +0000 Update qt/applications/workbench/workbench/plotting/figureinteraction.py Co-authored-by: Jonathan Haigh <[email protected]> commit f81538d597c2dbc8e2e87a74b918235596262835 Merge: 8c287822338 b767628baf4 Author: thomashampson <[email protected]> Date: Fri Jan 10 11:54:51 2025 +0000 Merge pull request #38513 from mantidproject/update_mslice_manual_test_docs Added section for testing ADS interactions to MSlice manual testing doc commit 16790c7fc1965700c18ed7ea0a755a96c799423c Author: Despiix <[email protected]> Date: Fri Jan 10 11:54:18 2025 +0000 Changes based on review commends commit b767628baf440e22bc12eff1304e3f7089a2e889 Author: thomashampson <[email protected]> Date: Fri Jan 10 10:44:42 2025 +0000 fix grammatical error in docs commit 8c28782233867eea94a225ceb1711899e737a787 Merge: 52d7654ed8a b22c536545f Author: thomashampson <[email protected]> Date: Fri Jan 10 10:41:16 2025 +0000 Merge pull request #38583 from mantidproject/napi5_systemtest_bug Ensure variable is initialised in Nexus code commit f5cc1c8afbba68e923f8be5f4ee64e73395f2fe9 Author: adriazalvarez <[email protected]> Date: Fri Jan 10 09:59:52 2025 +0000 Update header date on new file commit f9618ec588879e933e51103b37cf08968080cb19 Author: Despiix <[email protected]> Date: Fri Jan 10 09:21:06 2025 +0000 Fix failing text commit 52d7654ed8a67a2e7afa7b25dbee764c58d82e21 Merge: 65ebaa6ff4c 0610193cb85 Author: Silke Schomann <[email protected]> Date: Fri Jan 10 07:51:30 2025 +0000 Merge pull request #38538 from peterfpeterson/cc_gdo_docs CrossCorrelate and GetDetectorOffset algorithm user docs commit 65ebaa6ff4c5dc387654632f9f8fe316f3553618 Merge: df70d89339a 0453e5e0c01 Author: mantid-builder <[email protected]> Date: Fri Jan 10 01:03:57 2025 +0000 Merge ornl-next into main commit df70d89339a6c7d83d02f7537a6611800dff47a1 Merge: 3163798c8ad 0ac1c789a2f Author: mantid-builder <[email protected]> Date: Thu Jan 9 21:07:57 2025 +0000 Merge ornl-next into main commit 5b5fca5f0914c78ac9e2b0a90a6a9bc993dd2577 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 19:17:17 2025 +0000 Fix doxygen documentation warnings: 1. There were doxygen lines in add2DData function that needed to be escaped with \. to avoid a warning, this was not detected before as doxygen does not look in anonymous namespaces for mantid. 2. There was a doxygen comment missing input parameters to the function addInstrument. commit 3163798c8ad38aeeadedbe2be1f17fe2c31cfda3 Merge: 0681ab27e44 f7982b0abf7 Author: Chen Zhang <[email protected]> Date: Thu Jan 9 13:26:05 2025 -0500 Merge pull request #38565 from peterfpeterson/gtest_pin Clarify that gtest is pinned to v1.15.2 commit 0681ab27e4467c580b795fe7f33d5ad5b0bd3e78 Merge: 17ee6bbae9e 2e7242e878f Author: Pete Peterson <[email protected]> Date: Thu Jan 9 13:22:48 2025 -0500 Merge pull request #38486 from mantidproject/mantidaxes_lines_and_renameworkspace_exception account for lines sharing graphs with workspaces in mantidaxes commit b22c536545f3ecb35434d1c4bad219ed6e1cc13c Author: Andy Bridger <[email protected]> Date: Thu Jan 9 17:48:41 2025 +0000 initialise herr_t iRet to 0 commit 38fef13bbb34923f50b77e8b8aa82b99e6c079dd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:31:43 2025 +0000 Fix cppcheck style warning: commit e98b1be5a4dd1df439566fc8594a99fdc4552dbd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:20:15 2025 +0000 Fix typo in include path on cmakelist commit 17ee6bbae9e31d7e22ee835eeb7b0ad91bc00d2c Merge: 27b1a2c3403 bc7e058e29e Author: mantid-builder <[email protected]> Date: Thu Jan 9 15:11:07 2025 +0000 Merge ornl-next into main commit 6fb8ac3731d8c97205f3c3b59d8b7f00ec528fb1 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 14:50:05 2025 +0000 Add exception for unsupported instrument name commit 1d260bf0ebc31e8baa0d503d0b03ab3692188d85 Author: Despiix <[email protected]> Date: Thu Jan 9 14:57:21 2025 +0000 Add release note commit 27b1a2c340372b263256ee5cdb06c0f71d273722 Merge: 77d31880c71 9631fe5c07f Author: Silke Schomann <[email protected]> Date: Thu Jan 9 14:34:47 2025 +0000 Merge pull request #38577 from rbauststfc/fix_SANS_ZOOM_move_test Fix SANS move test failure commit 2d9634ea417de56d166807fbdf17ad6cb98c4aff Author: Despiix <[email protected]> Date: Thu Jan 9 14:24:35 2025 +0000 Add Function that solves issue It compares the size of the figure with the coordinates of the legend to see if it's out of range and if it is it snaps it back to its default position. commit 52b5e3ac712fe25760a20e2a841047a8d4861acc Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:18:25 2025 +0000 Organize code, add some descriptions and refactor some individual lines commit c8898d09d9b2eb517b9692d75f777f26756cbd83 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:17:36 2025 +0000 Referene to helper file in tests commit 868a9f434079ec21770d3ed5f52d555a73041764 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:16:51 2025 +0000 Add file for NXcanSAS helper functions commit ea9bb892835eeac840e706955ad8968dcd882eee Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:03:37 2025 +0000 Add parent SaveNXcanSasBase class with helper functionsin anonymous namespace commit d39fdf9d9dd439d95a6629a2d7aea2b0a2105f9f Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:02:18 2025 +0000 Remove helper and main exec structure out of inherited saveNXCanSass, inherit from saveNXcanSASBase commit 9631fe5c07fed8404cfb058cd39567dcd46d6d87 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 10:44:53 2025 +0000 Specify version of IDF to use in SANS move tests commit 77d31880c71e715424c8679bd47a196b51eb61b2 Merge: e6d3e6f33f8 94614aa94dd Author: Silke Schomann <[email protected]> Date: Thu Jan 9 10:16:10 2025 +0000 Merge pull request #38573 from peterfpeterson/38457_generate_export_header Remove includes of MantidKernel/System.h commit e6d3e6f33f8da9bc6a95035df1e7386a04dde479 Merge: beadc9d8abf 9cbc06067b0 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:49:11 2025 +0000 Merge pull request #38197 from mantidproject/38102_view_not_to_call_presenter_methods_directly Remove direct calls to presenter from cut viewer view commit beadc9d8abfab95aedc7acd498714126597d3eda Merge: 8eab7f131fe 8981bece2c2 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:33:13 2025 +0000 Merge pull request #38514 from mantidproject/38030_remove_pop_up Remove off-putting error prompt that appears when canceling a MaxEnt calculation in the Muon FDA interface commit 8eab7f131fe76f1e3e3f951b530811df8561784c Author: Waruna Priyankara J A Wickramasingha <[email protected]> Date: Thu Jan 9 09:16:24 2025 +0000 38254 add PeakShapeDetectorbin to integration algorithms (#38452) * Unit tests added for equal opeartor in python and c++ * early return added and cppcheck fix * reverted exposing opearator== into python for consistency * PeakShapeDetectorBin added to IntegratePeaksSkew * PeakShapeDetectorBin added to IntegratePeaksShoeboxTOF * PeakShapeDetectorBin added to IntegratePeaksSkew * null check added for ipos data * updated for review comments. Q plottting yet to do * Unit tests added * integratepeaksshoebox xlimits and det ids updated * release note updated * updated note commit 24dcde322389df921a863df4a403ea9f99de6fd9 Author: Mohammed Almakki <[email protected]> Date: Thu Jan 9 09:15:20 2025 +0000 Add table view for group peak workspace (#37166) * Add group peak workspaces model * Add show data to group peak workspaces * Add group presenter and table model * Add support for sorting, deleting, plotting, stats, and batch loading * Add group model unit tests * Add group table model unit tests * Add group presenter unit tests * Add release note commit 67ac3fe1e9538f7ccaa67ebd93a391116de5ad6b Merge: 5a0bafe803e 73c368c4920 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 07:54:51 2025 +0000 Merge pull request #38556 from rosswhitfield/fix_sliceviewer_data_exception Fix invalid data when MDHistoworkspace replaced and has original workspace commit 2e7242e878fe6435d1b805bd9b45649fb64dd994 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 15:17:57 2024 -0500 fix failing test file commit 159b14c40e8338f52d54b1e116b732914c4fa40c Author: Michael Walsh <[email protected]> Date: Fri Dec 6 14:18:48 2024 -0500 added release note commit 61f78e2bb22c0703f3477376714a4d1aee2e3a18 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 13:18:48 2024 -0500 account for lines sharing graphs with workspaces in mantidaxes commit 5a0bafe803e9ef7816d59f957d33ff0457f48a54 Merge: 754148a9b75 ff47bef4556 Author: mantid-builder <[email protected]> Date: Wed Jan 8 20:19:19 2025 +0000 Merge ornl-next into main commit 754148a9b752f31d24401d2d3525e4892d377c4e Merge: 17a7a926a45 00d26587feb Author: mantid-builder <man…
commit a8f64cccc781eac9892433e956bab7104ebf1213 Merge: dee818e0edc d9e270e4d39 Author: Jose Borreguero <[email protected]> Date: Mon Feb 24 14:30:49 2025 -0500 Merge pull request #38956 from mantidproject/revert_crosshair Revert added crosshair option in mantid commit d9e270e4d39fcc4c087c1a5d8f2396ecb01d3463 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:20:40 2025 -0500 typo fix in release note commit 73466fb3dfb41fd259f3fae612b42df6245df88e Author: Kyle Ma <[email protected]> Date: Mon Feb 24 11:19:38 2025 -0500 remove crosshair in release note commit b6bd2da2e74e421eb93f2fd5c4cdbe376bfc8dfa Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:43:55 2025 -0500 Revert "added tests and release documentation" This reverts commit 1b9820c0daf8ec786a60229f9c626b9104d7fcea. commit fbf1403fbed617c9cffc80934490de2797558571 Author: Kyle Ma <[email protected]> Date: Mon Feb 24 10:41:57 2025 -0500 Revert "added crosshair option similar to matplotlib" This reverts commit f7d9c30f1729aead046d2000580706b04c3d16b1. commit dee818e0edc37d153b32d3535a38fef1e5f2e708 Merge: 1d016f6c14e 36b5c9e8f46 Author: thomashampson <[email protected]> Date: Fri Feb 21 16:37:23 2025 +0000 Merge pull request #38904 from mantidproject/fix_conda_install Only set XKB_CONFIG_ROOT for standalone installs & set GSETTINGS_SCHEMA_DEFINITIONS properly on conda installs commit 1d016f6c14e4d04689cd4fe00e6248042e049dba Author: thomashampson <[email protected]> Date: Fri Feb 21 16:12:52 2025 +0000 Finalise v6.12.0 release notes. (#38946) * Add missing workbench release note. * Update manage user directories screenshot The new screen shot is up to date with v6.12.0. The release note describing the Move to Top button links to this image, so it needed updating to avoid confusion. * Remove all used release notes. * Index page for v6.12.0 release notes. * reword algorithm profiler release note * codespell found typos in v6.12.0 release notes * small tweaks to 6.12 release notes after review commit 36b5c9e8f4656f677232706cd2e383a7df6ddbb8 Author: Jonathan Haigh <[email protected]> Date: Fri Feb 21 10:35:50 2025 +0000 set GSETTINGS_SCHEMA_DEFINITIONS using CONDA_PREFIX on conda install commit 56f61efdf9ca71ef6b64c17c4b9bee8748b462db Merge: a067d8aa008 f66f41310e0 Author: thomashampson <[email protected]> Date: Thu Feb 20 18:15:08 2025 +0000 Merge pull request #38910 from mantidproject/update_SANS_release_notes Update SANS release note commit f66f41310e0cf54239e0691d8ae7e06ee96bcf8c Author: MialLewis <[email protected]> Date: Thu Feb 20 16:20:55 2025 +0000 update sans release note commit 37a3a810a9d83118a18cf99524a0c9b90fc70c5c Author: Jonathan Haigh <[email protected]> Date: Thu Feb 20 13:39:00 2025 +0000 Only set XKB_CONFIG_ROOT for standalone installs Co-authored-by: thomashampson <[email protected]> commit a067d8aa008c3e2acf3afcf4b6dc9e30cabe4a48 Merge: f91402014e8 a73ea0aa19c Author: Silke Schomann <[email protected]> Date: Wed Feb 19 18:14:17 2025 +0000 Merge pull request #38891 from mantidproject/release-notes-6-12-workbench Release notes v6.12.0 - workbench commit a73ea0aa19c6213742105f4cc5c72c90c60e7a77 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 17:01:08 2025 +0000 Second edit of v6.12 workbench release notes after review. commit f91402014e82463d29aacd596641dfd2924fb0dc Merge: 4654d0aa8e1 45a851f5592 Author: Silke Schomann <[email protected]> Date: Wed Feb 19 13:49:45 2025 +0000 Merge pull request #38851 from mantidproject/release-notes-6-12-framework Release notes v6.12.0 - Framework commit 4654d0aa8e115d7e93ea243a9de2012d19ed2a6d Merge: 18fa2f03c3a 967d1313c60 Author: Pete Peterson <[email protected]> Date: Wed Feb 19 08:19:59 2025 -0500 Merge pull request #38845 from mantidproject/38826_extend_load_muon_nexus_for_hdf5 Add a new revision to LoadMuonNexus to reenable alg selection commit 45a851f5592444dcd00009a9d82a28551d385452 Author: Tom Hampson <[email protected]> Date: Wed Feb 19 12:00:55 2025 +0000 Fix link inside bold text rst formatting for numpy link commit ea2778be8cb0421df31a8a8288e8336a7c34b623 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 17:07:48 2025 +0000 Edit v6.12.0 release notes. commit b33542870aea9a59fd145dca497f99a72feaa80d Author: thomashampson <[email protected]> Date: Wed Feb 19 09:31:41 2025 +0000 Second edit of v6.12.0 release notes after code review Co-authored-by: Jonathan Haigh <[email protected]> commit 967d1313c608afd676c926e5505ce79db089a6e6 Author: MialLewis <[email protected]> Date: Tue Feb 18 23:18:36 2025 +0000 fix non-windows compiler warnings commit f71a3ee71b1392df2a4a1a8507b4c000ae0bf546 Author: MialLewis <[email protected]> Date: Tue Feb 18 17:21:28 2025 +0000 add guard if alg not registered commit d2a21d2a423674682547a680041badf48e044dda Author: MialLewis <[email protected]> Date: Tue Feb 18 17:01:26 2025 +0000 remove unneeded imports and code commit b2c60d0dd79aa35c93151b6422cf225d1339fcd6 Author: MialLewis <[email protected]> Date: Tue Feb 18 16:46:26 2025 +0000 remove datahandling dependency from muon package commit 18fa2f03c3a88fa76a244e9fa65762f23a77d733 Merge: 383a45cdc54 4f2da3c5922 Author: Caila Finn <[email protected]> Date: Tue Feb 18 11:11:14 2025 +0000 Merge pull request #38876 from mantidproject/pin_libopenblas_0_3_27 Pin `libopenblas` to known working version commit bc5dd0bad800f8ef61aae05ef8bbb8df50d6094a Author: Tom Hampson <[email protected]> Date: Fri Feb 7 14:18:51 2025 +0000 Amalgamate v6.12.0 release notes for workbench commit 4f2da3c592229d8b392943557941cda03baee508 Author: Tom Hampson <[email protected]> Date: Tue Feb 18 09:06:26 2025 +0000 Pin libopenblas to known working version Otherwise unit tests fail. commit 383a45cdc548b3b2a7531fff6958ea8d7fb45aaf Merge: 47d86fef15c 66d67ce7454 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 19:41:52 2025 +0000 Merge pull request #38868 from mantidproject/update_mslice_version_number Update MSlice version number from 2.10.1 to 2.11.0 commit 47d86fef15c00aae9132b220fdf84a98fed1462d Merge: 6271c251822 22ba6a63ec7 Author: Andrei Savici <[email protected]> Date: Mon Feb 17 13:56:31 2025 -0500 Merge pull request #38867 from mantidproject/bugfixSmoothNeighbours Fix performance issue with SmoothNeighbours commit 66d67ce745416fbae694e39c986b749b195733f2 Author: Silke Schomann <[email protected]> Date: Mon Feb 17 15:55:54 2025 +0000 Update MSlice version number from 2.10.1 to 2.11.0 commit 22ba6a63ec74c5bdb9291d627f5da22518c8e88c Author: Carson Sears <[email protected]> Date: Mon Feb 17 08:37:05 2025 -0600 Fix performance issue with SmoothNeighbours commit 9370aed4e1560b53e2340fb5f7cc19d9911bc512 Author: MialLewis <[email protected]> Date: Mon Feb 17 09:51:34 2025 +0000 change Load to LoadMuonNexus in examples commit 6271c251822d22a5f3e569a44def0ccfa43881be Merge: 645714fad40 769f601a639 Author: James Clarke <[email protected]> Date: Fri Feb 14 16:48:17 2025 +0000 Merge pull request #38853 from mantidproject/fix_mac_standalone_packaging Fix macOS standalone packaging commit 769f601a639cdd2a35ed0438d390b68ef4756968 Author: Tom Hampson <[email protected]> Date: Fri Feb 14 16:37:01 2025 +0000 Check for directory before moving to avoid macOS error commit 69ed9f8cdceff9bae041652e0df95d45ec767e26 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 17:18:29 2025 +0000 Edit framework v6.12.0 release notes commit 645714fad4041c2d10d5e1cdc1e56df48a4a9ab5 Merge: b47d26b293c bd43e3a7b36 Author: James Clarke <[email protected]> Date: Fri Feb 14 15:08:16 2025 +0000 Merge pull request #38836 from mantidproject/release-notes-6-12-indirect-and-inelastic Release notes v6.12.0 - indirect and inelastic commit bd43e3a7b3631ee8420063862302c2457bcd6148 Author: thomashampson <[email protected]> Date: Fri Feb 14 14:06:58 2025 +0000 Use correct syntax for italic in release note Co-authored-by: James Clarke <[email protected]> commit c515c81f63e41e972c8bec532ef1219a9b10c126 Author: MialLewis <[email protected]> Date: Fri Feb 14 12:38:55 2025 +0000 ammend release note commit d6f6677d560b327672e1dd587b83bd83b4ecff3a Author: MialLewis <[email protected]> Date: Fri Feb 14 12:32:38 2025 +0000 change variable order commit a2cdd96c545b36036020be6c3be2d29ebdd2e3c1 Author: MialLewis <[email protected]> Date: Fri Feb 14 10:58:30 2025 +0000 fix compiler warnings and add doc commit b37e32ae412f9b616125a6c258f5713238e3530b Author: MialLewis <[email protected]> Date: Fri Feb 14 09:40:58 2025 +0000 remove redundant const return commit cbc967df8aedd676486f070fcda89d966f994076 Author: MialLewis <[email protected]> Date: Fri Feb 14 09:38:40 2025 +0000 small code improvements commit e4e283cdc7ea064c00d1cb320cd6edac403b11f7 Author: MialLewis <[email protected]> Date: Thu Feb 13 21:56:53 2025 +0000 resolve spurious cppcheck warning commit 817205d20fcbf5f21b94eefda1d084dc3c8acaed Author: MialLewis <[email protected]> Date: Thu Feb 13 19:38:29 2025 +0000 add unit tests for LoadMuonNexus3 wrapper commit 9cb6800a89c1298a702cb27b88a95c3fbec4b753 Author: MialLewis <[email protected]> Date: Thu Feb 13 17:07:09 2025 +0000 add LoadMuonNexus3 commit b47d26b293c2296d004e2aa99f786fe5e7d1499b Merge: 29e25ba3591 116508b5a62 Author: James Clarke <[email protected]> Date: Fri Feb 14 12:26:23 2025 +0000 Merge pull request #38831 from mantidproject/release-notes-6-12-relf_and_sans Release notes v6.12.0 - Reflectometry and SANS commit dd026d9fb4cdbc2b102759f94df7a1ddd49dce68 Author: thomashampson <[email protected]> Date: Fri Feb 14 11:51:51 2025 +0000 Fix grammar, spellin and doc link from code review Co-authored-by: Silke Schomann <[email protected]> commit 29e25ba3591a6bbc994698ecf3aca1964b157eec Merge: 5fc503f1c1c 19f2640e947 Author: James Clarke <[email protected]> Date: Fri Feb 14 11:32:44 2025 +0000 Merge pull request #38835 from mantidproject/release-notes-6-12-direct-geometry Release notes v6.12.0 - direct geometry commit 116508b5a627dbbaf9f9816bc51ec6b57c9387af Author: Tom Hampson <[email protected]> Date: Fri Feb 14 10:32:42 2025 +0000 Reference correct refl algorithm in release notes commit 5fc503f1c1cfc43733be950aae97b52514a92430 Merge: 92e3db4930e b0d94025d59 Author: James Clarke <[email protected]> Date: Thu Feb 13 15:43:06 2025 +0000 Merge pull request #38819 from mantidproject/38797_linux_standalone_fix Fix Linux standalone package for Ubuntu commit 632caa8618586637819ef919e9faed0d9f616029 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:28:14 2025 +0000 Edit v6.12.0 indirect gemoetry release notes. commit cdaa1230055a4b3a93e1bfefa6af2537761efa2e Author: Tom Hampson <[email protected]> Date: Thu Feb 13 13:27:35 2025 +0000 Edit v6.12.0 inelastic release notes. commit d318d516859e1ad1b3225574cc49f7f295a9597f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:55:23 2025 +0000 Amalgamate v6.12.0 release notes for indirect and inelastic commit 7c8ba60e08ef4c1dab7ff4287568ab45b16d7486 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 11:27:30 2025 +0000 Amalgamate framework release notes for 6.12.0 commit 19f2640e9473ec5abd9a4088b39d819dcba2c1c4 Author: Tom Hampson <[email protected]> Date: Thu Feb 13 10:23:11 2025 +0000 Edit direct_geometry v6.12.0 release notes. commit 92e3db4930ead6be5a4913342bbb49862b0dc73f Merge: aab27b7bd4f 696363b2e6c Author: James Clarke <[email protected]> Date: Thu Feb 13 09:59:46 2025 +0000 Merge pull request #38829 from mantidproject/release-notes-6-12-muon Release notes v6.12.0 - Muon commit 2d6108cde6abee94a7367abe01f30b37b981b377 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 16:41:20 2025 +0000 Amalgamate 6.12.0 direct geometry release notes commit b0d94025d598399eeec2fd8703c0750c39e1a68f Author: Tom Hampson <[email protected]> Date: Wed Feb 12 09:19:59 2025 +0000 Remove unrequired workbench script from Linux standalone tarball. commit 1ae0d363a67188fd9af78b161551f88791c9d219 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:04:52 2025 +0000 Added release notes commit 032820d38351589cfaa65d3a894bce33c00851c6 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 17:01:00 2025 +0000 Rename linux tarball launcher script to mantidworkbench. This maintains the behaviour so that it's consistent with previous releases. commit 861bbdbe417dac2b5e21de93f493d09ba4698507 Author: Tom Hampson <[email protected]> Date: Tue Feb 11 14:55:18 2025 +0000 Set XKB_CONFIG_ROOT variable when launching Linux standalone commit aab27b7bd4f7d483e703295d006e0bd0f5bbdc42 Merge: 0a8c358c9d5 e9054932998 Author: Andrei Savici <[email protected]> Date: Wed Feb 12 16:37:47 2025 -0500 Merge pull request #38801 from mantidproject/EWM8982-throw-exception Matrix Workspace throw exception for invalid plot argument commit 80680b53a6e0dda9a31eb9f7fffe3316ce232bf0 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 17:34:42 2025 +0000 Edit SANS and refl v6.12.0 release notes. commit 811f4456c998dad6ef3e446b7eeb0ad133305b0f Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:11:35 2025 +0000 Amalgamate v6.12.0 release notes for reflectometry and SANS commit 696363b2e6c226b7bb430125ae2a5f7bb2c142f2 Author: Tom Hampson <[email protected]> Date: Wed Feb 12 12:01:05 2025 +0000 Edit muon v6.12.0 release notes commit aa76004a46da8ee2f400c1e2452615eb0a40d85e Author: Tom Hampson <[email protected]> Date: Fri Feb 7 12:09:07 2025 +0000 Amalgamate muon release notes for v6.12.0 commit e905493299869eab2fd1174c2c3e21b62ade5a61 Author: Carson Sears <[email protected]> Date: Tue Feb 11 09:35:54 2025 -0600 check exception with regex commit 0a8c358c9d5caae59d2066f75b84ef6d67f2398f Merge: d1e96c3f656 f90257cd0ec Author: RichardWaiteSTFC <[email protected]> Date: Tue Feb 11 10:03:34 2025 +0000 Merge pull request #38804 from mantidproject/release-notes-6-12-diffraction Release notes v6.12.0 - Diffraction commit f90257cd0eca04620a91ac610ba5c72a72f4c8e5 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue Feb 11 08:48:22 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit ab89e1b8cd4b44a082c0d32ddc458aa89d142ce1 Author: thomashampson <[email protected]> Date: Tue Feb 11 08:45:43 2025 +0000 Final release note edit for diffraction v6.12.0 Co-authored-by: Silke Schomann <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 478414de6a9be41eb66e4a15ac53c95b6a5ec7e2 Author: Carson Sears <[email protected]> Date: Mon Feb 10 15:48:35 2025 -0600 add statement about existing workspaces commit 0b10c28284bc57fe6f09fa7abf3b74855cd32422 Author: Carson Sears <[email protected]> Date: Fri Feb 7 16:34:19 2025 -0600 Update documentation commit 8cc61626acd4993404b73ae4db982752c231ed45 Author: Tom Hampson <[email protected]> Date: Fri Feb 7 17:38:30 2025 +0000 Add and edit missing diffraction release note. commit 404b5b5f57dd9472854fd27e94fc217d35900cee Author: Tom Hampson <[email protected]> Date: Wed Feb 5 17:21:23 2025 +0000 Edit diffraction v6.12.0 release notes commit 72dd346b1e32e34da39946769e949646148e783b Author: Carson Sears <[email protected]> Date: Fri Feb 7 08:16:52 2025 -0600 Matrix Workspace throw exception for invalid plot argument commit add6c28e1aa19678913a12ce15c94f817e24c193 Author: Tom Hampson <[email protected]> Date: Tue Feb 4 15:57:54 2025 +0000 Amalgamate 6.12.0 diffraction release notes commit d1e96c3f6567e1b4b4dd64c89c1e0ff480a4ef94 Merge: 5e605dabdf3 2cd25b9c894 Author: thomashampson <[email protected]> Date: Tue Feb 4 12:49:40 2025 +0000 Merge pull request #38341 from mantidproject/Create_Monte_Carlo_Ws Create Monte Carlo Workspace Algorithm commit 2cd25b9c8942de03ea65b4725076565aebb23cf1 Author: thomashampson <[email protected]> Date: Tue Feb 4 11:24:58 2025 +0000 rename variable commit bad0f7df8573279acf7468982bd631a740148dd4 Author: Despiix <[email protected]> Date: Thu Jan 16 14:28:35 2025 +0000 Adjust Algorithm and tests based on review Update Style of code and image change copyright year to 2025 Rename Variables Update progress bar Update Typo Remove repetitive description Co-authored-by: thomashampson <[email protected]> Co-authored-by: RichardWaiteSTFC <[email protected]> commit 93cd87634522558cd6e8d2a15d97a01477d73c96 Author: Despiix <[email protected]> Date: Thu Nov 28 10:21:08 2024 +0000 Update Scaling Function Does not work if MC events are much less than data points in original workspace Updated Tests Remove redundant code [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 6714fa0b1b8a0970335cdd1f6838e4897ed03c9b Author: Despiix <[email protected]> Date: Mon Nov 25 14:47:31 2024 +0000 Add Input for MC events and ScaleInputToMatchMCEvents and the errors are calculated as the sqrt of the counts. commit 5e605dabdf30e80564f155158877aede95a1cd99 Merge: a70663d5a27 d37cefc8d46 Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:50:40 2025 +0000 Merge pull request #38772 from cailafinn/38768_live_data_doctest Fix segfaulting doctest commit a70663d5a27b4066175a796aa8c5c2d27c890f11 Merge: 3d4b9dcde1a a180fc6484f Author: Silke Schomann <[email protected]> Date: Tue Feb 4 08:46:47 2025 +0000 Merge pull request #38764 from mantidproject/symmetrise-crash Fix crash on inelastic symmetrise interface commit a180fc6484fe284f7919024d742a44f419e0c3bc Author: GuiMacielPereira <[email protected]> Date: Mon Feb 3 11:18:13 2025 +0000 Fix conditional statements with return early style commit 3d4b9dcde1a75e404e1f190ccd83aeb0a6b99db1 Merge: 73d3467d9a3 09e851a0cb3 Author: Reece Boston <[email protected]> Date: Fri Jan 31 19:05:35 2025 -0500 Merge pull request #38777 from peterfpeterson/bugfix_sumspectra Fix a performance issue in SumSpectra with EventWorkspace commit 09e851a0cb39939d9e7baea39d34e2453289f1e2 Author: Pete Peterson <[email protected]> Date: Fri Jan 31 13:38:00 2025 -0500 Fix a performance issue in SumSpectra with EventWorkspace Since it was using EventList::operator+= the memory was reserved as each additional EventList was added in. This calculates the full number of events to be added and reserves that. Then the individual reserve() inside of EventList are effectively no-op. commit 73d3467d9a3f61e9d14129a8c8f9c585777fdbca Merge: 09e34d18196 92b97b60c29 Author: thomashampson <[email protected]> Date: Fri Jan 31 17:30:45 2025 +0000 Merge pull request #38770 from mantidproject/38650_project_recovery_plots_fix Reimplement #38486 to avoid project recovery error commit d37cefc8d46f83881b7885e3c03dcba973c3e3c0 Author: Caila Finn <[email protected]> Date: Fri Jan 31 14:12:03 2025 +0000 Fix segfaulting doctest Including the thread starts in the try block shouldn't make much difference, but I *think* it's stopping a hang that turns into a segfault when the test times out. RE #38768 commit 09e34d1819679afe6b323b64ae3b76e631975f9d Merge: cba714b1d14 cc2aeee31a0 Author: Silke Schomann <[email protected]> Date: Fri Jan 31 14:02:46 2025 +0000 Merge pull request #38769 from mantidproject/Fit_Parameter_cppcheck_bug_v2 Fix bug in Fit_Parameter getConstraint commit 92b97b60c295abf74dae49533533da32d31605bb Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 12:02:24 2025 +0000 update release note commit a82f43d9cd88745a2226ad987c5c9e176b61c782 Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:56:38 2025 +0000 remove argType enum and use .get to avoid the bug commit 51b081da852767dc0e4781eb68656dcb010fd21f Author: Jonathan Haigh <[email protected]> Date: Fri Jan 31 11:54:30 2025 +0000 add test for rename workspace for ws plot with line commit cc2aeee31a05413db89bad64a37f8654990c39bf Author: sf1919 <[email protected]> Date: Fri Jan 31 10:56:32 2025 +0000 Update release note commit 7aa28ac091a89291ea33f334bd6fa19ab0a16be8 Author: sf1919 <[email protected]> Date: Fri Jan 31 10:54:13 2025 +0000 Fix bug in Fit_Parameter getConstraint - As part of fixing cppcheck suppressions a bug was found in getConstraint where the loop was always true for the first if so never reached the other parts. - Tests added to check this behaviour is correct in future - cppcheck suppressions updated commit 30cd7c50356b5bfb51a54cf5952a3843784fd8e8 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 30 16:52:53 2025 +0000 Add Error message when workspace name is empty The problem was that when no workspace was added in the interface, the workspace name is a default empty string. The validating function checkWorkspaceExists() was not adding an error message on this case, which meant that when other functions evaluated if any error had happened (by doing errorString.empty()), the result was assumed valid because the error string was empty. What I did was simply add an error message when the workspace name is empty. This fixes other cases where the same crash was happening for the same reason. commit f8ff56dd4c70591c28c182ec7512a4667c19348a Author: Despiix <[email protected]> Date: Thu Nov 21 15:38:06 2024 +0000 Update Tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Update CreateMonteCarloWorkspace-v1.rst Co-authored-by: Jonathan Haigh <[email protected]> commit 821a49ced12885b5c6ef151cee00062e36442827 Author: Despiix <[email protected]> Date: Thu Nov 21 13:59:10 2024 +0000 Fix Progress Bar, Edit Release Note commit b05a99c526d8b231ddf5445542d0152decb4c7a6 Author: Despiix <[email protected]> Date: Tue Nov 12 16:38:56 2024 +0000 Add Algorithm Documentation Release Notes Add Description and remove redundant 0s [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit b65d0c21af78ccde5f100d289e9c1607c457a160 Author: Despiix <[email protected]> Date: Mon Nov 11 14:35:12 2024 +0000 Add progress bar commit 7b14fc219129d9a5754f90b7c6f694cca766e672 Author: Despiix <[email protected]> Date: Wed Nov 6 15:40:27 2024 +0000 Add 3 Unit tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Added 2 Unit tests to reproducability and out of bounds handling [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit d81ae1dea2e0331822bbc1d9cebd1213dc72dfd6 Author: Despiix <[email protected]> Date: Thu Oct 24 15:32:40 2024 +0100 Version 1 using Cumulative Distribution Function Clean up the codebase and break code into smaller functions. Remove auto and outputY from function Headers commit 44a9b19c5ae490bc25072629bde8672347ca2e59 Author: Despiix <[email protected]> Date: Tue Oct 22 13:13:36 2024 +0100 Added the Probability Density Function + Changed outputWS values Refactor: Clean up code and improve readability commit 878deade325fbccad9d75611afb1c3f7f3073711 Author: Despiix <[email protected]> Date: Tue Oct 22 10:53:05 2024 +0100 Functions to calculate the variance and the mean of the vector containing the random numbers generated. commit 3f28a59c5e4ebc4cf698f76c0180dddff14cb088 Author: Despiix <[email protected]> Date: Fri Oct 11 15:53:04 2024 +0100 Created Files and draft comments commit cba714b1d14a27548526a9951d032b50609d5776 Merge: 7cfebde659c 2da9fbc70f9 Author: Pete Peterson <[email protected]> Date: Thu Jan 30 10:16:18 2025 -0500 Merge pull request #38738 from rosswhitfield/fix_LoadErrorEventsNexus_zero_events Fix LoadErrorEventsNexus/PulseIndexer when there are zero events commit 2da9fbc70f9b671736c7cc6682e7d935558192e5 Author: Ross Whitfield <[email protected]> Date: Thu Jan 30 08:13:14 2025 +1100 Set bin edges for 0 event case commit bbfb41785527463109b971a34e701a5e227d2991 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 12:48:47 2025 +1100 Add release note commit 03ca40508ec99963024fc17d592bbf13bf7cf89e Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:10:22 2025 +1100 Fix BinEdges in LoadErrorEventsNexus commit 5391000735c2cbdb7d7bdef5385bdf53c52af28c Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 11:08:00 2025 +1100 Add test for LoadErrorEventsNexus with zero events commit 3c37a403db2474a10c82d77134162ecdbb9cc6c7 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:57:19 2025 +1100 Fix PulseIndexer commit 5e6300d09ba474f2161c748294ab787cb16cf2b2 Author: Ross Whitfield <[email protected]> Date: Wed Jan 29 10:56:58 2025 +1100 Add failing test for PulseIndexer when zero events commit 7cfebde659c329220386416ef2f9cccba3f222ec Merge: 15d8d2e5f43 0b75b791fcf Author: Pete Peterson <[email protected]> Date: Tue Jan 28 11:55:33 2025 -0500 Merge pull request #38698 from mantidproject/setMarkerStyle Fix setMarkerStyle commit 0b75b791fcf83afbcd061c8c3a10da75efd1be97 Author: Carson Sears <[email protected]> Date: Mon Jan 27 15:18:17 2025 -0600 remove boost function commit 15d8d2e5f4374610d09a57200efb5ff3e7c5880f Merge: 847424031ea c98c59798a3 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:35:26 2025 +0000 Merge pull request #38674 from mantidproject/38628_fix_mslice_nightly_version_bug Enable nightly standalone packages to install mslice nightly versions commit 847424031ea7303455b57747467987ea887731eb Author: Despi <[email protected]> Date: Mon Jan 27 10:23:57 2025 +0000 Surface Plotting from Multiple Single-Spectrum Workspaces (#38599) * Enable Plot All and Okay button * If any workspace contains only 1 spectra then set default value to 1. and minor file reformat * Fix plotting * Add release note * Adjust buttons to correct enable and disable + Adjust Test * Adjust function based on review * Remove Hardcoded "1" Set the default value as the first valid spectrum number * Fix plotting multiple wireframe workspaces * Clean up * Release Note Update * Enable `Plot_All` for Contour plots * Handle Error * Handle Error * If there is already a valid selection (wksp_indices or spectra), just ski * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Update docs/source/release/v6.12.0/Workbench/New_features/38171.rst Co-authored-by: James Clarke <[email protected]> * Changes based on suggestions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Delete duplicate code * Delete duplicate code --------- Co-authored-by: James Clarke <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> commit 727a603e421b4a00cfb8d6384b5e975028f91a8f Merge: ccfa649b1c6 ef97d87e12d Author: Silke Schomann <[email protected]> Date: Mon Jan 27 10:17:08 2025 +0000 Merge pull request #38683 from mantidproject/fix-argus-loading-crash Fix crash from loading into Muon Analysis interface commit ccfa649b1c60cd52a047fb8487e52ead4be868b8 Merge: c18ab182114 22b4ede51b6 Author: Silke Schomann <[email protected]> Date: Mon Jan 27 07:45:07 2025 +0000 Merge pull request #38663 from mantidproject/38464_improve_zero_calibration_validation Add warning for zero-valued calibration spectra commit 67d26ca28db985b003c46db3f2d4111d84c73909 Author: Carson Sears <[email protected]> Date: Fri Jan 24 16:13:36 2025 -0600 fix setMarkerStyle commit c98c59798a372411fd39a5c3ce3a4f6779226f9c Author: Tom Hampson <[email protected]> Date: Wed Jan 22 17:57:04 2025 +0000 Enable nightly standalone packages to install mslice nightly versions commit 22b4ede51b68863717986dc8816c25411d044a4b Author: James Clarke <[email protected]> Date: Fri Jan 24 10:18:21 2025 +0000 Add link to release note commit ef97d87e12d95daee62597fffdcde2c0dfe7d079 Author: GuiMacielPereira <[email protected]> Date: Thu Jan 23 17:36:28 2025 +0000 Check workspace is retrivable from ADS This simple change forces the ADS to check whether the workspace name i.e. load_result["DeadTimeTable"] actually exists. If it doesn't, it gives an error which is caught by the widget, instead of closing the widget and crashing mantid. Not an ideal solution, but a quick and simple one. commit c18ab18211482ca6329ae58ab0c231abd6871bc2 Merge: b78002e00aa 22837a332e7 Author: MialLewis <[email protected]> Date: Thu Jan 23 16:22:13 2025 +0000 Merge pull request #38669 from mantidproject/38654_launch_script_in_editor Skip first argument when calling main in launch script commit 22837a332e764371a326c42a276f35a9cd6c1eb1 Author: James Clarke <[email protected]> Date: Wed Jan 22 15:21:11 2025 +0000 Skip first argument when calling main The first argument of sys.argv is the launch script, so we don't need that. commit b7afa94cea34def4ab49b3530e0bee6799b9a24b Author: James Clarke <[email protected]> Date: Wed Jan 22 12:09:00 2025 +0000 Add test for calibration workspace with zeroes If the calibration workspace has zeroes, then we should get a warning with the correct workspace indices. commit 494b9d2479bd2b69b339f5c2642df46944986219 Author: James Clarke <[email protected]> Date: Wed Jan 22 11:37:05 2025 +0000 Detect zeroes in calibration workspace If the calibration workspace has zero-valued entries, then give the user a warning with the bad workspace indices. commit b78002e00aabc5f819c47e1950fa4f243d086052 Merge: 48117b6b26f 1d4a4e3fe6f Author: Silke Schomann <[email protected]> Date: Mon Jan 20 15:32:47 2025 +0000 Merge pull request #38605 from mantidproject/fix_save_ins Remove symmetry elements for SaveINS commit 1d4a4e3fe6f27a89c01b757c2770fd0d287d45e5 Author: Zachary Morgan (zgf) <[email protected]> Date: Mon Jan 20 08:20:51 2025 -0500 Using less ambiguous names commit 48117b6b26fd63a2cc119395aae966f61c3c9d8d Merge: 1541ebc0496 c155bd1b52a Author: James Clarke <[email protected]> Date: Mon Jan 20 09:49:09 2025 +0000 Merge pull request #38619 from mantidproject/fix_conjoin_workspaces_bug Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit 1541ebc0496f231c20c6ce73afc53bb14de14fbe Merge: f26fb41a3be e47801e3d4d Author: thomashampson <[email protected]> Date: Fri Jan 17 17:20:08 2025 +0000 Merge pull request #38611 from peterfpeterson/windows_suppress_warnings Change windows macro for warnings into compiler flags commit f26fb41a3be4dccf310a0781e4af8280e26e73af Merge: 61bccffbc5b d394998e401 Author: James Clarke <[email protected]> Date: Fri Jan 17 11:58:42 2025 +0000 Merge pull request #38616 from mantidproject/move_incorrectly_place_6_12_release_notes Relocate wrongly positioned v6.12.0 release notes commit c155bd1b52af32a3ebcf695fbcbffc2d54c85ff5 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:50:11 2025 +0000 Fix logic for checking bin consistency in ConjoinWorkspaces algorithm commit e63d5c8e507d63bef65d27b6f76623fc57aa5269 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 11:45:05 2025 +0000 Grammatical fix for warning messages commit b555a4f4b4033ff2cf611c5b3ab064accf667b6d Author: Tom Hampson <[email protected]> Date: Fri Jan 10 17:19:47 2025 +0000 Add ConjoinWorkspaces test to ensure it works for matching bins. commit 12516dfef44e242717a681f5f07c022fd22673d4 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:41:17 2025 -0500 Fix typo in comment commit af956a0209ae2721e4c6c47048afeb9da664e8b6 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:37:08 2025 -0500 Re-organize and comment commit aa64c8d5332d6db9301ca1a138e47daf035ee186 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:33:06 2025 -0500 Re-organize and comment commit a227a36c8aa67bc98525f3ecb9d63f744bf91ee9 Author: Zachary Morgan (zgf) <[email protected]> Date: Fri Jan 17 06:25:32 2025 -0500 Re-organize and comment commit d394998e401273eb1ed50f69ba42f961f9f476b1 Author: Tom Hampson <[email protected]> Date: Fri Jan 17 09:12:06 2025 +0000 Relocate wrongly positioned v6.12.0 release notes commit 61bccffbc5b428396fc86ce0aa19f5976dc3bf3d Merge: 703edc576c6 23abc08cb01 Author: Silke Schomann <[email protected]> Date: Thu Jan 16 18:20:37 2025 +0000 Merge pull request #38574 from mantidproject/36863-FindGlobalBMatrix-warnings 36863 find global b matrix warnings commit 80dd7f9c558834ae1b974ff858bedcc1b62fe8f7 Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 12:21:23 2025 -0500 Add new tests for SaveINS commit 9a1ddec8b27a54b5e22d59e6afba2e55584e085f Author: Zachary Morgan (zgf) <[email protected]> Date: Thu Jan 16 11:57:32 2025 -0500 Bias towards identity and origin commit 23abc08cb011d03e935a620a9c3043b3c7e500dd Author: Andy Bridger <[email protected]> Date: Thu Jan 16 16:31:15 2025 +0000 amend clarity of warnings when too few peaks commit 703edc576c6267755dd1b073da9a79f4bae25f9c Merge: 5ac51730b1a d916b2feeac Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:11:01 2025 +0000 Merge pull request #38459 from mantidproject/cppcheck_2_16 Update cppcheck to 2.16.0 commit 5ac51730b1ac2db044fa0d4adc2ab4ed5ea69d82 Merge: fc0059ccd0e a5937328c06 Author: Caila Finn <[email protected]> Date: Thu Jan 16 16:04:32 2025 +0000 Merge pull request #38601 from jclarkeSTFC/38597_include_alg_profiler_all_os Include AlgoTimeRegister on all operating systems commit d916b2feeacaee79aa815ac4555a5da398ead71c Author: Tom Hampson <[email protected]> Date: Thu Jan 16 14:25:57 2025 +0000 Update cppcheck suppressions for v2.16.0 commit a5937328c06e538684a90d1485b69bf4b670775d Author: James Clarke <[email protected]> Date: Thu Jan 16 14:16:38 2025 +0000 Delete unused cpp file This file is no longer included in the build so should be deleted. commit fe6b26a7860e4ce91fd1cf07a56a7ce6ac138bf0 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 13:27:57 2025 +0000 Group internal cppcheck errors to extract them from the bounty list commit efe7ee752b1db7418f7197e9edc163c61a4ef249 Author: Tom Hampson <[email protected]> Date: Thu Jan 16 11:11:03 2025 +0000 Sort cppcheck supressions by file name and line number commit 19678022dd9ee573b0441e16d20788a26d0cfef6 Author: Tom Hampson <[email protected]> Date: Tue Jan 7 14:44:00 2025 +0000 Restrict cppcheck to unix only. There is no 2.16.0 for Windows. We can re-add it for Windows in the future if it is reinstated. For the time being, since nobody is running it locally, we don't really need it to be installed on Windows. commit aa6475eef539100487046c38e93cee297f6ababd Author: Tom Hampson <[email protected]> Date: Thu Dec 5 10:46:20 2024 +0000 Suppress class_X_Y cppcheck warnings. commit 68568aed3397b834ed5dbd43897d2d19c682e176 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:40:06 2024 +0000 Update cppcheck to 2.16.0 commit 4a19b4f98c6350be94c435a9a5b5b2fec8f4e423 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:37:14 2024 +0000 Remove cppcheck suppressions temporarily for cppcheck update commit 41b6a779abb5ff7fa528198692caea172d569392 Author: Tom Hampson <[email protected]> Date: Fri Nov 29 11:33:06 2024 +0000 fix typo to trigger cppcheck run commit fc0059ccd0ea26cef605008b8fb0c721bcb1701c Merge: 9e35ea46c48 45eeeac224a Author: thomashampson <[email protected]> Date: Thu Jan 16 14:06:38 2025 +0000 Merge pull request #38564 from mantidproject/38558_LoadNGEM_not_respecting_min_max_events Fix bug in LoadNGEM where Min/MaxEventsPerFrame were not respected commit 9e35ea46c48e0ec254491b48658ccd2e97f3f985 Merge: 99b307af65a 221dca92398 Author: thomashampson <[email protected]> Date: Thu Jan 16 12:54:18 2025 +0000 Merge pull request #38173 from mantidproject/35579_move_script_repo_install_location Fix crash after script repository install location is deleted / moved commit ceda6fc8d90eb60714697ec6b194124c01dc4ac0 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 12:33:11 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 413294e5c010af940867f2d3cb0d15c26e9fcebb Author: Andy Bridger <[email protected]> Date: Thu Jan 16 12:30:02 2025 +0000 replace in-place popping with new list appending commit 99b307af65a312aef290cd538059af1e530d508a Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu Jan 16 11:01:15 2025 +0000 [pre-commit.ci] pre-commit autoupdate (#38594) * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.1](https://github.com/astral-sh/ruff-pre-commit/compare/v0.8.6...v0.9.1) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix whitespace that was already wrong * Remove additional whitespace found in local run of pre-commit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pete Peterson <[email protected]> Co-authored-by: sf1919 <[email protected]> commit 45eeeac224a2318cacae3263f6384f521cb4e456 Author: Richard Waite <[email protected]> Date: Tue Jan 14 13:57:35 2025 +0000 Fix cpp check supression commit 6be0546cc8624c6da5bd3969575f6e2f8a7eaed0 Merge: 6c62fe37069 e744dffab96 Author: Andrei Savici <[email protected]> Date: Wed Jan 15 13:37:26 2025 -0500 Merge pull request #38591 from mantidproject/pychop_sns_update Update pychop definitions for SNS instruments commit 6c62fe37069e13d17255d8dedad3db3cb96ca7c4 Merge: 911eca1f711 4f567e74a33 Author: mantid-builder <[email protected]> Date: Wed Jan 15 18:32:20 2025 +0000 Merge ornl-next into main commit 911eca1f711b8ad84077ccd29c674dbca3549cc8 Merge: 4e656006570 e8ed4da6065 Author: Chen Zhang <[email protected]> Date: Wed Jan 15 11:13:43 2025 -0500 Merge pull request #38603 from rosswhitfield/disable_deprecated_qt_api Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 5f4ec8c8d4c3984e97ff49e28b7c9258e9db1bc9 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:59:05 2025 +0000 added check and test for make_ub_consistent commit 09bf7e3c8db8fe68b6e6c76c70f308f8ecb36a8b Author: James Clarke <[email protected]> Date: Wed Jan 15 15:55:50 2025 +0000 Handle base 16 thread ID numbers On macOS, the thread ID is given in hexadecimal, so when converting to an int we need to specify base 16. In other cases we use the default of base 10. commit 4e65600657018125751c6bf293557ba6e096c2aa Author: yusufjimoh <[email protected]> Date: Wed Jan 15 15:31:25 2025 +0000 Refactor WildesTest to reduce Code Duplication (#38529) * created helper functions to reduce code duplications in PolarizationCorrectionWildestest * refactor methods with spinstates, added more helper methods to reduce code duplication * removed helper methods from namespace to class as private methods in PolarizationCorrectionWildesTest * - refactor and improve tests based on suggestions from code review * improve tests based on suggestions from code review * change global constants case to Uppercase --------- Co-authored-by: Oluwaseun Jimoh <[email protected]> commit f499feaf9a1014d72bae69f4eacc8c4ec1f097ad Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 10:24:38 2025 -0500 Bias toward right-handed systems commit 7a9e55c9da998f406689297e20361a6119e85063 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 15:17:37 2025 +0000 added check and test for num_ws indexed by ref_ub commit 9884255ac99ee04ef4bde3463674d26657e7a3d3 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 14:57:12 2025 +0000 Rework Abins docs: input data formats info split out to another page (#38588) * Rework Abins docs: input data formats info split out to another page * Update changelog * Remove spurious "Title" from table RST * Fix AbinsDataFormats table header; drop spaces from label Even without spaces in the label, I am having trouble getting the new file to appear in the concepts index. * Add concepts category to new docs file; add local contents This category seems to be required for the new page to show up in concepts index. Also add a little contents section to the top of the file. commit 30baff0e4fd42d085261195245079ddb48dfbd68 Author: Michael Walsh <[email protected]> Date: Wed Jan 15 09:29:09 2025 -0500 added and propagated FullBinsOnly flag (#38550) * added and propagated FullBinsOnly flag * added a release note * added tests for ragged and non ragged workspace paths in rebin ragged for fullbinsonly * add missing - for release note * added doc reference to rebinragged page for a better explanation of FullBinsOnly * added an additional code sample explaining the new param * spellcheck commit b9697cf9a6db16d0658bb76eb95c2e62970b9fa3 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:03:21 2025 -0500 Add indentity back commit 72ffabb4b956c892c7c05de978b2b9df5bc0a5ca Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 09:00:40 2025 -0500 Move release note commit eb814b06cfe2ceaaa72b0cbd15ce563b8f895133 Merge: 864d61e6642 7dafe330062 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 13:59:26 2025 +0000 Merge pull request #38606 from ajjackson/abins-cache-error Detect unwriteable Abins cache, raise better error commit 0dc1b9be73febf0cc615c0a9c0a5a9e530b287fb Author: James Clarke <[email protected]> Date: Wed Jan 15 12:16:44 2025 +0000 Fixes for AlgoTimeRegister on Windows A long on Windows x64 is 4 bytes, but on Linux it is 8 bytes. To hold nanoseconds we need 8 bytes. By using size_t we'll get an 8 bytes integer. File system handling is different on Windows. So in the test, make the file in the class set up, close it, then open it to write when required. commit 3f6b975218f2522c0be4831427d2d32d9dc58718 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:13:41 2025 -0500 A/B/C-centering commit 127ad8a562b1d6a342d3a96cf3276e2faf2a6ded Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 07:10:07 2025 -0500 C-centering commit 1b50fe7425c53c43ece4dbc0ec1d2ad9596f50ac Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:53:04 2025 -0500 Fix typo commit 88b7bc246b91023a1378797abde3a6f0a89dbb73 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:48:47 2025 -0500 Adding release doc commit 076e038c7d70c1c2f1730456231a5bc337058363 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:43:33 2025 -0500 Comment code commit 80a7c636be4b258f49ebe18bba029f7a7d603e19 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:42:15 2025 +0000 improved readability of find_initial_indexing commit 703a22c9bd70ec422cc08518d0d9cb9a0af4a939 Author: Zachary Morgan (zgf) <[email protected]> Date: Wed Jan 15 06:36:46 2025 -0500 Forgot primitive commit a5168730d0896c2c6b58f5b066dc95e9951b04c4 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:32:52 2025 +0000 collapse removal warning into one message commit c98ff406e5c64c03df431f57da4cbad3a357b326 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:30:52 2025 +0000 made final treatment of refUB into one loop commit 7dafe3300628314fef70e339c7dadca5d28ec9b5 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 11:14:24 2025 +0000 Correct type annotation Sadly the code here is not using Pathlib yet. Hopefully that will change soon! commit c790f5753015722929335434430ea2fa94726601 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:08:55 2025 +0000 moved SetUB call to exec_child_alg commit e5a7d5aaa24f6507972340812876f4bb91d515ae Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:05:19 2025 +0000 removed redundant IndexPeaks call commit 76d314b405042b0d59c2896face02c6fdfb1be56 Author: Andy Bridger <[email protected]> Date: Wed Jan 15 11:03:23 2025 +0000 reduced num repeated loops and calcs commit 7b21c2b693c977d4000ed028b8c27af81138395b Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:40:40 2025 +0000 Add release note commit 864d61e6642f7ac8b3c1556b4b2eb9a94268376d Author: andy-bridger <[email protected]> Date: Wed Jan 15 10:35:50 2025 +0000 37795 change polaris pdf norm (#38535) * Updated vanadium norm dict as per issue #37795 Some extra changes will be needed as this norm_dict doesn't seem to be called properly * Removed hard-coded vanadium normalisation method * Added test support for pdf_norm options #37795 Updated the enum to recognise the option and updated the tests so "Relative" is no longer hard coded - added an extra test some corresponding files * Updated Test files for pdf_norm inclusion #37795 * moved repeated validation code to helper * improved run_focus_absorption readability * Add release notes * Updated the Polaris Docs commit 30035cc43ee870ee42ac4f9b3571feb21fceced8 Author: Adam J. Jackson <[email protected]> Date: Wed Jan 15 10:19:23 2025 +0000 Detect unwriteable Abins cache, raise better error commit 820aecc4300a286e4b67df35845f0696d9b90efe Author: Andy Bridger <[email protected]> Date: Wed Jan 15 09:35:52 2025 +0000 updated validateInputs and its tests commit d4750d9749499253238372702ffa3ab0cf394d9b Merge: e4575ed635f f281969b387 Author: Silke Schomann <[email protected]> Date: Wed Jan 15 08:31:32 2025 +0000 Merge pull request #38515 from mantidproject/38439_use_MD_fitting_IntegratePeaks1DProfile Use MultiDomainFunction in IntegratePeaks1DProfile commit d217e7a78af4e1332e2af1544689855f0d564210 Author: Zachary Morgan (zgf) <[email protected]> Date: Tue Jan 14 22:32:23 2025 -0500 Remove symmetry elements commit e744dffab96530ce3c8b5c099d6a6a4998b769f7 Author: Duc Le <[email protected]> Date: Tue Jan 14 23:15:26 2025 +0000 PyChop-SNS: Fix bug wrong freq for aperture width commit e8ed4da6065dce8a9da37b245babe7f3bc33343e Author: Ross Whitfield <[email protected]> Date: Wed Jan 15 11:14:39 2025 +1100 Disable use of C++ API deprecated in Qt 5.15 in preparation for move to Qt6 commit 03ac026aa3159375611e098388131da2cbd718df Author: Duc Le <[email protected]> Date: Tue Jan 14 17:41:36 2025 +0000 PyChop-SNS: correct Ikeda-Carpenter eqn in yaml commit 9670e52487e6e7cd0d6d940ef6582cf603f91e16 Author: Duc Le <[email protected]> Date: Tue Jan 14 17:35:55 2025 +0000 PyChop-SNS: Add flux units to GUI and yaml commit a54e44633730187dae6ae80aa17fbb816d59c31f Author: James Clarke <[email protected]> Date: Tue Jan 14 15:38:02 2025 +0000 Include AlgoTimeRegister on all operating systems By only including it on Linux, we need to either edit the docs to only have examples that only work on Linux, or selectively include the doc page for that class. It doesn't do any harm to use AlgoTimeRegister on other operating systems, then the tests can be run on all OS's, and things are a bit neater. commit e4575ed635f1d0ecbb5b228719d8372ffe7569fc Author: Silke Schomann <[email protected]> Date: Tue Jan 14 14:16:14 2025 +0000 Added release notes for MSlice (#38596) commit 221dca923988aab04ba6fba17a9863655c9414a4 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 14 13:59:55 2025 +0000 fix cppcheck return by const ref commit bdd6f43b0fcf4937d4bbff80938a390c9b6b74e6 Author: Jonathan Haigh <[email protected]> Date: Tue Jan 7 13:36:26 2025 +0000 remove now unneeded changes commit 51586ce2ff7bfaff024abac18ce7418ce46233cf Author: Duc Le <[email protected]> Date: Tue Jan 14 01:32:04 2025 +0000 PyChop-SNS: Add docs. Got agreement with rez.mcvine.ornl.gov commit a9fe5cd18be2a40c60e27eec2f9f41fbadb27f19 Merge: 658472146df b66e3b3e135 Author: mantid-builder <[email protected]> Date: Tue Jan 14 00:20:43 2025 +0000 Merge ornl-next into main commit 658472146dfaf92e9a546e31da800f32241d3203 Merge: c7f74ccbf28 462310bf6ef Author: Pete Peterson <[email protected]> Date: Mon Jan 13 11:58:19 2025 -0500 Merge pull request #38580 from mantidproject/restore-lost-legend Restore lost legend when dragged out of figure commit c7f74ccbf2830cb9ac42a41cb9a5cc1e1d829329 Merge: 61bf054b0c8 423a2454f0b Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:53:58 2025 +0000 Merge pull request #38567 from mantidproject/38560_instance_true_for_create_autospec Add instance=True to mock.create_autospec for speed improvement commit 61bf054b0c8d9315d627cf454f3f732796197bcd Merge: 6ee0b15d7d5 f5cc1c8afbb Author: Silke Schomann <[email protected]> Date: Mon Jan 13 16:32:45 2025 +0000 Merge pull request #38582 from mantidproject/refactor_Save_NXcanSAS Refactor SaveNXcanSAS algorithm to support different variants commit 423a2454f0b667fa6bb90835c61a162e1f9b6f79 Author: Jonathan Haigh <[email protected]> Date: Mon Jan 13 15:25:12 2025 +0000 fix typo Co-authored-by: James Clarke <[email protected]> commit 794f130bf20ab7ba98d67ae2799b7c87cdaff920 Author: Duc Le <[email protected]> Date: Mon Jan 13 14:03:41 2025 +0000 Update pychop definitions for SNS instruments commit 6ee0b15d7d58be39fc02daf7c8d01a9f384471de Merge: e9176f323bd 3bc0c167126 Author: mantid-builder <[email protected]> Date: Mon Jan 13 13:52:34 2025 +0000 Merge ornl-next into main commit e9176f323bd7303e1b9b16e4d1d70922b02d0f04 Merge: a411fec9bb7 ac355057671 Author: Silke Schomann <[email protected]> Date: Mon Jan 13 07:26:03 2025 +0000 Merge pull request #38587 from rosswhitfield/sliceviewer_allow_custom_colormaps Allow users to register custom matplotlib colormaps commit a411fec9bb779acef8e7d27a4f7295d1405bb3e5 Merge: f579a71c7af 9c6d1b1a057 Author: Andrei Savici <[email protected]> Date: Fri Jan 10 14:50:41 2025 -0500 Merge pull request #38584 from peterfpeterson/38332_nexus_sorted_includes Remove clang-format suppressions commit f579a71c7afdeb67761dde29db2a9a0f2e6e6a14 Merge: be2990a7429 2a4279ce2fd Author: mantid-builder <[email protected]> Date: Fri Jan 10 15:21:48 2025 +0000 Merge ornl-next into main commit 7e1b17f89e491c1c0a9d7934cff1be4e159ef51a Author: Tom Hampson <[email protected]> Date: Fri Jan 10 14:41:31 2025 +0000 Update misleading function documentation. The function does not compare sizes of workspaces, so the comment was wrong. commit be2990a7429ab61fa821a248d0dfcf28bc70dd25 Merge: f81538d597c 6fb8ac3731d Author: Silke Schomann <[email protected]> Date: Fri Jan 10 14:10:20 2025 +0000 Merge pull request #38581 from rbauststfc/add_exception_to_SANS_move_test Add exception to SANS move test helper method commit 517eecff220802fc649b5aa9387216e14210a56c Author: Tom Hampson <[email protected]> Date: Fri Jan 10 12:18:42 2025 +0000 Remove old commend It doesn't make any sense and just confused me commit 462310bf6ef95f568ae8661450f035074e5fb8f8 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri Jan 10 12:16:12 2025 +0000 [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci commit 5e961cb44831746d9b612553b118bde3f49d52ae Author: Despi <[email protected]> Date: Fri Jan 10 12:13:53 2025 +0000 Update qt/applications/workbench/workbench/plotting/figureinteraction.py Co-authored-by: Jonathan Haigh <[email protected]> commit f81538d597c2dbc8e2e87a74b918235596262835 Merge: 8c287822338 b767628baf4 Author: thomashampson <[email protected]> Date: Fri Jan 10 11:54:51 2025 +0000 Merge pull request #38513 from mantidproject/update_mslice_manual_test_docs Added section for testing ADS interactions to MSlice manual testing doc commit 16790c7fc1965700c18ed7ea0a755a96c799423c Author: Despiix <[email protected]> Date: Fri Jan 10 11:54:18 2025 +0000 Changes based on review commends commit b767628baf440e22bc12eff1304e3f7089a2e889 Author: thomashampson <[email protected]> Date: Fri Jan 10 10:44:42 2025 +0000 fix grammatical error in docs commit 8c28782233867eea94a225ceb1711899e737a787 Merge: 52d7654ed8a b22c536545f Author: thomashampson <[email protected]> Date: Fri Jan 10 10:41:16 2025 +0000 Merge pull request #38583 from mantidproject/napi5_systemtest_bug Ensure variable is initialised in Nexus code commit f5cc1c8afbba68e923f8be5f4ee64e73395f2fe9 Author: adriazalvarez <[email protected]> Date: Fri Jan 10 09:59:52 2025 +0000 Update header date on new file commit f9618ec588879e933e51103b37cf08968080cb19 Author: Despiix <[email protected]> Date: Fri Jan 10 09:21:06 2025 +0000 Fix failing text commit 52d7654ed8a67a2e7afa7b25dbee764c58d82e21 Merge: 65ebaa6ff4c 0610193cb85 Author: Silke Schomann <[email protected]> Date: Fri Jan 10 07:51:30 2025 +0000 Merge pull request #38538 from peterfpeterson/cc_gdo_docs CrossCorrelate and GetDetectorOffset algorithm user docs commit 65ebaa6ff4c5dc387654632f9f8fe316f3553618 Merge: df70d89339a 0453e5e0c01 Author: mantid-builder <[email protected]> Date: Fri Jan 10 01:03:57 2025 +0000 Merge ornl-next into main commit df70d89339a6c7d83d02f7537a6611800dff47a1 Merge: 3163798c8ad 0ac1c789a2f Author: mantid-builder <[email protected]> Date: Thu Jan 9 21:07:57 2025 +0000 Merge ornl-next into main commit 5b5fca5f0914c78ac9e2b0a90a6a9bc993dd2577 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 19:17:17 2025 +0000 Fix doxygen documentation warnings: 1. There were doxygen lines in add2DData function that needed to be escaped with \. to avoid a warning, this was not detected before as doxygen does not look in anonymous namespaces for mantid. 2. There was a doxygen comment missing input parameters to the function addInstrument. commit 3163798c8ad38aeeadedbe2be1f17fe2c31cfda3 Merge: 0681ab27e44 f7982b0abf7 Author: Chen Zhang <[email protected]> Date: Thu Jan 9 13:26:05 2025 -0500 Merge pull request #38565 from peterfpeterson/gtest_pin Clarify that gtest is pinned to v1.15.2 commit 0681ab27e4467c580b795fe7f33d5ad5b0bd3e78 Merge: 17ee6bbae9e 2e7242e878f Author: Pete Peterson <[email protected]> Date: Thu Jan 9 13:22:48 2025 -0500 Merge pull request #38486 from mantidproject/mantidaxes_lines_and_renameworkspace_exception account for lines sharing graphs with workspaces in mantidaxes commit b22c536545f3ecb35434d1c4bad219ed6e1cc13c Author: Andy Bridger <[email protected]> Date: Thu Jan 9 17:48:41 2025 +0000 initialise herr_t iRet to 0 commit 38fef13bbb34923f50b77e8b8aa82b99e6c079dd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:31:43 2025 +0000 Fix cppcheck style warning: commit e98b1be5a4dd1df439566fc8594a99fdc4552dbd Author: adriazalvarez <[email protected]> Date: Thu Jan 9 16:20:15 2025 +0000 Fix typo in include path on cmakelist commit 17ee6bbae9e31d7e22ee835eeb7b0ad91bc00d2c Merge: 27b1a2c3403 bc7e058e29e Author: mantid-builder <[email protected]> Date: Thu Jan 9 15:11:07 2025 +0000 Merge ornl-next into main commit 6fb8ac3731d8c97205f3c3b59d8b7f00ec528fb1 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 14:50:05 2025 +0000 Add exception for unsupported instrument name commit 1d260bf0ebc31e8baa0d503d0b03ab3692188d85 Author: Despiix <[email protected]> Date: Thu Jan 9 14:57:21 2025 +0000 Add release note commit 27b1a2c340372b263256ee5cdb06c0f71d273722 Merge: 77d31880c71 9631fe5c07f Author: Silke Schomann <[email protected]> Date: Thu Jan 9 14:34:47 2025 +0000 Merge pull request #38577 from rbauststfc/fix_SANS_ZOOM_move_test Fix SANS move test failure commit 2d9634ea417de56d166807fbdf17ad6cb98c4aff Author: Despiix <[email protected]> Date: Thu Jan 9 14:24:35 2025 +0000 Add Function that solves issue It compares the size of the figure with the coordinates of the legend to see if it's out of range and if it is it snaps it back to its default position. commit 52b5e3ac712fe25760a20e2a841047a8d4861acc Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:18:25 2025 +0000 Organize code, add some descriptions and refactor some individual lines commit c8898d09d9b2eb517b9692d75f777f26756cbd83 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:17:36 2025 +0000 Referene to helper file in tests commit 868a9f434079ec21770d3ed5f52d555a73041764 Author: adriazalvarez <[email protected]> Date: Thu Jan 9 13:16:51 2025 +0000 Add file for NXcanSAS helper functions commit ea9bb892835eeac840e706955ad8968dcd882eee Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:03:37 2025 +0000 Add parent SaveNXcanSasBase class with helper functionsin anonymous namespace commit d39fdf9d9dd439d95a6629a2d7aea2b0a2105f9f Author: adriazalvarez <[email protected]> Date: Tue Jan 7 11:02:18 2025 +0000 Remove helper and main exec structure out of inherited saveNXCanSass, inherit from saveNXcanSASBase commit 9631fe5c07fed8404cfb058cd39567dcd46d6d87 Author: Rachel Baust <[email protected]> Date: Thu Jan 9 10:44:53 2025 +0000 Specify version of IDF to use in SANS move tests commit 77d31880c71e715424c8679bd47a196b51eb61b2 Merge: e6d3e6f33f8 94614aa94dd Author: Silke Schomann <[email protected]> Date: Thu Jan 9 10:16:10 2025 +0000 Merge pull request #38573 from peterfpeterson/38457_generate_export_header Remove includes of MantidKernel/System.h commit e6d3e6f33f8da9bc6a95035df1e7386a04dde479 Merge: beadc9d8abf 9cbc06067b0 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:49:11 2025 +0000 Merge pull request #38197 from mantidproject/38102_view_not_to_call_presenter_methods_directly Remove direct calls to presenter from cut viewer view commit beadc9d8abfab95aedc7acd498714126597d3eda Merge: 8eab7f131fe 8981bece2c2 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 09:33:13 2025 +0000 Merge pull request #38514 from mantidproject/38030_remove_pop_up Remove off-putting error prompt that appears when canceling a MaxEnt calculation in the Muon FDA interface commit 8eab7f131fe76f1e3e3f951b530811df8561784c Author: Waruna Priyankara J A Wickramasingha <[email protected]> Date: Thu Jan 9 09:16:24 2025 +0000 38254 add PeakShapeDetectorbin to integration algorithms (#38452) * Unit tests added for equal opeartor in python and c++ * early return added and cppcheck fix * reverted exposing opearator== into python for consistency * PeakShapeDetectorBin added to IntegratePeaksSkew * PeakShapeDetectorBin added to IntegratePeaksShoeboxTOF * PeakShapeDetectorBin added to IntegratePeaksSkew * null check added for ipos data * updated for review comments. Q plottting yet to do * Unit tests added * integratepeaksshoebox xlimits and det ids updated * release note updated * updated note commit 24dcde322389df921a863df4a403ea9f99de6fd9 Author: Mohammed Almakki <[email protected]> Date: Thu Jan 9 09:15:20 2025 +0000 Add table view for group peak workspace (#37166) * Add group peak workspaces model * Add show data to group peak workspaces * Add group presenter and table model * Add support for sorting, deleting, plotting, stats, and batch loading * Add group model unit tests * Add group table model unit tests * Add group presenter unit tests * Add release note commit 67ac3fe1e9538f7ccaa67ebd93a391116de5ad6b Merge: 5a0bafe803e 73c368c4920 Author: Silke Schomann <[email protected]> Date: Thu Jan 9 07:54:51 2025 +0000 Merge pull request #38556 from rosswhitfield/fix_sliceviewer_data_exception Fix invalid data when MDHistoworkspace replaced and has original workspace commit 2e7242e878fe6435d1b805bd9b45649fb64dd994 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 15:17:57 2024 -0500 fix failing test file commit 159b14c40e8338f52d54b1e116b732914c4fa40c Author: Michael Walsh <[email protected]> Date: Fri Dec 6 14:18:48 2024 -0500 added release note commit 61f78e2bb22c0703f3477376714a4d1aee2e3a18 Author: Michael Walsh <[email protected]> Date: Fri Dec 6 13:18:48 2024 -0500 account for lines sharing graphs with workspaces in mantidaxes commit 5a0bafe803e9ef7816d59f957d33ff0457f48a54 Merge: 754148a9b75 ff47bef4556 Author: mantid-builder <[email protected]> Date: Wed Jan 8 20:19:19 2025 +0000 Merge ornl-next into main commit 754148a9b752f31d24401d2d3525e4892d377c4e Merge: 17a7a926a45 00d26587feb Author: mantid-builder <man…
Description of work
Fix for a crash where if you moved / deleted your local script repository install and clicked reload, mantid would crash.
Now there is a check to make sure the dir exists, and the user is prompted to reinstall if not.
The label displaying the location is updated as well.
Sorry for slightly messy PR, I tried to do this cleverly with a QFileSystemWatcher at first.
Fixes #35579
To test:
File -> Scrpit Repository
to open the interface (you will probably be prompted to install)Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.