-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subject editing #9
Merged
Merged
Changes from 41 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
3bbbaec
Implemented registration device with google omniauth
mantasavas 6dcdece
added bootstrap and meniu
mantasavas fcad0c2
Finished registration form design
mantasavas 481d9f8
Changed meniu color, added sign up and log in styling
mantasavas 7cc85cd
Added image background
mantasavas d54dfef
Hided created subjects from unauthenticated users view, removed backg…
mantasavas 7c117d8
Added pg and rails12 factor for heroku
mantasavas 71736fe
Changed meniu color, added sign up and log in styling
mantasavas 1c9bd45
Changed meniu color, added sign up and log in styling
mantasavas fa1966d
Changed meniu color, added sign up and log in styling
mantasavas b8519e9
fixing with robocop
mantasavas 9545aed
Fixed code style: changed hash syntax, used single quotes there neces…
mantasavas dbcde58
Fixed code style: changed hash syntax, used single quotes there neces…
mantasavas 9570e99
Added link to heroku hosted application in readme
mantasavas 0d91b9c
Added application description
mantasavas 0798f75
Subjects can be created in database
mantasavas 5ea0d10
Added view all posts
mantasavas 165b969
Created Trix editor, sanitized fields, added editing functionality of…
mantasavas 0088945
Added delete subject
mantasavas d256ce8
Users cannot delete or edit subjects which they didn't created, added…
mantasavas e5e31d8
Added edit, navigation, index, new forms styling
mantasavas 487eab1
Added restrictions on which actions can be accessed
mantasavas 7616252
Fixed trix editor, didn't worked on heroku
mantasavas 2c4180f
Rolled back changes for fix
mantasavas b5b39a1
Fixed background image on heroku
mantasavas c7274ba
Fixed header static text
mantasavas bb431fa
Merge branch 'subject-editing'
mantasavas 115fac9
Took sqlite to development environment
mantasavas 76b0ffa
Changed sqlite environment
mantasavas 7225565
added rspec tests for user model
mantasavas 191b2e2
Added rspec tests
mantasavas 3b61ed9
Merge branch 'master' into user-authentication
mantasavas e5338ff
Removed .rubocop_todo.yml file, from now on used rubocop -a command
mantasavas 957adaa
removed .rubocop_todo.yml, runned rubocop -a command
mantasavas 56c5e6c
grouped factory, rspec, pry into test and development environments
mantasavas a471bfa
removed callback, subject, welcome javascript files
mantasavas 233b7eb
fixed typo in user model method, removed unnecessary comments
mantasavas 5a1d543
Renamed controller to subjects, fixed routing, removed locals, was un…
mantasavas 6d32d51
removed unnecessary autogenerated test files from repo
mantasavas 41c3843
Corrected user model rspec tests, added email uniqueness
mantasavas fb32cfe
Added subject controller tests with capybara and rspec
mantasavas 3f323bb
added associations to factorybot, user has many subjects, added get i…
mantasavas eaca4d9
lint scss used to fix stylesheets, runneed rubocop
mantasavas 404f93a
added hound file
mantasavas c7e2d9e
added let and before statements together
mantasavas f686312
added codeclimate
mantasavas 7a3930a
add more readable subject controller tests
mantasavas 604db97
added dependent on subject
mantasavas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
--color | ||
--require spec_helper | ||
--format doc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
require: rubocop-rspec | ||
|
||
Rails: | ||
Enabled: true | ||
|
||
RSpec/NestedGroups: | ||
Enabled: false | ||
|
||
Metrics/LineLength: | ||
Enabled: true | ||
Max: 120 | ||
Exclude: | ||
- db/migrate/* | ||
|
||
Metrics/BlockLength: | ||
Exclude: | ||
- spec/**/*.rb | ||
|
||
Lint/AmbiguousBlockAssociation: | ||
Exclude: | ||
- spec/**/*.rb | ||
|
||
Style/Documentation: | ||
Exclude: | ||
- app/helpers/**/* | ||
- db/migrate/* | ||
|
||
AllCops: | ||
TargetRubyVersion: 2.4 | ||
Exclude: | ||
- bin/* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this gem should not belong to
:development
group