Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary colorama dependency #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

li-wjohnson
Copy link

Description of new feature, or changes

Remove colorama dependency.
Colorama was used for two things:

  • colorama.init calls, which had no effect. init wraps sys.stdout / stderr, which aren't used here.
  • a few ansi color codes, which have been replaced by a handful of constants

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

Related to manrajgrover/halo#151

People to notify

@manrajgrover manrajgrover self-requested a review September 19, 2020 08:39
@manrajgrover
Copy link
Owner

@li-wjohnson Thanks for raising this PR!

Wouldn't this impact Windows output? Can you share output on Windows system (cmd, powershell)?

@li-wjohnson
Copy link
Author

I don't have any sample output, but it should be obvious colorama has no effect here. There is an init() followed by a deinit(), with no printing in between. Colorama only wraps stout/stderr.

@li-wjohnson
Copy link
Author

Just for you, I ran this on cmd.exe:
Before:
before
After:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants