Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows terminal support #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-makaro
Copy link

@t-makaro t-makaro commented Jan 15, 2020

Description of new feature, or changes

Adds support for all spinners when using windows terminal.

Note: If using jupyter notebook spawned from windows terminal, when all characters display correctly. If using jupyter notebook not spawned from WT, then the characters display fallbacks dispite not needing them. HaloNotebook could just patch the is_supported call``` to ignore it, but that would not work as well for LogSymbols.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature (bug fix)
  • All tests are passing

Related Issues and Discussions

Fixes #5

People to notify

@coveralls
Copy link

coveralls commented Jan 15, 2020

Pull Request Test Coverage Report for Build 425

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 91.041%

Changes Missing Coverage Covered Lines Changed/Added Lines %
halo/_utils.py 2 3 66.67%
Totals Coverage Status
Change from base Build 422: 1.5%
Covered Lines: 307
Relevant Lines: 331

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Windows Support
2 participants