Clean iss param from location search after login #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerrDerb
changed the title
|
@manfredsteyer Would be great if this PR can be reviewed and merged! Thanks! |
|
@L-X-T looking at the commit history, did you take over maintenance of the repo? seem like manfred has abandoned the project since ~1 year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://datatracker.ietf.org/doc/draft-ietf-oauth-iss-auth-resp/00/ the issuer is appended to an authentication response with the iss query param.
Currently the angular-oauth2-oidc library ignores to clean that parameter after login. This results in a restoreState with appended iss query param.
This pr also cleans the iss parameter.
refers to -> #1415