Skip to content

Conversation

thaichat04
Copy link
Contributor

From #86:

  • add example/examples on content Body Request
  • make attributs are optional

@manchenkoff
Copy link
Owner

Hey @thaichat04, thanks a lot for the contribution! However, there are some failing tests since you extended the data class. Please, take a look and we are ready to go!

@thaichat04
Copy link
Contributor Author

Thanks, I didn't see tests failed. Sorry

@manchenkoff
Copy link
Owner

Thanks, I didn't see tests failed. Sorry

There are still some errors after your last commit:

ERROR tests/test_parser.py - TypeError: __init__() missing 1 required positional argument: 'example'
ERROR tests/test_runner.py - TypeError: __init__() missing 1 required positional argument: 'example'
ERROR tests/builders/test_content_builder.py - TypeError: __init__() missing 1 required positional argument: 'example'
ERROR tests/builders/test_request_builder.py - TypeError: __init__() missing 1 required positional argument: 'example'

you can run them locally via

pipenv run python setup.py install
pipenv run pytest

@manchenkoff manchenkoff self-requested a review September 2, 2024 21:02
@manchenkoff manchenkoff merged commit 7e6faa1 into manchenkoff:master Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants