Fix empty error window #230
Conversation
There was a problem hiding this comment.
Looks good to me. BTW are you testing this functionality in master using dnf5daemon?
There was a problem hiding this comment.
I have dnf 4.14.0 on my distro. I think if anyway there's no error with dnf 5, this text won't be shown.
There was a problem hiding this comment.
@anaselli I suggest to change the text:
err = _('The list of packages cannot be installed:') + '\n' + '\n'.join(self.options['install'] + '\nMaybe some of them are already installed.')
We couldn't find this error in other cases rather than this. An empty error window appeared only when there were packages had been installed beforehand. Maybe it can help users.
| @@ -1993,6 +1993,8 @@ def _OnBuildTransaction(self, info): | |||
| self._status = DNFDragoraStatus.RUN_TRANSACTION | |||
| else: | |||
| err = "".join(resolve) if isinstance(resolve, list) else resolve if isinstance(resolve, list) else repr(resolve); | |||
| if not err: | |||
| err = _('The list of packages cannot be installed:') + '\n' + '\n'.join(self.options['install']) | |||
There was a problem hiding this comment.
Maybe "The list of packages that cannot be installed"?
There was a problem hiding this comment.
В этой фразе "the" переводится как "этот" или "данный". Всё правильно.
There was a problem hiding this comment.
У тебя пропущено слово "которые" ("that" или, может, лучше "which", надо подумать)
When installing the package that is already installed, error window has no text. This patch fixes the problem.