Fix jdtls, rust-analyzer documentation issues. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current jdtls lsp server textDocument/hover response contains a dict
and then a plaintext, such as
```json
{
"contents": [
{
"language": "java",
"value": "org.springframework.boot.SpringBootApplication"
},
"Class that can be used to bootstrap ....."
]
}
```
Lsp-bridge renders a ```text``` block with plaintext.
This patch checks response for "language": "java", and render doc
contents without modification when java found, since responding doc
already in "markdown" format.
Configure "jdtls" and "rust-analyzer" configurations to request
"markdown" format content in textDocument/hover requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current jdtls lsp server textDocument/hover response contains a dict and then a plaintext, such as
{ "contents": [ { "language": "java", "value": "org.springframework.boot.SpringBootApplication" }, "Class that can be used to bootstrap ....." ] }Lsp-bridge renders a
textblock with plaintext.This patch checks response for "language": "java", and render doc contents without modification when java found, since responding doc already in "markdown" format.
Configure "jdtls" and "rust-analyzer" to request "markdown" format content in textDocument/hover requests.