Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added database support and editing and deleting feature #24

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Apr 13, 2020

Signed-off-by: Nikhil-Ladha [email protected]

What is the purpose of this pull request?

This PR adds Database support for the app, editing and deleting features in the app and a bit of animation for deleting and listing.

What problem is this solving?

Database support, Edit & Delete feature

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Fixes/Resolves #17, #18 , #19 , #21

Addresses #5

Copy link
Owner

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, can you please add the instructions to use the adapter-sqlite-cordova plugin once the app is setup in the README itself?

@Nikhil-Ladha
Copy link
Contributor Author

Oh yes, sure. Will update it too.

@manaswinidas
Copy link
Owner

Great job @Nikhil-Ladha. Keep up the good work!

@Nikhil-Ladha
Copy link
Contributor Author

Sure. Thanks @manaswinidas 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate whether all the features work fine in mobile
2 participants